From patchwork Tue Jan 15 18:42:58 2019 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: "Paul A. Clarke" X-Patchwork-Id: 31068 Received: (qmail 65943 invoked by alias); 15 Jan 2019 18:43:06 -0000 Mailing-List: contact libc-alpha-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Unsubscribe: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: libc-alpha-owner@sourceware.org Delivered-To: mailing list libc-alpha@sourceware.org Received: (qmail 65931 invoked by uid 89); 15 Jan 2019 18:43:06 -0000 Authentication-Results: sourceware.org; auth=none X-Spam-SWARE-Status: No, score=-27.6 required=5.0 tests=BAYES_00, GIT_PATCH_0, GIT_PATCH_1, GIT_PATCH_2, GIT_PATCH_3, RCVD_IN_DNSWL_LOW, SPF_PASS autolearn=ham version=3.3.2 spammy=Hx-languages-length:931, HTo:D*vnet.ibm.com, HContent-Transfer-Encoding:8bit X-HELO: mx0a-001b2d01.pphosted.com To: GNU C Library , Tulio Magno Quites Machado Filho From: Paul Clarke Subject: [PATCH][powerpc] Fix tiny bug in strncmp.c Date: Tue, 15 Jan 2019 12:42:58 -0600 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.9.1 MIME-Version: 1.0 x-cbid: 19011518-0016-0000-0000-00000975EC5F X-IBM-SpamModules-Scores: X-IBM-SpamModules-Versions: BY=3.00010413; HX=3.00000242; KW=3.00000007; PH=3.00000004; SC=3.00000274; SDB=6.01146933; UDB=6.00597400; IPR=6.00927226; MB=3.00025142; MTD=3.00000008; XFM=3.00000015; UTC=2019-01-15 18:43:01 X-IBM-AV-DETECTION: SAVI=unused REMOTE=unused XFE=unused x-cbparentid: 19011518-0017-0000-0000-000041C9B1E7 Message-Id: A single underscore was omitted in sysdeps/powerpc/powerpc64/multiarch/strncmp.c, resulting in use of power8 version of strncmp instead of power9 version, with significant performance degradation. 2019-01-15 Paul A. Clarke * sysdeps/powerpc/powerpc64/multiarch/strncmp.c: Fix #ifdef. diff --git a/sysdeps/powerpc/powerpc64/multiarch/strncmp.c b/sysdeps/powerpc/powerpc64/multiarch/strncmp.c index ab7379d..d2791ce 100644 --- a/sysdeps/powerpc/powerpc64/multiarch/strncmp.c +++ b/sysdeps/powerpc/powerpc64/multiarch/strncmp.c @@ -37,7 +37,7 @@ extern __typeof (strncmp) __strncmp_power9 attribute_hidden; /* Avoid DWARF definition DIE on ifunc symbol so that GDB can handle ifunc symbol properly. */ libc_ifunc_redirected (__redirect_strncmp, strncmp, -# ifdef __LITTLE_ENDIAN_ +# ifdef __LITTLE_ENDIAN__ (hwcap2 & PPC_FEATURE2_ARCH_3_00) ? __strncmp_power9 : # endif