From patchwork Fri Nov 2 11:33:10 2018 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Szabolcs Nagy X-Patchwork-Id: 30007 Received: (qmail 118724 invoked by alias); 2 Nov 2018 11:33:16 -0000 Mailing-List: contact libc-alpha-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Unsubscribe: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: libc-alpha-owner@sourceware.org Delivered-To: mailing list libc-alpha@sourceware.org Received: (qmail 118611 invoked by uid 89); 2 Nov 2018 11:33:15 -0000 Authentication-Results: sourceware.org; auth=none X-Spam-SWARE-Status: No, score=-26.9 required=5.0 tests=BAYES_00, GIT_PATCH_0, GIT_PATCH_1, GIT_PATCH_2, GIT_PATCH_3, RCVD_IN_DNSWL_NONE, SPF_HELO_PASS, SPF_PASS autolearn=ham version=3.3.2 spammy=getconf, sk:_nproce, sk:_NPROCE, unclean X-HELO: EUR04-HE1-obe.outbound.protection.outlook.com DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector1-arm-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=2WctuYkeJPbYGCQs3FOgg9CKFGUpSna7JNHBakDaN1g=; b=BnoU4P+38ih90xRvaV06uyqIuYXaC5QGGL3yMR3siRyDtPEVEt09DBHatIc93M2MJepe+O1iqjrmGw5MEgU7PGgI+CKypFiuzfeSRZOCqK2rEiibzReVUVWOxKJS4qNuPYCU4sU6NJFse2+2m3ZO/gwKL4Qi2SDpBpPNFZCOCEU= From: Szabolcs Nagy To: GNU C Library CC: nd Subject: [PATCH buildbot] keep build directory after failure Date: Fri, 2 Nov 2018 11:33:10 +0000 Message-ID: user-agent: Mozilla/5.0 (X11; Linux aarch64; rv:52.0) Gecko/20100101 Thunderbird/52.9.1 authentication-results: spf=none (sender IP is ) smtp.mailfrom=Szabolcs.Nagy@arm.com; received-spf: None (protection.outlook.com: arm.com does not designate permitted sender hosts) MIME-Version: 1.0 aarch64 buildbot failed with FAIL: malloc/tst-malloc-tcache-leak 4 times so far even though there were no related commits, the failure happens about 1 out of 15 builds and only if the build was done in an unclean directory, but i could not manually reproduce it yet. the buildbot first builds glibc in the previous build directory, if that fails then that immediately gets deleted and glibc is rebuilt starting from an empty build directory, so it's impossible to tell what went wrong in case of such non-reproducible failures. i suggest keeping the last failed build directory for analysis. the build directory rename is not optimal since that breaks absolute paths pointing to it (e.g. paths in testrun.sh), but it allows looking at test outputs and failed binaries. diff --git a/scripts/slave/glibc-native.sh b/scripts/slave/glibc-native.sh index 21c9d2d..8b22687 100755 --- a/scripts/slave/glibc-native.sh +++ b/scripts/slave/glibc-native.sh @@ -14,6 +14,7 @@ nproc=$(getconf _NPROCESSORS_ONLN) root_dir=$(pwd) src_dir="${root_dir}/glibc" build_dir="${root_dir}/build" +old_build_dir="${root_dir}/old_build" git_branch=${BUILDBOT_BRANCHNAME:-master} git_revision=${BUILDBOT_REVISION:-origin/${git_branch}} @@ -81,7 +82,10 @@ do_check() { do_clobber() { clobber=true cd "$root_dir" - rm -rf "$build_dir" + if [ -d "$build_dir" ]; then + rm -rf "$old_build_dir" + mv "$build_dir" "$old_build_dir" + fi }