diff mbox series

[v2] mips: increase stack alignment in clone to match the ABI

Message ID a7a3dc2e7a8ea4ba455614ecd8190adc05790c61.camel@mengyan1223.wang
State Committed
Commit 0f62fe053273ff6c62ac95c59b7687c964737b00
Headers show
Series [v2] mips: increase stack alignment in clone to match the ABI | expand


Context Check Description
dj/TryBot-apply_patch success Patch applied to master at the time it was sent
dj/TryBot-32bit success Build for i686

Commit Message

Xi Ruoyao Aug. 13, 2021, 12:04 p.m. UTC
v2: change the comment along with the code

I must have been too sleepy in recent two days...

In "mips: align stack in clone [BZ #28223]"
(commit 1f51cd9a860ee45eee8a56fb2ba925267a2a7bfe) I made a mistake: I
misbelieved one "word" was 2-byte and "doubleword" should be 4-byte.
But in MIPS ABI one "word" is defined 32-bit (4-byte), so "doubleword" is
8-byte [1], and "quadword" is 16-byte [2].

[1]: "System V Application Binary Interface: MIPS(R) RISC Processor
      Supplement, 3rd edition", page 3-31
[2]: "MIPSpro(TM) 64-Bit Porting and Transition Guide", page 23
 sysdeps/unix/sysv/linux/mips/clone.S | 6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)


Joseph Myers Aug. 13, 2021, 4:02 p.m. UTC | #1
Thanks, I've applied this followup fix as well.
diff mbox series


diff --git a/sysdeps/unix/sysv/linux/mips/clone.S b/sysdeps/unix/sysv/linux/mips/clone.S
index 43a5ad3a40..fd71b5ca2e 100644
--- a/sysdeps/unix/sysv/linux/mips/clone.S
+++ b/sysdeps/unix/sysv/linux/mips/clone.S
@@ -55,11 +55,11 @@  NESTED(__clone,4*SZREG,sp)
 	.set		at
-	/* Align stack to 4/8 bytes per the ABI.  */
+	/* Align stack to 8/16 bytes per the ABI.  */
 #if _MIPS_SIM == _ABIO32
-	li		t0,-4
 	li		t0,-8
+	li		t0,-16
 	and		a1,a1,t0