signal/Makefile: Split and sort tests

Message ID ZmxJjATgysCRBP5v@mbp-m3-centos.vm
State Committed
Commit 4f7eb238d0da989a9deb50e9cd441cca895957dc
Delegated to: Arjun Shankar
Headers
Series signal/Makefile: Split and sort tests |

Checks

Context Check Description
redhat-pt-bot/TryBot-32bit success Build for i686
redhat-pt-bot/TryBot-apply_patch success Patch applied to master at the time it was sent
linaro-tcwg-bot/tcwg_glibc_build--master-arm success Build passed
linaro-tcwg-bot/tcwg_glibc_check--master-arm success Test passed
linaro-tcwg-bot/tcwg_glibc_build--master-aarch64 success Build passed
linaro-tcwg-bot/tcwg_glibc_check--master-aarch64 success Test passed

Commit Message

Michel Lind June 14, 2024, 1:45 p.m. UTC
  This will make it easier to add tests later; see also the test section
in malloc/Makefile that inspires this.

Signed-off-by: Michel Lind <salimma@fedoraproject.org>
Suggested-by: Arjun Shankar <arjun@redhat.com>
---
 signal/Makefile | 21 ++++++++++++++++-----
 1 file changed, 16 insertions(+), 5 deletions(-)
  

Comments

Arjun Shankar July 1, 2024, 11:45 a.m. UTC | #1
Hi Michel,

Thanks for the patch! This looks good to me.

Reviewed-by: Arjun Shankar <arjun@redhat.com>

I'll push it in a bit.

> From e6d37f761df90d97fa9ae7ffa629fa91ca0ee072 Mon Sep 17 00:00:00 2001
> From: Michel Lind <salimma@fedoraproject.org>
> Date: Fri, 14 Jun 2024 15:38:08 +0200
> Subject: [PATCH 1/1] signal/Makefile: Split and sort tests
> To: libc-alpha@sourceware.org
> Cc: arjun@redhat.com
>
> This will make it easier to add tests later; see also the test section
> in malloc/Makefile that inspires this.
>
> Signed-off-by: Michel Lind <salimma@fedoraproject.org>
> Suggested-by: Arjun Shankar <arjun@redhat.com>

OK.

> diff --git a/signal/Makefile b/signal/Makefile
> index e8e3dce0cf..7cddbc3c65 100644
> --- a/signal/Makefile
> +++ b/signal/Makefile
> @@ -46,11 +46,22 @@ routines    := signal raise killpg \
>             allocrtsig sigtimedwait sigwaitinfo sigqueue \
>             sighold sigrelse sigignore sigset
>
> -tests        := tst-signal tst-sigset tst-sigsimple tst-raise tst-sigset2 \
> -           tst-sigwait-eintr tst-sigaction \
> -           tst-minsigstksz-1 tst-minsigstksz-2 tst-minsigstksz-3 \
> -           tst-minsigstksz-3a tst-minsigstksz-4 tst-minsigstksz-5 \
> -           tst-sigisemptyset
> +tests := \
> +  tst-minsigstksz-1 \
> +  tst-minsigstksz-2 \
> +  tst-minsigstksz-3 \
> +  tst-minsigstksz-3a \
> +  tst-minsigstksz-4 \
> +  tst-minsigstksz-5 \
> +  tst-raise \
> +  tst-sigaction \
> +  tst-sigisemptyset \
> +  tst-signal \
> +  tst-sigset \
> +  tst-sigset2 \
> +  tst-sigsimple \
> +  tst-sigwait-eintr \
> +# tests

OK.
  

Patch

diff --git a/signal/Makefile b/signal/Makefile
index e8e3dce0cf..7cddbc3c65 100644
--- a/signal/Makefile
+++ b/signal/Makefile
@@ -46,11 +46,22 @@  routines	:= signal raise killpg \
 		   allocrtsig sigtimedwait sigwaitinfo sigqueue \
 		   sighold sigrelse sigignore sigset
 
-tests		:= tst-signal tst-sigset tst-sigsimple tst-raise tst-sigset2 \
-		   tst-sigwait-eintr tst-sigaction \
-		   tst-minsigstksz-1 tst-minsigstksz-2 tst-minsigstksz-3 \
-		   tst-minsigstksz-3a tst-minsigstksz-4 tst-minsigstksz-5 \
-		   tst-sigisemptyset
+tests := \
+  tst-minsigstksz-1 \
+  tst-minsigstksz-2 \
+  tst-minsigstksz-3 \
+  tst-minsigstksz-3a \
+  tst-minsigstksz-4 \
+  tst-minsigstksz-5 \
+  tst-raise \
+  tst-sigaction \
+  tst-sigisemptyset \
+  tst-signal \
+  tst-sigset \
+  tst-sigset2 \
+  tst-sigsimple \
+  tst-sigwait-eintr \
+# tests
 
 include ../Rules