From patchwork Fri Mar 18 13:22:09 2016 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: "Pawar, Amit" X-Patchwork-Id: 11376 Received: (qmail 7148 invoked by alias); 18 Mar 2016 13:22:14 -0000 Mailing-List: contact libc-alpha-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Unsubscribe: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: libc-alpha-owner@sourceware.org Delivered-To: mailing list libc-alpha@sourceware.org Received: (qmail 7138 invoked by uid 89); 18 Mar 2016 13:22:13 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-1.7 required=5.0 tests=AWL, BAYES_00, MIME_BASE64_BLANKS, RCVD_IN_DNSWL_NONE, SPF_HELO_PASS autolearn=ham version=3.3.2 spammy=Hx-languages-length:919, 548, 398 X-HELO: na01-bn1-obe.outbound.protection.outlook.com From: "Pawar, Amit" To: "H.J. Lu" CC: "libc-alpha@sourceware.org" Subject: RE: [PATCH x86_64] Update memcpy, mempcpy and memmove selection order for Excavator CPU BZ #19583 Date: Fri, 18 Mar 2016 13:22:09 +0000 Message-ID: References: In-Reply-To: authentication-results: gmail.com; dkim=none (message not signed) header.d=none; gmail.com; dmarc=none action=none header.from=amd.com; x-ms-office365-filtering-correlation-id: 218c5092-78de-4b28-7f87-08d34f304f36 x-microsoft-exchange-diagnostics: 1; SN1PR12MB0733; 5:/4+pAuQ2RL/ij3GIlR9dqhooYI5bCrQ3qIr+fX0NDRZEyPOijH+QMd84agfDeazBtfO7R6WPgG57EGPbpDY7HAnYjDtJQjw2/e3g5yj/I3YITXBmU/RxebOCIIRoK5Mob4VyjlR96FaCKBG/koKtqg==; 24:d6XZoDmNQMAnz7MOJRVvrkRWcviKUPwnmppe/Q2Pqp50SuSANikgyKlzU9+Uk4UUar6Aytm4yidh/ALX8/mCc7YPV/Bj04S8gceL3VfMDwk=; 20:BVpKpZ8yJ600tYg9olg3fXfNamGqV1R44XZqMkk5y7XtoG/oj2ke7ocvtlgNCVDLb48AYgVCuO43pRUdf+mmgCTBjhjKC2C/Pl44fF8eVyPsz8pFOVmSRc2kChXLkHUqrI1Q4t5YYMvGcOg/9OGm/79k+z+JHT7fwYqRfBJREDu72p13ZLV0EnDmjDgKC5EDaBBwyJyDM+lapPAla0rJx7508xquVjlDPVjIThwijjzLx8glkFuvRgw6H2Z7q6kO x-microsoft-antispam: UriScan:;BCL:0;PCL:0;RULEID:;SRVR:SN1PR12MB0733; x-microsoft-antispam-prvs: x-exchange-antispam-report-test: UriScan:; x-exchange-antispam-report-cfa-test: BCL:0; PCL:0; RULEID:(601004)(2401047)(5005006)(8121501046)(3002001)(10201501046); SRVR:SN1PR12MB0733; BCL:0; PCL:0; RULEID:; SRVR:SN1PR12MB0733; x-forefront-prvs: 088552DE73 x-forefront-antispam-report: SFV:NSPM; SFS:(10009020)(6009001)(3280700002)(76576001)(3660700001)(11100500001)(1220700001)(1096002)(66066001)(586003)(102836003)(2900100001)(4326007)(2906002)(2950100001)(10400500002)(76176999)(110136002)(189998001)(5002640100001)(77096005)(50986999)(54356999)(6116002)(5008740100001)(5003600100002)(86362001)(74316001)(122556002)(93886004)(92566002)(3846002)(15650500001)(87936001)(33656002)(5004730100002)(81166005); DIR:OUT; SFP:1101; SCL:1; SRVR:SN1PR12MB0733; H:SN1PR12MB0733.namprd12.prod.outlook.com; FPR:; SPF:None; MLV:sfv; LANG:en; spamdiagnosticoutput: 1:23 spamdiagnosticmetadata: NSPM MIME-Version: 1.0 X-OriginatorOrg: amd.com X-MS-Exchange-CrossTenant-originalarrivaltime: 18 Mar 2016 13:22:09.3805 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 3dd8961f-e488-4e60-8e11-a82d994e183d X-MS-Exchange-Transport-CrossTenantHeadersStamped: SN1PR12MB0733 >No, it isn't fixed. Avoid_AVX_Fast_Unaligned_Load should disable __memcpy_avx_unaligned and nothing more. Also you need to fix ALL selections. Will update all IFUNC's if this ok else please suggest. --Amit Pawar diff --git a/sysdeps/x86_64/multiarch/memcpy.S b/sysdeps/x86_64/multiarch/memcpy.S index 8882590..a5afaf4 100644 --- a/sysdeps/x86_64/multiarch/memcpy.S +++ b/sysdeps/x86_64/multiarch/memcpy.S @@ -39,6 +39,8 @@ ENTRY(__new_memcpy) ret #endif 1: lea __memcpy_avx_unaligned(%rip), %RAX_LP + HAS_ARCH_FEATURE (Avoid_AVX_Fast_Unaligned_Load) + jnz 3f HAS_ARCH_FEATURE (AVX_Fast_Unaligned_Load) jnz 2f lea __memcpy_sse2_unaligned(%rip), %RAX_LP @@ -52,6 +54,8 @@ ENTRY(__new_memcpy) jnz 2f lea __memcpy_ssse3(%rip), %RAX_LP 2: ret +3: lea __memcpy_ssse3(%rip), %RAX_LP + ret END(__new_memcpy) # undef ENTRY