diff mbox

Fix fallback fesetenv and feupdateenv on FE_NOMASK_ENV

Message ID Pine.LNX.4.64.1406251728310.12113@digraph.polyomino.org.uk
State Committed
Headers

Commit Message

Joseph Myers June 25, 2014, 5:29 p.m. UTC 
  This patch fixes bug 17088, fallback fesetenv and feupdateenv not
giving an error for an FE_NOMASK_ENV argument when it requires traps
to be enabled.  (This is the bug tested for by test-fenv-return.c.)

Tested mips64 soft-float.

2014-06-25  Joseph Myers  <joseph@codesourcery.com>

	[BZ #17088]
	* math/fesetenv.c (__fesetenv)
	[FE_NOMASK_ENV && FE_ALL_EXCEPT != 0]: Return 1 for FE_NOMASK_ENV.
	* math/feupdateenv.c (__feupdateenv)
	[FE_NOMASK_ENV && FE_ALL_EXCEPT != 0]: Likewise.

Comments

Joseph Myers June 30, 2014, 3:23 p.m. UTC | #1 
Ping (last ping for this patch for 2.20).  This patch 
<https://sourceware.org/ml/libc-alpha/2014-06/msg00777.html> is pending 
review.
Joseph Myers July 17, 2014, 2:40 p.m. UTC | #2 
Ping^2.  This patch 
<https://sourceware.org/ml/libc-alpha/2014-06/msg00777.html> is still 
pending review.
Andreas Jaeger July 17, 2014, 5:31 p.m. UTC | #3 
On 06/25/2014 07:29 PM, Joseph S. Myers wrote:
> This patch fixes bug 17088, fallback fesetenv and feupdateenv not
> giving an error for an FE_NOMASK_ENV argument when it requires traps
> to be enabled.  (This is the bug tested for by test-fenv-return.c.)

Ok, thanks,
Andreas
diff mbox

Patch

diff --git a/math/fesetenv.c b/math/fesetenv.c
index acfe5f4..9bf42c0 100644
--- a/math/fesetenv.c
+++ b/math/fesetenv.c
@@ -23,6 +23,10 @@ 
 int
 __fesetenv (const fenv_t *envp)
 {
+#if defined FE_NOMASK_ENV && FE_ALL_EXCEPT != 0
+  if (envp == FE_NOMASK_ENV)
+    return 1;
+#endif
   /* Nothing to do.  */
   return 0;
 }
diff --git a/math/feupdateenv.c b/math/feupdateenv.c
index 13d819e..08d8ae2 100644
--- a/math/feupdateenv.c
+++ b/math/feupdateenv.c
@@ -23,6 +23,10 @@ 
 int
 __feupdateenv (const fenv_t *envp)
 {
+#if defined FE_NOMASK_ENV && FE_ALL_EXCEPT != 0
+  if (envp == FE_NOMASK_ENV)
+    return 1;
+#endif
   /* Nothing to do.  */
   return 0;
 }