From patchwork Tue Mar 18 00:07:19 2014 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Joseph Myers X-Patchwork-Id: 135 Return-Path: X-Original-To: siddhesh@wilcox.dreamhost.com Delivered-To: siddhesh@wilcox.dreamhost.com Received: from homiemail-mx20.g.dreamhost.com (caibbdcaaahc.dreamhost.com [208.113.200.72]) by wilcox.dreamhost.com (Postfix) with ESMTP id 8B5CE360084 for ; Mon, 17 Mar 2014 17:07:34 -0700 (PDT) Received: by homiemail-mx20.g.dreamhost.com (Postfix, from userid 14307373) id 394F940DC80CD; Mon, 17 Mar 2014 17:07:34 -0700 (PDT) X-Original-To: glibc@patchwork.siddhesh.in Delivered-To: x14307373@homiemail-mx20.g.dreamhost.com Received: from sourceware.org (server1.sourceware.org [209.132.180.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by homiemail-mx20.g.dreamhost.com (Postfix) with ESMTPS id 12A7E4067253C for ; Mon, 17 Mar 2014 17:07:34 -0700 (PDT) DomainKey-Signature: a=rsa-sha1; c=nofws; d=sourceware.org; h=list-id :list-unsubscribe:list-subscribe:list-archive:list-post :list-help:sender:date:from:to:cc:subject:in-reply-to:message-id :references:mime-version:content-type; q=dns; s=default; b=Z3fwQ WN5GUzlNfE8IudnPbNoXqTjqwO/oR1d5cxbRVJnIj01jBItm05WvRKEQZxmIbmVD 1CombnM7VgFH9MIXbK7om8PYPEcrJp5XelDqZG780ZTxJ7XHmXQS6M80bPBWAQ3F caRQDr+CDfw8hogw50OxiLMpBxOHym568ChaKo= DKIM-Signature: v=1; a=rsa-sha1; c=relaxed; d=sourceware.org; h=list-id :list-unsubscribe:list-subscribe:list-archive:list-post :list-help:sender:date:from:to:cc:subject:in-reply-to:message-id :references:mime-version:content-type; s=default; bh=Qkjqd+El0IC J6foKbJUP0S3rfJw=; b=gXEzMf/NveYQWN7Ljcxfp6Nz7XBcXE7TDUlnMyai0NE xGuwHtySTR0DDGY7LHGoj8EWVSToCn67WyQ6YdAGTkrTlTWBnH3MXGSw/6so/7Zl Pj3LZBf+VmWxT7pDkLPB8JSUDi387feGgxKTub58PzabA47TguFnSO35dU7iR+JA = Received: (qmail 24038 invoked by alias); 18 Mar 2014 00:07:31 -0000 Mailing-List: contact libc-alpha-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Unsubscribe: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: libc-alpha-owner@sourceware.org Delivered-To: mailing list libc-alpha@sourceware.org Received: (qmail 23960 invoked by uid 89); 18 Mar 2014 00:07:31 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-1.0 required=5.0 tests=AWL, BAYES_40 autolearn=ham version=3.3.2 X-HELO: relay1.mentorg.com Date: Tue, 18 Mar 2014 00:07:19 +0000 From: "Joseph S. Myers" To: Roland McGrath CC: "GNU C. Library" Subject: Re: PLEASE FIX NOW! make check-abi exits zero on failure In-Reply-To: <20140317225024.5DDBC74464@topped-with-meat.com> Message-ID: References: <20140317225024.5DDBC74464@topped-with-meat.com> MIME-Version: 1.0 X-DH-Original-To: glibc@patchwork.siddhesh.in Since you want a quick fix, I've applied this patch. (Really the subdirectory check-abi targets should generate .sum files and then toplevel combine those, just like the tests and xtests targets.) diff --git a/ChangeLog b/ChangeLog index c7e121d..b007a2e 100644 --- a/ChangeLog +++ b/ChangeLog @@ -1,3 +1,8 @@ +2014-03-18 Joseph Myers + + * Makerules [!subdir] (check-abi): Exit with error status if a + test failed. + 2014-03-17 Joseph Myers * math/libm-test.inc (nearbyint_test_data): Include all tests used diff --git a/Makerules b/Makerules index 008e80a..4427f4e 100644 --- a/Makerules +++ b/Makerules @@ -1257,6 +1257,7 @@ subdir_check-abi: check-abi subdir_update-abi: update-abi else check-abi: subdir_check-abi + if grep -q '^FAIL:' $(objpfx)*/check-abi*.test-result; then exit 1; fi update-abi: subdir_update-abi endif