From patchwork Wed Mar 8 11:02:17 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Wilco Dijkstra X-Patchwork-Id: 66124 Return-Path: X-Original-To: patchwork@sourceware.org Delivered-To: patchwork@sourceware.org Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id B15793857400 for ; Wed, 8 Mar 2023 11:02:56 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org B15793857400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=sourceware.org; s=default; t=1678273376; bh=st6Sn+Uw1wo3Oq2zs2fzzoaheGs04DDBqQCVNqfWhnI=; h=To:Subject:Date:List-Id:List-Unsubscribe:List-Archive:List-Post: List-Help:List-Subscribe:From:Reply-To:From; b=GGTTwhjJlwwJCIH23luAiRh/PdpjAq9BP04C94BQkTMHdwd7VLrlE7yFvAYL6Dlay OfpM0l8SnV3R2R1n316+7IJSB2W5svDnzbFvjEwTRt/NMrDkxMJK/GR9Zonu9mZ64E +U20q8t7fbzM3gNDw8S1Ttg64NMjfINTq9n/meJI= X-Original-To: libc-alpha@sourceware.org Delivered-To: libc-alpha@sourceware.org Received: from EUR05-DB8-obe.outbound.protection.outlook.com (mail-db8eur05on20615.outbound.protection.outlook.com [IPv6:2a01:111:f400:7e1a::615]) by sourceware.org (Postfix) with ESMTPS id A00803858C54 for ; Wed, 8 Mar 2023 11:02:34 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org A00803858C54 Received: from DUZPR01CA0014.eurprd01.prod.exchangelabs.com (2603:10a6:10:3c3::7) by PAWPR08MB9736.eurprd08.prod.outlook.com (2603:10a6:102:2ea::12) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6156.29; Wed, 8 Mar 2023 11:02:32 +0000 Received: from DBAEUR03FT051.eop-EUR03.prod.protection.outlook.com (2603:10a6:10:3c3:cafe::1c) by DUZPR01CA0014.outlook.office365.com (2603:10a6:10:3c3::7) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6178.17 via Frontend Transport; Wed, 8 Mar 2023 11:02:32 +0000 X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 63.35.35.123) smtp.mailfrom=arm.com; dkim=pass (signature was verified) header.d=armh.onmicrosoft.com;dmarc=pass action=none header.from=arm.com; Received-SPF: Pass (protection.outlook.com: domain of arm.com designates 63.35.35.123 as permitted sender) receiver=protection.outlook.com; client-ip=63.35.35.123; helo=64aa7808-outbound-1.mta.getcheckrecipient.com; pr=C Received: from 64aa7808-outbound-1.mta.getcheckrecipient.com (63.35.35.123) by DBAEUR03FT051.mail.protection.outlook.com (100.127.142.148) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6178.18 via Frontend Transport; Wed, 8 Mar 2023 11:02:32 +0000 Received: ("Tessian outbound 2ba0ed2ebb9f:v135"); Wed, 08 Mar 2023 11:02:32 +0000 X-CheckRecipientChecked: true X-CR-MTA-CID: de2550c187a7a702 X-CR-MTA-TID: 64aa7808 Received: from 1050f4e81f25.1 by 64aa7808-outbound-1.mta.getcheckrecipient.com id FDD56645-11D0-49B4-90C7-58192FCE7142.1; Wed, 08 Mar 2023 11:02:25 +0000 Received: from EUR02-VI1-obe.outbound.protection.outlook.com by 64aa7808-outbound-1.mta.getcheckrecipient.com with ESMTPS id 1050f4e81f25.1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384); Wed, 08 Mar 2023 11:02:25 +0000 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=DeZBzWYlTabs9rwA0ykFxx0Tc+UdbWEyBLzSpE7qTFeQPEgbIV/keWRiJ7oDfMvj4zeD8yza5PTkhsC4R3xNfzSjy/0pJ8JnSAUB9VBsNBodgULpZLceD2MR12l02s/wcUyfsX4Ns8pDPjH6qqQyHIxRknxk3Is5aPNuB86PCuXSbBBGYjERI32yHV3L2BWgAcPKlH34wr6fhspFY0krq6ILBtfgGzCByIdMdtiDQ9s0WFpO2KGEwTTXQ/V4mp/4Snu2GppdQecmU5cL9ubLBsP4zXUlJLZZEy3LpYiVpsYktl35Nm+Rp0XCyOSKNyxsOVd0JrFb1QbLp5vP7gnnpw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=st6Sn+Uw1wo3Oq2zs2fzzoaheGs04DDBqQCVNqfWhnI=; b=C7KIOIEouX7U3QoPQicUTMWeoK6xFcGXo/OcvrKfpLmk0BDHxMJbexk5E3znG9lityLgOKOM3RDkegdZBMphMuHQr5CqLX25jIsbHyOLrQu6dWw/6b42i1G9Wv1wJmYD/JKAKsmXayzZLShE9n9VMN9zGFlnt8TwbMQ35xEFtP3Cuh/5yiuekO+DqitN13Bf26gW41t7SIlT8BNbYylGvziYEEYIbQeiUp7tWVGq4fy8nXWK5cPAk5pD/ELlLGD4LTwi9Te3M+DYSx3yY47tYApNWmF6BZrUUTt2voMsBTbUrrhoRdUjxypBx/oIZpwlDHLfJRQlDUiKRuSLJiu3tA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=arm.com; dmarc=pass action=none header.from=arm.com; dkim=pass header.d=arm.com; arc=none Received: from PAWPR08MB8982.eurprd08.prod.outlook.com (2603:10a6:102:33f::20) by AS8PR08MB10098.eurprd08.prod.outlook.com (2603:10a6:20b:62a::21) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6156.23; Wed, 8 Mar 2023 11:02:18 +0000 Received: from PAWPR08MB8982.eurprd08.prod.outlook.com ([fe80::dc17:8fa2:cce5:3573]) by PAWPR08MB8982.eurprd08.prod.outlook.com ([fe80::dc17:8fa2:cce5:3573%7]) with mapi id 15.20.6156.025; Wed, 8 Mar 2023 11:02:18 +0000 To: 'GNU C Library' Subject: [PATCH] Benchtests: Remove simple_memcmp Thread-Topic: [PATCH] Benchtests: Remove simple_memcmp Thread-Index: AQHZUazlo4q4BVswdk2n2EK/86oWcg== Date: Wed, 8 Mar 2023 11:02:17 +0000 Message-ID: Accept-Language: en-GB, en-US Content-Language: en-GB X-MS-Has-Attach: X-MS-TNEF-Correlator: msip_labels: Authentication-Results-Original: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com; x-ms-traffictypediagnostic: PAWPR08MB8982:EE_|AS8PR08MB10098:EE_|DBAEUR03FT051:EE_|PAWPR08MB9736:EE_ X-MS-Office365-Filtering-Correlation-Id: 60ba5318-f277-4085-76dd-08db1fc49dab x-checkrecipientrouted: true nodisclaimer: true X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam-Untrusted: BCL:0; X-Microsoft-Antispam-Message-Info-Original: Vy0jXAWKvPmbeF8hJ8hTAXJWtCdBocWLTkCgNYoFubuL55JlDPxj8iAKjUUsdaP9dcyzZwUr5dvld4PU6HKbXngbBInBSLbc7p1rfH+HE1UcfwWdUHDk/NTHsS9OpRB0yPH7kC9LFbgCLxXAL4LmyZEyLjdlSnpBVajxN4myqcRDHTZmIj6Nusy0v4AqUtElFbg1bK46YsAg5kK3lQUoE+CxhtxnrSdnjSZdJ5izdZnSR7/eC0qGF1N2rtBDbaSOFUDC+aaRv0iMeXLsDTMA0Mk+kMt6e1XaDuu2j5hG5IFifjR9YGTNnZ1ivofbV2eorg2VwWnp7qpOFyakbWQdfcccgeVwpEcNc6RGt8nk1+3wvfORxFn7MlW3ba3+KTaO9yK20SJLNOzCNVqaj34SL8VKZjZZcGJrB+mY0q2VdwBRif8qH3D9BNR7U6eIZPYDRmzSOcV4z6C5VH6x52myMzW5pQlMpkOfLdjP4bk3vVkwCy0y6fCAp8KcufEpDAc9DinMH28bCI/NwgTvWHfDF29bYc0+zs0EpcMVbXqV6zBaU80Aa36oySnR9QjJPQnM6FqOQbaOMe6ZfxyjKipWtPmitw8rgrZUQb//c2cFckDw+pAcIl7lD6ti3rCT5oI3vzuBuP6Pm/Dr1SI2mHQbo8RJHBqpai6LAgtF2NtAhQeD0LADZoJ1TxIvNA6Xu7fvhCV+9ng9EJbxbS7tkfa3HQ== X-Forefront-Antispam-Report-Untrusted: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:PAWPR08MB8982.eurprd08.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230025)(4636009)(376002)(396003)(346002)(136003)(39860400002)(366004)(451199018)(33656002)(38100700002)(316002)(7696005)(478600001)(52536014)(8936002)(71200400001)(66476007)(66946007)(8676002)(91956017)(6916009)(66446008)(76116006)(64756008)(66556008)(41300700001)(2906002)(83380400001)(186003)(86362001)(122000001)(38070700005)(55016003)(9686003)(5660300002)(6506007)(26005); DIR:OUT; SFP:1101; MIME-Version: 1.0 X-MS-Exchange-Transport-CrossTenantHeadersStamped: AS8PR08MB10098 Original-Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com; X-EOPAttributedMessage: 0 X-MS-Exchange-Transport-CrossTenantHeadersStripped: DBAEUR03FT051.eop-EUR03.prod.protection.outlook.com X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id-Prvs: ce4a15be-01ec-45e0-1b9c-08db1fc4952e X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: 9wzzyV7LyR/kHghk/4kJZ7RlJxgdJxBkHTNJQi6yLy8t5s0AW/nWrgJKrY3lviaWIcPxXPCeHpP5cOfwozPG+vT1Whm0smIaNTKiz5cvg8+wg3T9CPNHIThrjuMC0Of2vt8L79gdv1O+BeN2JzPuvuhh1IdyL4JyOdzn71Y5h9Y7msijcQ/nX5KhW42xku8D8o1JA6xXm/nXq6wlXdBn7etnrCoHKLkGF8UCuFLImqR9N/rc3yzTxHvS+Hx1TRzgdNAhzunjCGXPBCkDL7OTSPT0jIpWY10xq05/FbpwF5vdYtKFU3a/NBhfqvrrd6eCCAA9Mn7x+GqruT9Q6VD/FGAUAPTDfgRwflng1OZo8Xw6p4TkVi0kbf2FZjfE5G+wmCHlWSYraSrgdS4O+InHMAk7K32tatcYWwzMU3UlR8o04g41d1W1BzLqy/TPkEEPC8NKXuAgzhrbJD4IJP1kYSOW/pNes67quUeVIRQmXK6Ck+pDHhoCLyJG0ys42d8eNRI15llK9BTB8eIvqPfbevRJGu2CjaKIx9tu3hcg+kHOsEycdE18Zr75eWvd0RRkQu50D7W9Wo7BpEAm+I1xI+lSTAouCfQfsHd3M2Zmw6QMFvLqpOPLleUXGRCk7is1HeyGkLCfbZk9USlqqSBvcF3yVx1WeEybbNEejHnkxlwSNwg5hxxCgMp/alK2hx1l1fmR8kMkhUgSuB37I/UiXQ== X-Forefront-Antispam-Report: CIP:63.35.35.123; CTRY:IE; LANG:en; SCL:1; SRV:; IPV:CAL; SFV:NSPM; H:64aa7808-outbound-1.mta.getcheckrecipient.com; PTR:ec2-63-35-35-123.eu-west-1.compute.amazonaws.com; CAT:NONE; SFS:(13230025)(4636009)(346002)(396003)(376002)(136003)(39860400002)(451199018)(36840700001)(46966006)(40470700004)(41300700001)(47076005)(6916009)(336012)(6506007)(83380400001)(81166007)(9686003)(36860700001)(186003)(356005)(26005)(82740400003)(82310400005)(40460700003)(478600001)(316002)(70206006)(70586007)(8676002)(86362001)(40480700001)(7696005)(33656002)(2906002)(55016003)(5660300002)(52536014)(8936002); DIR:OUT; SFP:1101; X-OriginatorOrg: arm.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 08 Mar 2023 11:02:32.2368 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 60ba5318-f277-4085-76dd-08db1fc49dab X-MS-Exchange-CrossTenant-Id: f34e5979-57d9-4aaa-ad4d-b122a662184d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=f34e5979-57d9-4aaa-ad4d-b122a662184d; Ip=[63.35.35.123]; Helo=[64aa7808-outbound-1.mta.getcheckrecipient.com] X-MS-Exchange-CrossTenant-AuthSource: DBAEUR03FT051.eop-EUR03.prod.protection.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: PAWPR08MB9736 X-Spam-Status: No, score=-11.5 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, FORGED_SPF_HELO, GIT_PATCH_0, KAM_DMARC_NONE, RCVD_IN_DNSWL_NONE, SPF_HELO_PASS, SPF_NONE, TXREP, UNPARSEABLE_RELAY autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org X-BeenThere: libc-alpha@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Libc-alpha mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-Patchwork-Original-From: Wilco Dijkstra via Libc-alpha From: Wilco Dijkstra Reply-To: Wilco Dijkstra Errors-To: libc-alpha-bounces+patchwork=sourceware.org@sourceware.org Sender: "Libc-alpha" Remove the slow byte oriented simple_memcmp. Reviewed-by: Adhemerval Zanella diff --git a/benchtests/bench-memcmp.c b/benchtests/bench-memcmp.c index a9379530656f474433ed6d852f75f71b1a1eb385..4d2b8cbb30b1d847ecde540be9f0049dd5249acf 100644 --- a/benchtests/bench-memcmp.c +++ b/benchtests/bench-memcmp.c @@ -19,46 +19,16 @@ #define TEST_MAIN #ifdef TEST_MEMCMPEQ # define TEST_NAME "__memcmpeq" -# define SIMPLE_MEMCMP simple_memcmpeq #elif defined WIDE # define TEST_NAME "wmemcmp" -# define SIMPLE_MEMCMP simple_wmemcmp #else # define TEST_NAME "memcmp" -# define SIMPLE_MEMCMP simple_memcmp #endif #include "bench-string.h" -#ifdef WIDE - -int -SIMPLE_MEMCMP (const wchar_t *s1, const wchar_t *s2, size_t n) -{ - int ret = 0; - /* Warning! - wmemcmp has to use SIGNED comparison for elements. - memcmp has to use UNSIGNED comparison for elemnts. - */ - while (n-- && (ret = *s1 < *s2 ? -1 : *s1 == *s2 ? 0 : 1) == 0) {s1++; s2++;} - return ret; -} -#else -# include - -int -SIMPLE_MEMCMP (const char *s1, const char *s2, size_t n) -{ - int ret = 0; - - while (n-- && (ret = *(unsigned char *) s1++ - *(unsigned char *) s2++) == 0); - return ret; -} -#endif - -# include "json-lib.h" +#include "json-lib.h" typedef int (*proto_t) (const CHAR *, const CHAR *, size_t); -IMPL (SIMPLE_MEMCMP, 0) IMPL (MEMCMP, 1) static void