From patchwork Wed Mar 8 08:11:47 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Adam Yi X-Patchwork-Id: 66114 Return-Path: X-Original-To: patchwork@sourceware.org Delivered-To: patchwork@sourceware.org Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id 6F64B3857838 for ; Wed, 8 Mar 2023 08:21:09 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 6F64B3857838 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=sourceware.org; s=default; t=1678263669; bh=D9wVvy4gty10qMFSFmTAH7ObTTE82fudRvs69C0X53c=; h=Date:Subject:To:Cc:List-Id:List-Unsubscribe:List-Archive: List-Post:List-Help:List-Subscribe:From:Reply-To:From; b=gJDoRR1lBbDlGTbnQSyLq9pZ+7PndrT9+bThPP2qPz2l1VIPVsc0GbYQy4CAhEkzE RIZ7jYj7ZlDk5lSw7A3UhJ8UnKlY9LvCEg+p/bdkD9VqCFvBJGi84JvM2+dkWfWDb1 n7wPQNmYtuYgy1IEA+kWFxreapU9PLlKz9kC5G/g= X-Original-To: libc-alpha@sourceware.org Delivered-To: libc-alpha@sourceware.org Received: from mxout5.mail.janestreet.com (mxout5.mail.janestreet.com [64.215.233.18]) by sourceware.org (Postfix) with ESMTPS id 4F0C83858C30 for ; Wed, 8 Mar 2023 08:20:41 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 4F0C83858C30 Date: Wed, 8 Mar 2023 03:11:47 -0500 Subject: [PATCH] hurd: fix build of tst-system.c To: libc-alpha@sourceware.org Cc: adhemerval.zanella@linaro.org, joseph@codesourcery.com, i@adamyi.com, ayi@janestreet.com Message-Id: X-Spam-Status: No, score=-13.9 required=5.0 tests=BAYES_00, GIT_PATCH_0, KAM_DMARC_STATUS, SPF_HELO_PASS, SPF_PASS, TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org X-BeenThere: libc-alpha@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Libc-alpha mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-Patchwork-Original-From: Adam Yi via Libc-alpha From: Adam Yi Reply-To: Adam Yi Errors-To: libc-alpha-bounces+patchwork=sourceware.org@sourceware.org Sender: "Libc-alpha" We made tst-system.c depend on pthread, but that requires linking with $(shared-thread-library). It does not fail under Linux because the variable expands to nothing under Linux, but it fails for Hurd. I tested verified via cross-compiling that "make check" now works for Hurd. Signed-off-by: Adam Yi Reviewed-by: Adhemerval Zanella --- stdlib/Makefile | 1 + 1 file changed, 1 insertion(+) diff --git a/stdlib/Makefile b/stdlib/Makefile index cd32f53b56..5e38f0e6a2 100644 --- a/stdlib/Makefile +++ b/stdlib/Makefile @@ -281,6 +281,7 @@ LDLIBS-test-on_exit-race = $(shared-thread-library) LDLIBS-tst-canon-bz26341 = $(shared-thread-library) LDLIBS-tst-arc4random-fork = $(shared-thread-library) LDLIBS-tst-arc4random-thread = $(shared-thread-library) +LDLIBS-tst-system = $(shared-thread-library) LDLIBS-test-dlclose-exit-race = $(shared-thread-library) LDFLAGS-test-dlclose-exit-race = $(LDFLAGS-rdynamic)