From patchwork Wed Aug 15 13:11:35 2018
Content-Type: text/plain; charset="utf-8"
MIME-Version: 1.0
Content-Transfer-Encoding: 8bit
X-Patchwork-Submitter: Wilco Dijkstra <Wilco.Dijkstra@arm.com>
X-Patchwork-Id: 28924
Received: (qmail 117400 invoked by alias); 15 Aug 2018 13:11:44 -0000
Mailing-List: contact libc-alpha-help@sourceware.org; run by ezmlm
Precedence: bulk
List-Id: <libc-alpha.sourceware.org>
List-Unsubscribe: <mailto:libc-alpha-unsubscribe-##L=##H@sourceware.org>
List-Subscribe: <mailto:libc-alpha-subscribe@sourceware.org>
List-Archive: <http://sourceware.org/ml/libc-alpha/>
List-Post: <mailto:libc-alpha@sourceware.org>
List-Help: <mailto:libc-alpha-help@sourceware.org>,
	<http://sourceware.org/ml/#faqs>
Sender: libc-alpha-owner@sourceware.org
Delivered-To: mailing list libc-alpha@sourceware.org
Received: (qmail 117326 invoked by uid 89); 15 Aug 2018 13:11:40 -0000
Authentication-Results: sourceware.org; auth=none
X-Spam-SWARE-Status: No, score=-26.9 required=5.0 tests=BAYES_00, GIT_PATCH_0,
	GIT_PATCH_1, GIT_PATCH_2, GIT_PATCH_3, RCVD_IN_DNSWL_NONE,
	SPF_HELO_PASS,
	SPF_PASS autolearn=ham version=3.3.2 spammy=Hx-languages-length:1483
X-HELO: EUR04-HE1-obe.outbound.protection.outlook.com
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com;
	s=selector1-arm-com;
	h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
	bh=T7zpWh7rkZpH1TmANrUXeA6D28WAMD/ESRZoEm3q7Sg=;
	b=FwToi7FsKPW/U0Np3Ww4JqoEJmpHtmanstf2KZxc/s0nsYkGiMTPQmEx0HxOcwFO39m1rFxTpvuNGTl68zBc5S38DbuzF1l3J3FFJ32/0s3hiFlVXXzh6a+4bT+L8HW2eHgG0Hx0LdfQXx8KkA9V+T0utq5wajeCQkOg/pu/dU8=
From: Wilco Dijkstra <Wilco.Dijkstra@arm.com>
To: Joseph Myers <joseph@codesourcery.com>, Szabolcs Nagy
	<Szabolcs.Nagy@arm.com>
CC: GNU C Library <libc-alpha@sourceware.org>, nd <nd@arm.com>
Subject: Re: [PATCH 03/10] Improve performance of sinf and cosf
Date: Wed, 15 Aug 2018 13:11:35 +0000
Message-ID: 
 <DB5PR08MB10308D8D6ABDADB8BF9B587C833F0@DB5PR08MB1030.eurprd08.prod.outlook.com>
References: <d4963b4e-0013-adaf-df2f-698cf421a487@arm.com>
	<480576b5-fbb7-39b2-d80c-80c8931fde21@arm.com>
	<alpine.DEB.2.20.1808131939210.12161@digraph.polyomino.org.uk>,
	<alpine.DEB.2.20.1808141936560.21830@digraph.polyomino.org.uk>
In-Reply-To: <alpine.DEB.2.20.1808141936560.21830@digraph.polyomino.org.uk>
authentication-results: spf=none (sender IP is )
	smtp.mailfrom=Wilco.Dijkstra@arm.com;
received-spf: None (protection.outlook.com: arm.com does not designate
	permitted sender hosts)
MIME-Version: 1.0

Joseph Myers wrote:

> The ulps updates here broke the testsuite build for x86_64 through adding
> invalid "ifloat:1" and "float:1" lines (missing space after colon) to 
> sysdeps/x86_64/fpu/libm-test-ulps.  I don't know quite how you generated 
> those changes to libm-test-ulps; "make regen-ulps" should never generate 
> such invalid lines, either before or after my move of it from perl to 
> python.

Sorry, it seems I copied and pasted some fields incorrectly. I've committed a
fix with the spaces, the libm-test-ulps is now identical to the latest regen output.

Wilco

    Fix spaces in x86_64 ULP file
    
    Fix a few missing spaces, it's now identical to the regenerated version.
    
    Passes GLIBC tests on x64.
    
ChangeLog:
2018-08-15  Wilco Dijkstra  <wdijkstr@arm.com>

        * sysdeps/x86_64/fpu/libm-test-ulps: Regenerate to fix spaces.

diff --git a/sysdeps/x86_64/fpu/libm-test-ulps b/sysdeps/x86_64/fpu/libm-test-ulps
index a51faecfc72342904d7c0ecb1ae90a03c14a7cad..e26f9c13586dc90bf7af42ca0994da3eb489ff45 100644
--- a/sysdeps/x86_64/fpu/libm-test-ulps
+++ b/sysdeps/x86_64/fpu/libm-test-ulps
@@ -2548,14 +2548,14 @@ double: 1
 float: 1
 float128: 3
 idouble: 1
-ifloat:1
+ifloat: 1
 ifloat128: 3
 ildouble: 3
 ldouble: 3
 
 Function: "sin_towardzero":
 double: 1
-float:1
+float: 1
 float128: 2
 idouble: 1
 ifloat: 1
@@ -2565,7 +2565,7 @@ ldouble: 2
 
 Function: "sin_upward":
 double: 1
-float:1
+float: 1
 float128: 3
 idouble: 1
 ifloat: 1