diff mbox series

elf: Add a comment after trailing backslashes

Message ID CAMe9rOr55n8bDCKhEu1Qjzzx_02pHjMPiz20Uh2P_gB8Ayk6GA@mail.gmail.com
State Committed
Headers show
Series elf: Add a comment after trailing backslashes | expand

Checks

Context Check Description
dj/TryBot-apply_patch success Patch applied to master at the time it was sent
dj/TryBot-32bit success Build for i686

Commit Message

H.J. Lu Jan. 4, 2022, 3 p.m. UTC
On Tue, Jan 4, 2022 at 6:36 AM Florian Weimer <fweimer@redhat.com> wrote:
>
> * Andreas Schwab:
>
> > On Jan 04 2022, H.J. Lu wrote:
> >
> >> On Tue, Jan 4, 2022 at 12:38 AM Andreas Schwab <schwab@linux-m68k.org> wrote:
> >>>
> >>> On Jan 03 2022, H.J. Lu via Libc-alpha wrote:
> >>>
> >>> > +tests-cxx = \
> >>> > +  tst-dlopen-nodelete-reloc \
> >>> > +  tst-nodelete \
> >>> > +  tst-unique3 \
> >>> > +  tst-unique4 \
> >>> > +
> >>>
> >>> > +  vismod1 \
> >>> > +  vismod2 \
> >>> > +  vismod3 \
> >>> > +
> >>>
> >>> > +  tst-unique3lib \
> >>> > +  tst-unique3lib2 \
> >>> > +  tst-unique4lib \
> >>> > +
> >>> > +modules-names += \
> >>> > +  $(if $(CXX),$(modules-names-cxx)) \
> >>> > +  $(modules-execstack-$(have-z-execstack)) \
> >>> > +  $(tst-tls-many-dynamic-modules) \
> >>> > +  $(tst-tls-many-dynamic-modules-dep) \
> >>> > +  $(tst-tls-many-dynamic-modules-dep-bad) \
> >>> > +  $(tlsmod17a-modules) \
> >>> > +  $(tlsmod18a-modules) \
> >>>
> >>>
> >>> Trailing backslashes are no good.
> >>
> >> It was added so that only one line is needed when appending
> >> to the list.
> >
> > The blank lines can easily get lost.
>
> That's why I use comments, so:
>
> +modules-names += \
> +  $(if $(CXX),$(modules-names-cxx)) \
> +  $(modules-execstack-$(have-z-execstack)) \
> +  $(tst-tls-many-dynamic-modules) \
> +  $(tst-tls-many-dynamic-modules-dep) \
> +  $(tst-tls-many-dynamic-modules-dep-bad) \
> +  $(tlsmod17a-modules) \
> +  $(tlsmod18a-modules) \
> +  # modules-names

Good suggestion.  I am checking in this.

Thanks.
diff mbox series

Patch

From f4f70c2895e3d325188a42c10eb7bb4335be6773 Mon Sep 17 00:00:00 2001
From: "H.J. Lu" <hjl.tools@gmail.com>
Date: Tue, 4 Jan 2022 06:58:34 -0800
Subject: [PATCH] elf: Add a comment after trailing backslashes

---
 elf/Makefile | 4 ++++
 1 file changed, 4 insertions(+)

diff --git a/elf/Makefile b/elf/Makefile
index 8eb7e6e5d9..b86d116be9 100644
--- a/elf/Makefile
+++ b/elf/Makefile
@@ -333,6 +333,7 @@  tests-cxx = \
   tst-nodelete \
   tst-unique3 \
   tst-unique4 \
+# tests-cxx
 
 tests += $(if $(CXX),$(tests-cxx))
 tests-internal += loadtest unload unload2 circleload1 \
@@ -626,6 +627,7 @@  modules-names = \
   vismod1 \
   vismod2 \
   vismod3 \
+# modules-names
 
 modules-names-cxx = \
   tst-dlopen-nodelete-reloc-mod1 \
@@ -651,6 +653,7 @@  modules-names-cxx = \
   tst-unique3lib \
   tst-unique3lib2 \
   tst-unique4lib \
+# modules-names-cxx
 
 modules-names += \
   $(if $(CXX),$(modules-names-cxx)) \
@@ -660,6 +663,7 @@  modules-names += \
   $(tst-tls-many-dynamic-modules-dep-bad) \
   $(tlsmod17a-modules) \
   $(tlsmod18a-modules) \
+# modules-names
 
 # Most modules build with _ISOMAC defined, but those filtered out
 # depend on internal headers.
-- 
2.33.1