From patchwork Fri Dec 4 13:03:02 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: "H.J. Lu" X-Patchwork-Id: 41303 Return-Path: X-Original-To: patchwork@sourceware.org Delivered-To: patchwork@sourceware.org Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id 816383850433; Fri, 4 Dec 2020 13:03:41 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 816383850433 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=sourceware.org; s=default; t=1607087021; bh=UpjPh1xWqH6umJjlkuNBkKtwPBgEGO3MNQN9jzQo4G8=; h=References:In-Reply-To:Date:Subject:To:List-Id:List-Unsubscribe: List-Archive:List-Post:List-Help:List-Subscribe:From:Reply-To:Cc: From; b=ZK5T5HsjoklqKAQL0HeIL88d0zEcdlatGr5U/cDwBQgwXFEq6YW5OQPOk9YJ/en+I ZSaht8Nn4EKw3Ry2XL7QgkHKQUxonPGxk7hZVxYvyVkoi0VU4zX0cl0lmgCAqVYHW4 Q7PCNc7jd4jbpwRGJYd30Ap0JdaDeShWhcjKrJVI= X-Original-To: libc-alpha@sourceware.org Delivered-To: libc-alpha@sourceware.org Received: from mail-ot1-x330.google.com (mail-ot1-x330.google.com [IPv6:2607:f8b0:4864:20::330]) by sourceware.org (Postfix) with ESMTPS id 68BB6385480F for ; Fri, 4 Dec 2020 13:03:39 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.3.2 sourceware.org 68BB6385480F Received: by mail-ot1-x330.google.com with SMTP id h18so1076684otq.12 for ; Fri, 04 Dec 2020 05:03:39 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=UpjPh1xWqH6umJjlkuNBkKtwPBgEGO3MNQN9jzQo4G8=; b=bXyY9izf2g1T7622fsK09ISKOO49rxUJOxW9XL5U3ROdXvXUy3bFrmRqDCj9qBNjyJ IGDxedwBxY7SUR9LMYQiY3pyV4pNgp0Gu+bDMLglw/NbT8rexzDayvuDgC6kyjKUWhvL VGCDHzic09j7YODNYTiBSu/YBV4nsPlqoEWRSJdqWPBqjq66Ipd1rPm/EUH3UKHAfqh5 xGqyxO08BO8SYyQ6r3JSWJaVyZNVBJ6+5zEOfyznQtV2beW6vrLjMCjv9a5NMC4S2XWV 9l8xnzW20eB0Y09C+Jff+NAXTs7UgrM7vEJ9LWpn3QhhDLai1U8MLqjYjdXH5StdsXNv JL3Q== X-Gm-Message-State: AOAM531mRT7r3bPaOJuQYir/tZr/2GzYhYVtVdlAVBh10G4psvcP3LPv 9AT9zLWTvi1kDFAxjmoN+y2owkxoDpx3Eipe2/4= X-Google-Smtp-Source: ABdhPJw3FcZKI/KrgjL59U+ZRKPDnLoHcYWre1j0yJRCKJlYMhmzL7fXYlD292McAW92MlqIlT3+1ttu6TYcUmMDmSU= X-Received: by 2002:a05:6830:1213:: with SMTP id r19mr3540005otp.269.1607087018665; Fri, 04 Dec 2020 05:03:38 -0800 (PST) MIME-Version: 1.0 References: <20201204002135.1609087-1-hjl.tools@gmail.com> <87blfarnw4.fsf@oldenburg2.str.redhat.com> In-Reply-To: <87blfarnw4.fsf@oldenburg2.str.redhat.com> Date: Fri, 4 Dec 2020 05:03:02 -0800 Message-ID: Subject: [PATCH] x86: Set RDRAND usable if CPU supports RDRAND To: Florian Weimer X-Spam-Status: No, score=-3037.5 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, FREEMAIL_FROM, GIT_PATCH_0, RCVD_IN_DNSWL_NONE, SPF_HELO_NONE, SPF_PASS, TXREP autolearn=ham autolearn_force=no version=3.4.2 X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on server2.sourceware.org X-BeenThere: libc-alpha@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Libc-alpha mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-Patchwork-Original-From: "H.J. Lu via Libc-alpha" From: "H.J. Lu" Reply-To: "H.J. Lu" Cc: "H.J. Lu via Libc-alpha" Errors-To: libc-alpha-bounces@sourceware.org Sender: "Libc-alpha" On Fri, Dec 4, 2020 at 12:12 AM Florian Weimer wrote: > > * H. J. Lu via Libc-alpha: > > > Set RDRAND usable if CPU supports RDRAND. Also check HAS_CPU_FEATURE > > instead of CPU_FEATURE_USABLE for FSGSBASE, LM and XSAVES since > > FSGSBASE/LM require kernel support and XSAVES is supervisor-mode only. > > I think the commit subject is misleading because the RDRAND part is a > glibc bug fix. Rest looks okay to me. > > Thanks, I am checking the RDRAND fix as a separate patch. I will submit a new patch with the tst-cpu-features-supports.c fix only. Thanks. From eacbdebffb55aa570c53d87898fa99a9aeb5f5a1 Mon Sep 17 00:00:00 2001 From: "H.J. Lu" Date: Thu, 3 Dec 2020 15:02:44 -0800 Subject: [PATCH] x86: Set RDRAND usable if CPU supports RDRAND Set RDRAND usable if CPU supports RDRAND. --- sysdeps/x86/cpu-features.c | 1 + 1 file changed, 1 insertion(+) diff --git a/sysdeps/x86/cpu-features.c b/sysdeps/x86/cpu-features.c index f26deba38d..fe080b63b2 100644 --- a/sysdeps/x86/cpu-features.c +++ b/sysdeps/x86/cpu-features.c @@ -85,6 +85,7 @@ update_usable (struct cpu_features *cpu_features) CPU_FEATURE_SET_USABLE (cpu_features, WAITPKG); CPU_FEATURE_SET_USABLE (cpu_features, GFNI); CPU_FEATURE_SET_USABLE (cpu_features, RDPID); + CPU_FEATURE_SET_USABLE (cpu_features, RDRAND); CPU_FEATURE_SET_USABLE (cpu_features, CLDEMOTE); CPU_FEATURE_SET_USABLE (cpu_features, MOVDIRI); CPU_FEATURE_SET_USABLE (cpu_features, MOVDIR64B); -- 2.28.0