From patchwork Fri Nov 30 02:48:16 2018 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: "H.J. Lu" X-Patchwork-Id: 30411 Received: (qmail 41319 invoked by alias); 30 Nov 2018 02:49:00 -0000 Mailing-List: contact libc-alpha-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Unsubscribe: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: libc-alpha-owner@sourceware.org Delivered-To: mailing list libc-alpha@sourceware.org Received: (qmail 41296 invoked by uid 89); 30 Nov 2018 02:48:59 -0000 Authentication-Results: sourceware.org; auth=none X-Spam-SWARE-Status: No, score=-26.9 required=5.0 tests=BAYES_00, FREEMAIL_FROM, GIT_PATCH_0, GIT_PATCH_1, GIT_PATCH_2, GIT_PATCH_3, RCVD_IN_DNSWL_NONE, SPF_PASS autolearn=ham version=3.3.2 spammy=Hx-languages-length:1423 X-HELO: mail-ot1-f65.google.com DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=+6zaftdwkinKjdSVpbNpjEly5QtjaL0NxQkVYwr34Eg=; b=jMglXfgRtbQXURUQdVhjZpEpihgv+wb4rf9MKWuUTkUcwt6Wlztmx2/hY6SMJAZpe5 gBTcn4sBb9fm/Ok9oHLddn268Z9/fgsRElaaMh5sSSZubCROs8DatyJAOJMw1yq5C23i ac68WeOXF34Ghda9amBuo4etfFx/nrnFgu95TLGK8E1vyQ8Iau2pNBJiCpTmbWRv/TE8 fO3b96q9YOQdRH4ukUFL49igbC6YvHtutRC4u6EQzG/SpD+gJTLcsi+06DN7d4tLQkoS sf5M4nNgWfNLz6VtA6SmORGCkH2RPkYGSrtd744DJF3SayLk8/suBXecTgbKvUPYFEq9 +eFw== MIME-Version: 1.0 References: <20181122173812.9025-1-hjl.tools@gmail.com> <7794985c-9c57-58ce-91af-e737b8bc82e2@arm.com> <15c39c60-150e-fe2a-a511-fb735b152d9b@linaro.org> In-Reply-To: From: "H.J. Lu" Date: Thu, 29 Nov 2018 18:48:16 -0800 Message-ID: Subject: Re: [PATCH] _dl_exception_create_format: Support %x/%lx/%Zx To: "Joseph S. Myers" , Jeffrey Law Cc: Adhemerval Zanella , GNU C Library On Thu, Nov 29, 2018 at 4:02 PM Joseph Myers wrote: > > On Thu, 29 Nov 2018, H.J. Lu wrote: > > > This is what I actually checked in. > > Your commit message doesn't say anything about how the commit was tested > (please include that information in commit messages). It causes a lot of > build failures of the form: > > dl-exception.c: In function '_dl_exception_create_format': > dl-exception.c:189:14: error: implicit declaration of function '_itoa' > [-Werror=implicit-function-declaration] > char *cp = _itoa (num, wptr, 16, 0); > ^~~~~ > dl-exception.c:189:14: error: initialization of 'char *' from 'int' makes > pointer from integer without a cast [-Werror=int-conversion] > dl-exception.c:202:16: error: initialization of 'char *' from 'int' makes > pointer from integer without a cast [-Werror=int-conversion] > char *cp = _itoa (num, wptr, 16, 0); > ^~~~~ > > (on aarch64, arm, hppa, i486, m68k, mips, ...) > I am testing this patch now. diff --git a/elf/dl-exception.c b/elf/dl-exception.c index 1e41d89a7d..3e8e0ba3f1 100644 --- a/elf/dl-exception.c +++ b/elf/dl-exception.c @@ -23,6 +23,7 @@ #include #include #include +#include <_itoa.h> /* This message we return as a last resort. We define the string in a variable since we have to avoid freeing it and so have to enable