diff mbox series

tunables.texi: Change \code{1} to @code{1}

Message ID CAMe9rOppRPxJ3U1zJ4BqZXUFe-P2OFVjt8=nNYS3rCW7sZG8yg@mail.gmail.com
State Committed
Headers
Series tunables.texi: Change \code{1} to @code{1} |

Checks

Context Check Description
dj/TryBot-apply_patch success Patch applied to master at the time it was sent
dj/TryBot-32bit success Build for i686

Commit Message

H.J. Lu Feb. 23, 2023, 4:08 a.m. UTC 
  On Wed, Feb 22, 2023 at 7:44 PM DJ Delorie <dj@redhat.com> wrote:
>
> "H.J. Lu via Libc-alpha" <libc-alpha@sourceware.org> writes:
> > +When this tunable is set to \code{1}, shared libraries of non-setuid
>
> ./tunables.texi:592: misplaced {
> ./tunables.texi:592: misplaced }
>
> Should that be @code{1} ?
>

Sorry for that.  You are right.   Here is the patch.

Thanks.

Comments

DJ Delorie Feb. 23, 2023, 4:23 a.m. UTC | #1 
Yeah, that's what I changed to get my local builds working.

LGTM.
Reviewed-by: DJ Delorie <dj@redhat.com>

I'll note that the manual doesn't seem to be built by "make all" - it is
built for an install, so "make check" builds it for the testroot - ONCE.
It took me a while to figure out how to reliably test texinfo changes.

Should the manual build be moved earlier in the process?
Andreas Schwab Feb. 23, 2023, 9:01 a.m. UTC | #2 
On Feb 22 2023, DJ Delorie via Libc-alpha wrote:

> I'll note that the manual doesn't seem to be built by "make all" - it is
> built for an install, so "make check" builds it for the testroot - ONCE.
> It took me a while to figure out how to reliably test texinfo changes.

You can also use make info.
diff mbox series

Patch

From 5e8fac9b1f8e5e6657b2fb2ef99c1a1cbb97e561 Mon Sep 17 00:00:00 2001
From: "H.J. Lu" <hjl.tools@gmail.com>
Date: Wed, 22 Feb 2023 20:04:26 -0800
Subject: [PATCH] tunables.texi: Change \code{1} to @code{1}

Update

317f1c0a8a x86-64: Add glibc.cpu.prefer_map_32bit_exec [BZ #28656]
---
 manual/tunables.texi | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/manual/tunables.texi b/manual/tunables.texi
index c76c5c53cd..70dd2264c5 100644
--- a/manual/tunables.texi
+++ b/manual/tunables.texi
@@ -589,7 +589,7 @@  This tunable is specific to i386 and x86-64.
 @end deftp
 
 @deftp Tunable glibc.cpu.prefer_map_32bit_exec
-When this tunable is set to \code{1}, shared libraries of non-setuid
+When this tunable is set to @code{1}, shared libraries of non-setuid
 programs will be loaded below 2GB with MAP_32BIT.
 
 Note that the @env{LD_PREFER_MAP_32BIT_EXEC} environment is an alias of
-- 
2.39.2