From patchwork Sun Oct 21 01:11:39 2018 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: "H.J. Lu" X-Patchwork-Id: 29823 Received: (qmail 24600 invoked by alias); 21 Oct 2018 01:11:45 -0000 Mailing-List: contact libc-alpha-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Unsubscribe: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: libc-alpha-owner@sourceware.org Delivered-To: mailing list libc-alpha@sourceware.org Received: (qmail 24577 invoked by uid 89); 21 Oct 2018 01:11:43 -0000 Authentication-Results: sourceware.org; auth=none X-Spam-SWARE-Status: No, score=-25.3 required=5.0 tests=AWL, BAYES_00, FREEMAIL_FROM, GIT_PATCH_0, GIT_PATCH_1, GIT_PATCH_2, GIT_PATCH_3, RCVD_IN_DNSWL_NONE, SPF_PASS autolearn=ham version=3.3.2 spammy= X-HELO: mail-ot1-f68.google.com DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:from:date:message-id:subject:to:cc; bh=L/phBOZuB9wp1X1ACz9VM+vRHVsXMhf0BkTYBzfDqd4=; b=s4ORlnUR86nDTDsfnd5pxdc6m97pGEm3QfwuGqKR9uf/TJnFjNclshxA8uKN0OSmDg l8R37Zufl2DawR5Q27hHFrnXd2czXovKtO+sJjzX4qwci5h3B5wSk0a25oLKh1D7KdIP B+hEpMkYxcfdYORR+MtXTgiDhDWJb7AD84y/S19X8dGc1ywN94QRxHVwIzv3u1EfI+Kj d01AiSSgyhXowLuWyNBHl9eNh/+YqRHu1d1cqXdWwixlxV2+YG8Fg1TE3vwN5Yai3hh/ azsztDizIbbqCx3roj2bxEahjW5/gX1Fa4F2ZPH9rXSCzfyqdN3AYeH+jDSAiUtqCtQD pe8g== MIME-Version: 1.0 From: "H.J. Lu" Date: Sat, 20 Oct 2018 18:11:39 -0700 Message-ID: Subject: [PATCH] x86: Don't include To: Florian Weimer Cc: Adhemerval Zanella , GNU C Library On 10/20/18, H.J. Lu wrote: > On 10/20/18, Florian Weimer wrote: >> * Florian Weimer: >> >> >>> I'm trying to remove the #include from >>> , but I don't know how hard this will be. >> >> That doesn't help. It's pulled in via and as well. >> We would need a separate header file to avoid that >> because hp_timing_t is required in a few central places (thread >> descriptor and link map). >> > > Please try this. > It is not about GCC 6. GCC 8 has the same issue. Here is the updated patch. From 157f63aef12d8f6abe62996638903c483306fc6a Mon Sep 17 00:00:00 2001 From: "H.J. Lu" Date: Sat, 20 Oct 2018 15:22:01 -0700 Subject: [PATCH] x86: Don't include Use __builtin_ia32_rdtsc directly since including makes building glibc very slow. On Intel Core i5-6260U, this patch reduces x86-64 build time from 8 minutes 33 seconds to 3 minutes 48 seconds with "make -j4" and GCC 8.2.1. * sysdeps/x86/hp-timing.h: Don't include . (HP_TIMING_NOW): Replace _rdtsc with __builtin_ia32_rdtsc. --- sysdeps/x86/hp-timing.h | 9 +++++---- 1 file changed, 5 insertions(+), 4 deletions(-) diff --git a/sysdeps/x86/hp-timing.h b/sysdeps/x86/hp-timing.h index 1c20e9d828..77a1360748 100644 --- a/sysdeps/x86/hp-timing.h +++ b/sysdeps/x86/hp-timing.h @@ -22,8 +22,6 @@ #include #if MINIMUM_ISA == 686 || MINIMUM_ISA == 8664 -# include - /* We always assume having the timestamp register. */ # define HP_TIMING_AVAIL (1) # define HP_SMALL_TIMING_AVAIL (1) @@ -38,8 +36,11 @@ typedef unsigned long long int hp_timing_t; might not be 100% accurate since there might be some more instructions running in this moment. This could be changed by using a barrier like 'cpuid' right before the `rdtsc' instruciton. But we are not interested - in accurate clock cycles here so we don't do this. */ -# define HP_TIMING_NOW(Var) ((Var) = _rdtsc ()) + in accurate clock cycles here so we don't do this. + + NB: Use __builtin_ia32_rdtsc directly since including + makes building glibc very slow. */ +# define HP_TIMING_NOW(Var) ((Var) = __builtin_ia32_rdtsc ()) # include #else -- 2.17.2