From patchwork Fri Nov 30 22:33:57 2018 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: "H.J. Lu" X-Patchwork-Id: 30489 Received: (qmail 25041 invoked by alias); 30 Nov 2018 22:34:38 -0000 Mailing-List: contact libc-alpha-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Unsubscribe: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: libc-alpha-owner@sourceware.org Delivered-To: mailing list libc-alpha@sourceware.org Received: (qmail 25025 invoked by uid 89); 30 Nov 2018 22:34:38 -0000 Authentication-Results: sourceware.org; auth=none X-Spam-SWARE-Status: No, score=-26.9 required=5.0 tests=BAYES_00, FREEMAIL_FROM, GIT_PATCH_0, GIT_PATCH_1, GIT_PATCH_2, GIT_PATCH_3, KAM_SHORT, RCVD_IN_DNSWL_NONE, SPF_PASS autolearn=ham version=3.3.2 spammy= X-HELO: mail-ot1-f65.google.com DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=yHk5Mafla8zqQgX6rELwzVVj8+ZIMIq6YWcxWbiTL/U=; b=ff8PInD6TWwPCqb7OgMvc+EDDaT1fgnc2p839LAuaxgNKu+SzM7jN8TTZqLDwPDspF FElmOUL+2/XOzgBw9fVxvpIspYo6hLJv4zIAK29d/1P5t23MZ0BdwfGg1sran4I1KcOL ZQOHQ4gKzrS7ByCFMshqfHthBcxNaAgJHcVPokwjFusW4HKiqfAuDfwtVRKdoBTrpw+z HQPeXwmocDCmeexwEOiJHWS+10P4GZqgMeA40Nk+uXDimLrAoS2/4HmwfUCBk7f+Er3H 4/yqEoxbJLCpfLrI5xQAks6e33uaaPT0RZkAUtEpr6K8VdpSc1eTAhmhpNE19akLH0U+ tpXw== MIME-Version: 1.0 References: In-Reply-To: From: "H.J. Lu" Date: Fri, 30 Nov 2018 14:33:57 -0800 Message-ID: Subject: Re: [PATCH] Enable VDSO on i386 statically linked programs. To: Rafael Avila de Espindola Cc: GNU C Library , Florian Weimer , "szabolcs.nagy" On Fri, Nov 30, 2018 at 12:22 PM Rafael Avila de Espindola wrote: > > "H.J. Lu" writes: > > > On Mon, Nov 12, 2018 at 3:17 PM Rafael Avila de Espindola > > wrote: > >> > >> A rebased version is attached. The new changelog is > >> > >> > >> > >> 2018-11-12 Rafael Ávila de Espíndola > >> > >> [BZ #19767] > >> * sysdeps/unix/sysv/linux/i386/init-first.c: remove #ifdef SHARED. > >> * sysdeps/unix/sysv/linux/i386/sysdep.h: define ALWAYS_USE_VSYSCALL. > > > > LGTM. > > Could you please commit it? > This is what I pushed. From 15b8d67e29142251a30576b5ab469051a8833e97 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Rafael=20=C3=81vila=20de=20Esp=C3=ADndola?= Date: Fri, 30 Nov 2018 14:32:35 -0800 Subject: [PATCH] Enable VDSO on i386 statically linked programs [BZ #19767] * sysdeps/unix/sysv/linux/i386/init-first.c: Don't check SHARED. * sysdeps/unix/sysv/linux/i386/sysdep.h (ALWAYS_USE_VSYSCALL): New. --- ChangeLog | 7 +++++++ sysdeps/unix/sysv/linux/i386/init-first.c | 12 +++++------- sysdeps/unix/sysv/linux/i386/sysdep.h | 3 +++ 3 files changed, 15 insertions(+), 7 deletions(-) diff --git a/ChangeLog b/ChangeLog index bb53b641a8..87d3863e7c 100644 --- a/ChangeLog +++ b/ChangeLog @@ -1,3 +1,10 @@ +2018-11-30 Rafael Ávila de Espíndola + + [BZ #19767] + * sysdeps/unix/sysv/linux/i386/init-first.c: Don't check SHARED. + * sysdeps/unix/sysv/linux/i386/sysdep.h (ALWAYS_USE_VSYSCALL): + New. + 2018-11-30 Florian Weimer * scripts/abilist.awk: Print "0x0" for size 0. Handle "g"/"D". diff --git a/sysdeps/unix/sysv/linux/i386/init-first.c b/sysdeps/unix/sysv/linux/i386/init-first.c index 82ac7f5cf2..6e62dd5923 100644 --- a/sysdeps/unix/sysv/linux/i386/init-first.c +++ b/sysdeps/unix/sysv/linux/i386/init-first.c @@ -16,11 +16,10 @@ License along with the GNU C Library; if not, see . */ -#ifdef SHARED -# include -# include -# include -# include +#include +#include +#include +#include long int (*VDSO_SYMBOL (clock_gettime)) (clockid_t, struct timespec *) attribute_hidden; @@ -44,7 +43,6 @@ __vdso_platform_setup (void) VDSO_SYMBOL (clock_gettime) = p; } -# define VDSO_SETUP __vdso_platform_setup -#endif +#define VDSO_SETUP __vdso_platform_setup #include diff --git a/sysdeps/unix/sysv/linux/i386/sysdep.h b/sysdeps/unix/sysv/linux/i386/sysdep.h index 3255cc78b8..3891663a64 100644 --- a/sysdeps/unix/sysv/linux/i386/sysdep.h +++ b/sysdeps/unix/sysv/linux/i386/sysdep.h @@ -19,6 +19,9 @@ #ifndef _LINUX_I386_SYSDEP_H #define _LINUX_I386_SYSDEP_H 1 +/* Always enable vsyscalls on i386 */ +#define ALWAYS_USE_VSYSCALL 1 + /* There is some commonality. */ #include #include -- 2.19.2