From patchwork Thu Apr 22 01:43:35 2021 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: "H.J. Lu" X-Patchwork-Id: 43068 Return-Path: X-Original-To: patchwork@sourceware.org Delivered-To: patchwork@sourceware.org Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id 55D5D398B886; Thu, 22 Apr 2021 01:44:14 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 55D5D398B886 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=sourceware.org; s=default; t=1619055854; bh=QbkWhRk5w/DyKxXgTBhCXL+zIWBWpZdlEDoh9R2YV6Q=; h=References:In-Reply-To:Date:Subject:To:List-Id:List-Unsubscribe: List-Archive:List-Post:List-Help:List-Subscribe:From:Reply-To:Cc: From; b=BTvz2mV4gHssU0GF07OMYwsVGQZN2zq3+GVdjYEl1loeHQHmdcuXK3qOkZl4dctGG bAL4yeZfkV7CEfve4taZi4YdNflne6FocPOyKTlQIFYjq2v9myoMOmmUcMvAMtfrZe t6b731/aVPgM1hqKfiTu1/wSwA4vZ94cdttx6ARc= X-Original-To: libc-alpha@sourceware.org Delivered-To: libc-alpha@sourceware.org Received: from mail-oi1-x22a.google.com (mail-oi1-x22a.google.com [IPv6:2607:f8b0:4864:20::22a]) by sourceware.org (Postfix) with ESMTPS id 2423C3844046 for ; Thu, 22 Apr 2021 01:44:12 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.3.2 sourceware.org 2423C3844046 Received: by mail-oi1-x22a.google.com with SMTP id r186so16531336oif.8 for ; Wed, 21 Apr 2021 18:44:12 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=QbkWhRk5w/DyKxXgTBhCXL+zIWBWpZdlEDoh9R2YV6Q=; b=ThMFBUSbgqTIa9/IQ7eUEXsh1RRhKjVKdkyv6hgkJcFwXHyhZWBnmgk4WjzKBbjjBg NPk/qwxQORZBGxKNGtXcxkQnOc4N43L4Bd5MGwWMWzWtOF22rCyfa02BtDX6DOHhkbTC s4FBEJFjp3m/U6cWHDp9/hrt+cXd7B8xTmtwRtpMWqYoRShbAv9PsvYvjEwbQeOeGZjT iZG33qvDT2ZvtimCrvQCWLYrPcmrXSad9783fEiaJtX9QZLhGtjDYXMGh1FMhevI5LzL Vb2TWHD5FFtZVN0p1FrYt+TzeeJGSSXyxg3XRHHFq2w+xMs2AmhrFEO7WNRxpWiJ4sNI SQRg== X-Gm-Message-State: AOAM533axFq+hgyWf9XRdIQOri7h79wovjYlbuJWZDq6u0EMjNJTZgkL AZ/UYIfEibCcJ+ZAvezYqKPKyTndKasLiY9HDFfZR+2/ThY= X-Google-Smtp-Source: ABdhPJzRdgd4v2EvY927yuYvLyMYOdlRY1S870cfPob6Grh8dgTgY2OW2yAljDXYhEGYLlfz13Fy3Nei9cAeaGjm0ko= X-Received: by 2002:aca:5904:: with SMTP id n4mr8281003oib.25.1619055851588; Wed, 21 Apr 2021 18:44:11 -0700 (PDT) MIME-Version: 1.0 References: In-Reply-To: Date: Wed, 21 Apr 2021 18:43:35 -0700 Message-ID: Subject: [PATCH] x86: tst-cpu-features-supports.c: Update AMX check To: Joseph Myers X-Spam-Status: No, score=-3034.4 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, FREEMAIL_FROM, GIT_PATCH_0, RCVD_IN_DNSWL_NONE, SPF_HELO_NONE, SPF_PASS, TXREP autolearn=ham autolearn_force=no version=3.4.2 X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on server2.sourceware.org X-BeenThere: libc-alpha@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Libc-alpha mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-Patchwork-Original-From: "H.J. Lu via Libc-alpha" From: "H.J. Lu" Reply-To: "H.J. Lu" Cc: libc-alpha@sourceware.org Errors-To: libc-alpha-bounces@sourceware.org Sender: "Libc-alpha" On Wed, Apr 21, 2021 at 3:45 PM Joseph Myers wrote: > > With GCC mainline, I'm seeing glibc testsuite build failures for x86_64 > and x86: > > ../sysdeps/x86/tst-cpu-features-supports.c: In function 'do_test': > ../sysdeps/x86/tst-cpu-features-supports.c:62:3: error: parameter to builtin not valid: amx_bf16 > 62 | fails += CHECK_SUPPORTS (amx_bf16, AMX_BF16); > | ^~~~~ > ../sysdeps/x86/tst-cpu-features-supports.c:63:3: error: parameter to builtin not valid: amx_int8 > 63 | fails += CHECK_SUPPORTS (amx_int8, AMX_INT8); > | ^~~~~ > ../sysdeps/x86/tst-cpu-features-supports.c:64:3: error: parameter to builtin not valid: amx_tile > 64 | fails += CHECK_SUPPORTS (amx_tile, AMX_TILE); > | ^~~~~ > > https://sourceware.org/pipermail/libc-testresults/2021q2/007827.html > > The code in question is inside a conditional > > #if __GNUC_PREREQ (11, 1) > > so wasn't compiled until the GCC version number was increased to 12 (and > would probably start failing with GCC 11 branch as soon as 11.1 is > released). > Try this. From 023f78e474f844068a9fb615976ea59a1437877f Mon Sep 17 00:00:00 2001 From: "H.J. Lu" Date: Wed, 21 Apr 2021 18:40:08 -0700 Subject: [PATCH] x86: tst-cpu-features-supports.c: Update AMX check Pass "amx-bf16", "amx-int8" and "amx-tile", instead of "amx_bf16", "amx_int8" and "amx_tile", to __builtin_cpu_supports for GCC 11. --- sysdeps/x86/tst-cpu-features-supports.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/sysdeps/x86/tst-cpu-features-supports.c b/sysdeps/x86/tst-cpu-features-supports.c index ce78a7d8bc..a2cabc90be 100644 --- a/sysdeps/x86/tst-cpu-features-supports.c +++ b/sysdeps/x86/tst-cpu-features-supports.c @@ -59,9 +59,9 @@ do_test (int argc, char **argv) fails += CHECK_SUPPORTS (aes, AES); #endif #if __GNUC_PREREQ (11, 1) - fails += CHECK_SUPPORTS (amx_bf16, AMX_BF16); - fails += CHECK_SUPPORTS (amx_int8, AMX_INT8); - fails += CHECK_SUPPORTS (amx_tile, AMX_TILE); + fails += CHECK_SUPPORTS (amx-bf16, AMX_BF16); + fails += CHECK_SUPPORTS (amx-int8, AMX_INT8); + fails += CHECK_SUPPORTS (amx-tile, AMX_TILE); #endif fails += CHECK_SUPPORTS (avx, AVX); fails += CHECK_SUPPORTS (avx2, AVX2); -- 2.30.2