From patchwork Mon Aug 7 20:21:39 2017 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: "H.J. Lu" X-Patchwork-Id: 21959 Received: (qmail 10959 invoked by alias); 7 Aug 2017 20:21:54 -0000 Mailing-List: contact libc-alpha-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Unsubscribe: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: libc-alpha-owner@sourceware.org Delivered-To: mailing list libc-alpha@sourceware.org Received: (qmail 10910 invoked by uid 89); 7 Aug 2017 20:21:50 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-25.0 required=5.0 tests=AWL, BAYES_00, FREEMAIL_FROM, GIT_PATCH_0, GIT_PATCH_1, GIT_PATCH_2, GIT_PATCH_3, RCVD_IN_DNSWL_NONE, RCVD_IN_SORBS_SPAM, SPF_PASS autolearn=ham version=3.3.2 spammy=Hx-languages-length:7097 X-HELO: mail-oi0-f51.google.com X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:in-reply-to:references:from:date :message-id:subject:to:cc; bh=q7aFAoY7F+mwOmOxccQ2K9MFC686uutMP15RxPdEvc0=; b=hiiUSw582GYm6IyOA6Tug2+6e2UXEbQ6tNb6dwDUhUBUbs6K/wAHdZX1qHT1Ks+7Xd 7s2FU1qa9YOIRdos4efr9cQNWOcVY5uZEnRuQIE+YeaNLISsXmF+ZajMJxzyLADbHEUx TNTEgTuAwWlQnqgCCoyM2GhkJ3e1nSqN4x8hV3r75qKaug4zHiZsIxh2X1ooSzvADQFu uiexYhGT0xi22LEn/T8NplGBCqR5Nph9Xitm0mOI9nSzwUmMG7VXJrlgAb6337xYg/4a 2YDOcdgaqrzMPBZ+S+3+ho4M0q6ZN6WYLXijHh7kDejbCLo6/qz1jGM/X4q+6U8q/AI5 M4TQ== X-Gm-Message-State: AHYfb5gx3v0Dt0bd2i3Q89pWbPU29z0iq+dHVdUsDTRf0VcQWMIM2D9T Gz+oxG1EQmcHYuwVRwFIeDn8kxnx4Wan X-Received: by 10.202.179.85 with SMTP id c82mr1241626oif.5.1502137303464; Mon, 07 Aug 2017 13:21:43 -0700 (PDT) MIME-Version: 1.0 In-Reply-To: References: <20170806222606.GA13700@gmail.com> <87lgmvffe1.fsf@linux-m68k.org> From: "H.J. Lu" Date: Mon, 7 Aug 2017 13:21:39 -0700 Message-ID: Subject: Re: [PATCH] i386: Add _startup_sbrk and _startup_fatal [BZ #21913] To: Andreas Schwab Cc: Zack Weinberg , GNU C Library On Mon, Aug 7, 2017 at 10:39 AM, H.J. Lu wrote: > On Mon, Aug 7, 2017 at 10:37 AM, Andreas Schwab wrote: >> On Aug 07 2017, "H.J. Lu" wrote: >> >>> Given this, we need a working sbrk before TLS is initialized. >> >> How about making sbrk always use int $0x80? >> >> Andreas. > > We can do that in sbrk.o and will make change less complex. > I will give it a try. > Here is a patch to add . Tested on i686. OK for master? From 99dd28489e425c6f654126871f89d514331aa69f Mon Sep 17 00:00:00 2001 From: "H.J. Lu" Date: Wed, 19 Jul 2017 14:32:42 -0700 Subject: [PATCH] i386: Add [BZ #21913] On Linux/i386, there are 3 ways to make a system call: 1. call *%gs:SYSINFO_OFFSET. This requires TLS initialization. 2. call *_dl_sysinfo. This requires relocation of _dl_sysinfo. 3. int $0x80. This is slower than #2 and #3, but works everywhere. When an object file is compiled with PIC, #1 is prefered since it is faster than #3 and doesn't require relocation of _dl_sysinfo. For dynamic executables, ld.so initializes TLS. However, for static executables, before TLS is initialized by __libc_setup_tls, #3 should be used for syscalls. This patch adds which defines _startup_fatal and defaults it to __libc_fatal. It replaces __libc_fatal with _startup_fatal in static executables where it is called before __libc_setup_tls is called. This header file is included in all files containing functions which are called before __libc_setup_tls is called. On Linux/i386, when PIE is enabled by default, _startup_fatal is turned into ABORT_INSTRUCTION and I386_USE_SYSENTER is defined to 0 so that "int $0x80" is used for system calls before __libc_setup_tls is called. [BZ #21913] * config.h.in (BUILD_PIE_DEFAULT): New. * csu/libc-tls.c: Include . * elf/dl-tunables.c: Likewise. * sysdeps/unix/sysv/linux/i386/brk.c: Likewise. * csu/libc-tls.c: Include . (__libc_setup_tls): Call _startup_fatal instead of __libc_fatal. * sysdeps/generic/startup.h: New file. * sysdeps/unix/sysv/linux/i386/startup.h: Likewise. --- config.h.in | 6 ++++++ csu/libc-tls.c | 3 ++- elf/dl-tunables.c | 1 + sysdeps/generic/startup.h | 20 +++++++++++++++++++ sysdeps/unix/sysv/linux/i386/brk.c | 1 + sysdeps/unix/sysv/linux/i386/startup.h | 36 ++++++++++++++++++++++++++++++++++ 6 files changed, 66 insertions(+), 1 deletion(-) create mode 100644 sysdeps/generic/startup.h create mode 100644 sysdeps/unix/sysv/linux/i386/startup.h diff --git a/config.h.in b/config.h.in index 22418576a0..a00eb511f2 100644 --- a/config.h.in +++ b/config.h.in @@ -47,6 +47,12 @@ #undef STACK_PROTECTOR_LEVEL #endif +/* When PIC is defined and SHARED isn't defined, we are building PIE + by default. */ +#if defined PIC && !defined SHARED +# define BUILD_PIE_DEFAULT +#endif + /* Define if the regparm attribute shall be used for local functions (gcc on ix86 only). */ #undef USE_REGPARMS diff --git a/csu/libc-tls.c b/csu/libc-tls.c index 3c897bf28b..00138eb43a 100644 --- a/csu/libc-tls.c +++ b/csu/libc-tls.c @@ -16,6 +16,7 @@ License along with the GNU C Library; if not, see . */ +#include #include #include #include @@ -193,7 +194,7 @@ __libc_setup_tls (void) # error "Either TLS_TCB_AT_TP or TLS_DTV_AT_TP must be defined" #endif if (__builtin_expect (lossage != NULL, 0)) - __libc_fatal (lossage); + _startup_fatal (lossage); /* Update the executable's link map with enough information to make the TLS routines happy. */ diff --git a/elf/dl-tunables.c b/elf/dl-tunables.c index 231fb8ca93..b964a09413 100644 --- a/elf/dl-tunables.c +++ b/elf/dl-tunables.c @@ -18,6 +18,7 @@ License along with the GNU C Library; if not, see . */ +#include #include #include #include diff --git a/sysdeps/generic/startup.h b/sysdeps/generic/startup.h new file mode 100644 index 0000000000..196f49edc3 --- /dev/null +++ b/sysdeps/generic/startup.h @@ -0,0 +1,20 @@ +/* Generic definitions of functions used by static libc main startup. + Copyright (C) 2017 Free Software Foundation, Inc. + This file is part of the GNU C Library. + + The GNU C Library is free software; you can redistribute it and/or + modify it under the terms of the GNU Lesser General Public + License as published by the Free Software Foundation; either + version 2.1 of the License, or (at your option) any later version. + + The GNU C Library is distributed in the hope that it will be useful, + but WITHOUT ANY WARRANTY; without even the implied warranty of + MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the GNU + Lesser General Public License for more details. + + You should have received a copy of the GNU Lesser General Public + License along with the GNU C Library; if not, see + . */ + +/* Use macro instead of inline function to avoid including . */ +#define _startup_fatal(message) __libc_fatal ((message)) diff --git a/sysdeps/unix/sysv/linux/i386/brk.c b/sysdeps/unix/sysv/linux/i386/brk.c index 25ab1015d3..bb9cf7ac35 100644 --- a/sysdeps/unix/sysv/linux/i386/brk.c +++ b/sysdeps/unix/sysv/linux/i386/brk.c @@ -16,6 +16,7 @@ License along with the GNU C Library; if not, see . */ +#include #include #include #include diff --git a/sysdeps/unix/sysv/linux/i386/startup.h b/sysdeps/unix/sysv/linux/i386/startup.h new file mode 100644 index 0000000000..a8fd3134b7 --- /dev/null +++ b/sysdeps/unix/sysv/linux/i386/startup.h @@ -0,0 +1,36 @@ +/* Linux/i386 definitions of functions used by static libc main startup. + Copyright (C) 2017 Free Software Foundation, Inc. + This file is part of the GNU C Library. + + The GNU C Library is free software; you can redistribute it and/or + modify it under the terms of the GNU Lesser General Public + License as published by the Free Software Foundation; either + version 2.1 of the License, or (at your option) any later version. + + The GNU C Library is distributed in the hope that it will be useful, + but WITHOUT ANY WARRANTY; without even the implied warranty of + MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the GNU + Lesser General Public License for more details. + + You should have received a copy of the GNU Lesser General Public + License along with the GNU C Library; if not, see + . */ + +#ifdef BUILD_PIE_DEFAULT +# include + +/* Can't use "call *%gs:SYSINFO_OFFSET" during statup in static PIE. */ +# define I386_USE_SYSENTER 0 + +__attribute__ ((__noreturn__)) +static inline void +_startup_fatal (const char *message __attribute__ ((unused))) +{ + /* This is only called very early during startup in static PIE. + FIXME: How can it be improved? */ + ABORT_INSTRUCTION; + __builtin_unreachable (); +} +#else +# include_next +#endif -- 2.13.3