From patchwork Fri Jul 9 03:53:06 2021 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: "H.J. Lu" X-Patchwork-Id: 44290 Return-Path: X-Original-To: patchwork@sourceware.org Delivered-To: patchwork@sourceware.org Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id 368223989099 for ; Fri, 9 Jul 2021 03:54:05 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 368223989099 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=sourceware.org; s=default; t=1625802845; bh=Uv2MhP0wb3oYYLDCwiRgAiUNmyLXSHPG6snPI7hAP7E=; h=References:In-Reply-To:Date:Subject:To:List-Id:List-Unsubscribe: List-Archive:List-Post:List-Help:List-Subscribe:From:Reply-To:Cc: From; b=Xjd3SV8MJvu+RjsMQ64z3S2bJ3uPuMvZRz5WUF+SE1tebi6PQqcheoGbNV8Y2mM8X K88wFdN7OrH1Ww7K+nif39Ex93q2YLwqxqHjuHcGVSrGNBs/3HvwOrmq/ka4wnhHqy t4Uo6s8e6UP3ij3BOokqI3bsd/QrCRhJJF3u05yw= X-Original-To: libc-alpha@sourceware.org Delivered-To: libc-alpha@sourceware.org Received: from mail-pg1-x52f.google.com (mail-pg1-x52f.google.com [IPv6:2607:f8b0:4864:20::52f]) by sourceware.org (Postfix) with ESMTPS id 42D103857C5E for ; Fri, 9 Jul 2021 03:53:43 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 42D103857C5E Received: by mail-pg1-x52f.google.com with SMTP id 62so8654935pgf.1 for ; Thu, 08 Jul 2021 20:53:43 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=Uv2MhP0wb3oYYLDCwiRgAiUNmyLXSHPG6snPI7hAP7E=; b=nUs1gpRxHgV03GmSIC97vvR9AVbYOcDcoxbkXFWnL+sbn6jPcLI7N5KmfyeFtgBp8M T9dYDav9P8WShXIr5TwtSBmM0egGIy1gasW63BE2cYfehAaT2B/Ff1AScJ4iu3rbscSZ Uk7GNHWG8I1+pOngAuY3Ef/D5ak2PkE/I/dwjDyxTgZbUDopeGbMK8QMDoKmcc5sNOzP FmwXLcHzbo9BoZKzv39vhRL36voLy379rreK9sL6Y/8Cdabljj0mypgpT+ODfxqiogGR s2RvFIscmBxSmg8shS1QcNEeFhXNtKowT4HirYM+EEzUa5cgASRVPa2k0SYtwZcdoC6b fRBQ== X-Gm-Message-State: AOAM531aUvtm/Q27yx1Vq2ZwYjb5hEG0tuiWhJWHnIlhBbS58I1tJA5b 5sKg1cPtfzfcvMYWCA93v13lTCSurlflqOh2ry7g3zmX X-Google-Smtp-Source: ABdhPJzdtaTtltGVdYjXAJqiz/JAlQAi6cY9aIlENp54B1NlR5CdInGOgem1/ThvUuWoMHLs3X3rXW+qZ9SiJqeAqB0= X-Received: by 2002:a63:5f11:: with SMTP id t17mr6409392pgb.37.1625802822432; Thu, 08 Jul 2021 20:53:42 -0700 (PDT) MIME-Version: 1.0 References: <20210702023546.3081774-1-siddhesh@sourceware.org> <20210702023546.3081774-3-siddhesh@sourceware.org> <0270d99b-3a15-09d2-7fa9-c9ecf2591d8f@gotplt.org> <433e43a7-e06a-cd08-ee80-7cb84d9ed7e8@gotplt.org> In-Reply-To: <433e43a7-e06a-cd08-ee80-7cb84d9ed7e8@gotplt.org> Date: Thu, 8 Jul 2021 20:53:06 -0700 Message-ID: Subject: [PATCH] Add a generic malloc test for MALLOC_ALIGNMENT To: Siddhesh Poyarekar X-Spam-Status: No, score=-3032.0 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, FREEMAIL_FROM, GIT_PATCH_0, KAM_SHORT, RCVD_IN_DNSWL_NONE, SPF_HELO_NONE, SPF_PASS, TXREP autolearn=ham autolearn_force=no version=3.4.4 X-Spam-Checker-Version: SpamAssassin 3.4.4 (2020-01-24) on server2.sourceware.org X-BeenThere: libc-alpha@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Libc-alpha mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-Patchwork-Original-From: "H.J. Lu via Libc-alpha" From: "H.J. Lu" Reply-To: "H.J. Lu" Cc: Stefan Liebler , GNU C Library Errors-To: libc-alpha-bounces+patchwork=sourceware.org@sourceware.org Sender: "Libc-alpha" On Thu, Jul 8, 2021 at 6:46 PM Siddhesh Poyarekar wrote: > > On 7/9/21 5:36 AM, H.J. Lu wrote: > >> It also caused: > >> > >> https://sourceware.org/bugzilla/show_bug.cgi?id=28068 > >> > >> on x32. > > > > mcheck.c doesn't take MALLOC_ALIGNMENT into account. Will it be removed > > or fixed? > > Very interesting, I think it's best to exclude the test for mcheck on > x32 for now. I'll fix mcheck once the malloc hooks patchset[1] is in. > > On a separate note, this test probably deserves to be run on all > architectures for MALLOC_ALIGNMENT. > > Siddhesh Like this? --- H.J. From dfe77e157c8edc48a27b7c72c880b2a0d8a9859a Mon Sep 17 00:00:00 2001 From: "H.J. Lu" Date: Thu, 8 Jul 2021 20:48:14 -0700 Subject: [PATCH] Add a generic malloc test for MALLOC_ALIGNMENT 1. Add sysdeps/generic/malloc-size.h to define size related macros for malloc. 2. Move x86_64/tst-mallocalign1.c malloc and replace ALIGN_MASK with MALLOC_ALIGN_MASK. --- malloc/Makefile | 1 + malloc/malloc-internal.h | 41 +----------- {sysdeps/x86_64 => malloc}/tst-mallocalign1.c | 28 ++++---- sysdeps/generic/malloc-machine.h | 1 - sysdeps/generic/malloc-size.h | 65 +++++++++++++++++++ sysdeps/x86_64/Makefile | 4 -- 6 files changed, 80 insertions(+), 60 deletions(-) rename {sysdeps/x86_64 => malloc}/tst-mallocalign1.c (69%) create mode 100644 sysdeps/generic/malloc-size.h diff --git a/malloc/Makefile b/malloc/Makefile index 37a9a4efab..b685ed6d61 100644 --- a/malloc/Makefile +++ b/malloc/Makefile @@ -42,6 +42,7 @@ tests := mallocbug tst-malloc tst-valloc tst-calloc tst-obstack \ tst-malloc-stats-cancellation \ tst-tcfree1 tst-tcfree2 tst-tcfree3 \ tst-safe-linking \ + tst-mallocalign1 \ tests-static := \ tst-interpose-static-nothread \ diff --git a/malloc/malloc-internal.h b/malloc/malloc-internal.h index 258f29584e..0c7b5a183c 100644 --- a/malloc/malloc-internal.h +++ b/malloc/malloc-internal.h @@ -21,46 +21,7 @@ #include #include - -/* INTERNAL_SIZE_T is the word-size used for internal bookkeeping of - chunk sizes. - - The default version is the same as size_t. - - While not strictly necessary, it is best to define this as an - unsigned type, even if size_t is a signed type. This may avoid some - artificial size limitations on some systems. - - On a 64-bit machine, you may be able to reduce malloc overhead by - defining INTERNAL_SIZE_T to be a 32 bit `unsigned int' at the - expense of not being able to handle more than 2^32 of malloced - space. If this limitation is acceptable, you are encouraged to set - this unless you are on a platform requiring 16byte alignments. In - this case the alignment requirements turn out to negate any - potential advantages of decreasing size_t word size. - - Implementors: Beware of the possible combinations of: - - INTERNAL_SIZE_T might be signed or unsigned, might be 32 or 64 bits, - and might be the same width as int or as long - - size_t might have different width and signedness as INTERNAL_SIZE_T - - int and long might be 32 or 64 bits, and might be the same width - - To deal with this, most comparisons and difference computations - among INTERNAL_SIZE_Ts should cast them to unsigned long, being - aware of the fact that casting an unsigned int to a wider long does - not sign-extend. (This also makes checking for negative numbers - awkward.) Some of these casts result in harmless compiler warnings - on some systems. */ -#ifndef INTERNAL_SIZE_T -# define INTERNAL_SIZE_T size_t -#endif - -/* The corresponding word size. */ -#define SIZE_SZ (sizeof (INTERNAL_SIZE_T)) - -/* The corresponding bit mask value. */ -#define MALLOC_ALIGN_MASK (MALLOC_ALIGNMENT - 1) - +#include /* Called in the parent process before a fork. */ void __malloc_fork_lock_parent (void) attribute_hidden; diff --git a/sysdeps/x86_64/tst-mallocalign1.c b/malloc/tst-mallocalign1.c similarity index 69% rename from sysdeps/x86_64/tst-mallocalign1.c rename to malloc/tst-mallocalign1.c index 33a6375777..d0c66e435c 100644 --- a/sysdeps/x86_64/tst-mallocalign1.c +++ b/malloc/tst-mallocalign1.c @@ -17,17 +17,16 @@ #include #include +#include +#include -/* Specified by x86-64 psABI. */ -#define ALIGN_MASK (16 - 1) - -void * +static void * test (size_t s) { void *p = malloc (s); - printf ("malloc: %ld, %p: %ld\n", (unsigned long) s, p, - ((unsigned long) p) & ALIGN_MASK); + printf ("malloc: %zu, %p: %zu\n", s, p, + ((uintptr_t) p) & MALLOC_ALIGN_MASK); return p; } @@ -38,35 +37,34 @@ do_test (void) int ret = 0; p = test (2); - ret |= (unsigned long) p & ALIGN_MASK; + ret |= (uintptr_t) p & MALLOC_ALIGN_MASK; free (p); p = test (8); - ret |= (unsigned long) p & ALIGN_MASK; + ret |= (uintptr_t) p & MALLOC_ALIGN_MASK; free (p); p = test (13); - ret |= (unsigned long) p & ALIGN_MASK; + ret |= (uintptr_t) p & MALLOC_ALIGN_MASK; free (p); p = test (16); - ret |= (unsigned long) p & ALIGN_MASK; + ret |= (uintptr_t) p & MALLOC_ALIGN_MASK; free (p); p = test (23); - ret |= (unsigned long) p & ALIGN_MASK; + ret |= (uintptr_t) p & MALLOC_ALIGN_MASK; free (p); p = test (43); - ret |= (unsigned long) p & ALIGN_MASK; + ret |= (uintptr_t) p & MALLOC_ALIGN_MASK; free (p); p = test (123); - ret |= (unsigned long) p & ALIGN_MASK; + ret |= (uintptr_t) p & MALLOC_ALIGN_MASK; free (p); return ret; } -#define TEST_FUNCTION do_test () -#include "../test-skeleton.c" +#include diff --git a/sysdeps/generic/malloc-machine.h b/sysdeps/generic/malloc-machine.h index a71f2361f5..121d8ad0c9 100644 --- a/sysdeps/generic/malloc-machine.h +++ b/sysdeps/generic/malloc-machine.h @@ -21,7 +21,6 @@ #define _GENERIC_MALLOC_MACHINE_H #include -#include #ifndef atomic_full_barrier # define atomic_full_barrier() __asm ("" ::: "memory") diff --git a/sysdeps/generic/malloc-size.h b/sysdeps/generic/malloc-size.h new file mode 100644 index 0000000000..7605fe961e --- /dev/null +++ b/sysdeps/generic/malloc-size.h @@ -0,0 +1,65 @@ +/* Define INTERNAL_SIZE_T, SIZE_SZ, MALLOC_ALIGNMENT and MALLOC_ALIGN_MASK + for malloc. + Copyright (C) 2021 Free Software Foundation, Inc. + This file is part of the GNU C Library. + + The GNU C Library is free software; you can redistribute it and/or + modify it under the terms of the GNU Lesser General Public + License as published by the Free Software Foundation; either + version 2.1 of the License, or (at your option) any later version. + + The GNU C Library is distributed in the hope that it will be useful, + but WITHOUT ANY WARRANTY; without even the implied warranty of + MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the GNU + Lesser General Public License for more details. + + You should have received a copy of the GNU Lesser General Public + License along with the GNU C Library; if not, see + . */ + +#ifndef _GENERIC_MALLOC_SIZE_H +#define _GENERIC_MALLOC_SIZE_H + +#include + +/* INTERNAL_SIZE_T is the word-size used for internal bookkeeping of + chunk sizes. + + The default version is the same as size_t. + + While not strictly necessary, it is best to define this as an + unsigned type, even if size_t is a signed type. This may avoid some + artificial size limitations on some systems. + + On a 64-bit machine, you may be able to reduce malloc overhead by + defining INTERNAL_SIZE_T to be a 32 bit `unsigned int' at the + expense of not being able to handle more than 2^32 of malloced + space. If this limitation is acceptable, you are encouraged to set + this unless you are on a platform requiring 16byte alignments. In + this case the alignment requirements turn out to negate any + potential advantages of decreasing size_t word size. + + Implementors: Beware of the possible combinations of: + - INTERNAL_SIZE_T might be signed or unsigned, might be 32 or 64 bits, + and might be the same width as int or as long + - size_t might have different width and signedness as INTERNAL_SIZE_T + - int and long might be 32 or 64 bits, and might be the same width + + To deal with this, most comparisons and difference computations + among INTERNAL_SIZE_Ts should cast them to unsigned long, being + aware of the fact that casting an unsigned int to a wider long does + not sign-extend. (This also makes checking for negative numbers + awkward.) Some of these casts result in harmless compiler warnings + on some systems. */ +#ifndef INTERNAL_SIZE_T +# define INTERNAL_SIZE_T size_t +#endif + +/* The corresponding word size. */ +#define SIZE_SZ (sizeof (INTERNAL_SIZE_T)) + +/* The corresponding bit mask value. */ +#define MALLOC_ALIGN_MASK (MALLOC_ALIGNMENT - 1) + + +#endif /* _GENERIC_MALLOC_SIZE_H */ diff --git a/sysdeps/x86_64/Makefile b/sysdeps/x86_64/Makefile index 3fc03f4a19..22c5b63ab5 100644 --- a/sysdeps/x86_64/Makefile +++ b/sysdeps/x86_64/Makefile @@ -13,10 +13,6 @@ sysdep_routines += _mcount sysdep_noprof += _mcount endif -ifeq ($(subdir),malloc) -tests += tst-mallocalign1 -endif - ifeq ($(subdir),string) sysdep_routines += strcasecmp_l-nonascii strncase_l-nonascii gen-as-const-headers += locale-defines.sym -- 2.31.1