From patchwork Fri Apr 25 16:38:05 2014 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: "H.J. Lu" X-Patchwork-Id: 684 Return-Path: X-Original-To: siddhesh@wilcox.dreamhost.com Delivered-To: siddhesh@wilcox.dreamhost.com Received: from homiemail-mx22.g.dreamhost.com (mx2.sub5.homie.mail.dreamhost.com [208.113.200.128]) by wilcox.dreamhost.com (Postfix) with ESMTP id 0E09E36008E for ; Fri, 25 Apr 2014 09:38:11 -0700 (PDT) Received: by homiemail-mx22.g.dreamhost.com (Postfix, from userid 14307373) id B0B43515DE12; Fri, 25 Apr 2014 09:38:11 -0700 (PDT) X-Original-To: glibc@patchwork.siddhesh.in Delivered-To: x14307373@homiemail-mx22.g.dreamhost.com Received: from sourceware.org (server1.sourceware.org [209.132.180.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by homiemail-mx22.g.dreamhost.com (Postfix) with ESMTPS id 624CD515DE2E for ; Fri, 25 Apr 2014 09:38:11 -0700 (PDT) DomainKey-Signature: a=rsa-sha1; c=nofws; d=sourceware.org; h=list-id :list-unsubscribe:list-subscribe:list-archive:list-post :list-help:sender:mime-version:in-reply-to:references:date :message-id:subject:from:to:cc:content-type; q=dns; s=default; b= VrOr9amSJeIYyHRgZSz2X7LtOZmRxsgx0oFXEAoKpxsINlSSoyaefVXcJ20XpTG7 dbDk3YXCd4ZZR6M6kEJzWJ8UkEnmZrNxrEIPyebzYvZozT67SI6ouE/Ey+nZuIBn KVKn66q4moQ7tFXHZNbr2EanTxhlSV31N2GYDqjLzqI= DKIM-Signature: v=1; a=rsa-sha1; c=relaxed; d=sourceware.org; h=list-id :list-unsubscribe:list-subscribe:list-archive:list-post :list-help:sender:mime-version:in-reply-to:references:date :message-id:subject:from:to:cc:content-type; s=default; bh=D+jJT t7fEibKUVLMm6ssoUZXkqY=; b=lBPjiLXCR1E9gESXlYbn1QxzjVXWO0ebBVdcb K0VyLoyEnfXBZXlmkV24M06/t1B/dWjPYeZMrlNmcTtWJn2zIH8e5oEcIZwubhrR JRuD8MRDBdynNESrx00lHQZn3brqgx1pHBOaGOdvIa5R18k71+EoddLG6mfGfJB+ 0dROUM= Received: (qmail 8284 invoked by alias); 25 Apr 2014 16:38:09 -0000 Mailing-List: contact libc-alpha-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Unsubscribe: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: libc-alpha-owner@sourceware.org Delivered-To: mailing list libc-alpha@sourceware.org Received: (qmail 8254 invoked by uid 89); 25 Apr 2014 16:38:08 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-1.3 required=5.0 tests=AWL, BAYES_00, FREEMAIL_FROM, RCVD_IN_DNSWL_LOW, SPF_PASS, UNSUBSCRIBE_BODY autolearn=no version=3.3.2 X-HELO: mail-oa0-f47.google.com MIME-Version: 1.0 X-Received: by 10.182.135.228 with SMTP id pv4mr2403757obb.62.1398443885434; Fri, 25 Apr 2014 09:38:05 -0700 (PDT) In-Reply-To: <535A8A8F.5080807@redhat.com> References: <0EFAB2BDD0F67E4FB6CCC8B9F87D756942973E8E@IRSMSX101.ger.corp.intel.com> <5359FBA4.7010203@redhat.com> <535A8A8F.5080807@redhat.com> Date: Fri, 25 Apr 2014 09:38:05 -0700 Message-ID: Subject: Re: [PATCH 2/N, MPX, x86_64] Intel MPX support in glibc for x86_64 From: "H.J. Lu" To: "Carlos O'Donell" Cc: "Joseph S. Myers" , "Zamyatin, Igor" , "libc-alpha@sourceware.org" , =?UTF-8?B?T25kxZllaiBCw61sa2E=?= X-DH-Original-To: glibc@patchwork.siddhesh.in On Fri, Apr 25, 2014 at 9:17 AM, Carlos O'Donell wrote: > On 04/25/2014 10:30 AM, Joseph S. Myers wrote: >> On Fri, 25 Apr 2014, Carlos O'Donell wrote: >> >>> You should test for __int128, set HAVE_INT128, and make this >>> support conditional on the compiler feature being present >>> (avoid hard-coding the compiler version). I believe Ondrej >>> posted a patch for this? >> >> bits/link.h is an installed header so can't contain conditionals on >> configure test results like that. >> >> However, the __int128_t built-in typedef is much older than the __int128 >> keyword (dating back to GCC 3.0, i.e. predating x86_64 support which was >> added in 3.1), so that can be used instead. > > Agreed. Thanks for catching the fact that this is an installed header. > I tested and checked in this patch to replace __int128 with __int128_t. Thanks. diff --git a/ChangeLog b/ChangeLog index 0909d3b..3ab4d4a 100644 --- a/ChangeLog +++ b/ChangeLog @@ -1,3 +1,9 @@ +2014-04-25 H.J. Lu + + * sysdeps/x86/bits/link.h (La_x86_64_regs): Replace __int128 + with __int128_t. + (La_x86_64_retval): Likewise. + 2014-04-24 Ian Bolton * sysdeps/aarch64/fpu/fclrexcpt.c (feclearexcept): Don't write to diff --git a/sysdeps/x86/bits/link.h b/sysdeps/x86/bits/link.h index 82522e5..ebc5989 100644 --- a/sysdeps/x86/bits/link.h +++ b/sysdeps/x86/bits/link.h @@ -94,7 +94,7 @@ typedef struct La_x86_64_regs La_x86_64_xmm lr_xmm[8]; La_x86_64_vector lr_vector[8]; #ifndef __ILP32__ - __int128 lr_bnd[4]; + __int128_t lr_bnd[4]; #endif } La_x86_64_regs; @@ -110,8 +110,8 @@ typedef struct La_x86_64_retval La_x86_64_vector lrv_vector0; La_x86_64_vector lrv_vector1; #ifndef __ILP32__ - __int128 lrv_bnd0; - __int128 lrv_bnd1; + __int128_t lrv_bnd0; + __int128_t lrv_bnd1; #endif } La_x86_64_retval;