From patchwork Wed Jul 28 17:22:05 2021 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: "H.J. Lu" X-Patchwork-Id: 44502 Return-Path: X-Original-To: patchwork@sourceware.org Delivered-To: patchwork@sourceware.org Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id 29410399C028 for ; Wed, 28 Jul 2021 17:23:05 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 29410399C028 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=sourceware.org; s=default; t=1627492985; bh=VYfLvdlrg60SAqM6Z88KbWRJv7pDSQGUqk0aKYx2FP0=; h=References:In-Reply-To:Date:Subject:To:List-Id:List-Unsubscribe: List-Archive:List-Post:List-Help:List-Subscribe:From:Reply-To:Cc: From; b=sXUuD8BE2CyTr7sg6kS6sR1l4amJPv5zRevRrxssdqzyeD5MlRL+ixfkUwAghemll 1FjYENdfdEKIrnosgzJYopUfyUuXdTi8Qws+c7jJOvFB0Adhiy2bQLXlHTLORbsy8k k8CtvQypsFBfqu5tRv1bVnbkeLwbv3BxLBMM4XNk= X-Original-To: libc-alpha@sourceware.org Delivered-To: libc-alpha@sourceware.org Received: from mail-pj1-x102f.google.com (mail-pj1-x102f.google.com [IPv6:2607:f8b0:4864:20::102f]) by sourceware.org (Postfix) with ESMTPS id 918A83888C5F for ; Wed, 28 Jul 2021 17:22:42 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 918A83888C5F Received: by mail-pj1-x102f.google.com with SMTP id mz5-20020a17090b3785b0290176ecf64922so11119056pjb.3 for ; Wed, 28 Jul 2021 10:22:42 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=VYfLvdlrg60SAqM6Z88KbWRJv7pDSQGUqk0aKYx2FP0=; b=b/1THbAlUNEPCjpk8Br7kxu7F59KeYOUcbYeOsaBMKAbStj5HcKsKA7N4eMtTFtU7/ yXHptO9he9suxUy5jgJX4xFjGT0I1JX3187sorcMw9OhAcsiu+RqeBrPfL9mR2F7pnqc dVFUmTkIeZ/wStT25Kk8zQPSfDkSwAEnbEGs8ecj0SaSBNoHU8jiAq4LEL0bRTXXdAH+ TbO/Vpt/87215SoVACvpTNAXxmZWG+rn66uImbDmt8qqdzGN0dV/1VRCSGnEQYl/I1xJ UnxTKm9sVPt+auMmlHjD1I4GOpSX3mVK4J3SqXlc00FqwI1tcQZZd9reCYssc+mGi+pU hBsg== X-Gm-Message-State: AOAM533vVEhAknrwp0TUMNUQXUdXjIhrM0Bk1lWd+xXcelTXN2q2zIj1 6amZ2pMU1t9JzAUSmo4SMGaPR/1gL0eUMWSWqPk= X-Google-Smtp-Source: ABdhPJzOZRss6F23AwQN+s4NJGx4sP//DyirStXM6iHft/ja4h8flE41tyIWUra/4noL45fBFrZgfGOnvQqUojWVHCU= X-Received: by 2002:aa7:8812:0:b029:32d:8252:fd0 with SMTP id c18-20020aa788120000b029032d82520fd0mr830226pfo.48.1627492961330; Wed, 28 Jul 2021 10:22:41 -0700 (PDT) MIME-Version: 1.0 References: <87eebkf8ph.fsf@oldenburg.str.redhat.com> <5551022.NgBsaNRSFp@pinacolada> <87y29r9gqc.fsf@oldenburg.str.redhat.com> In-Reply-To: <87y29r9gqc.fsf@oldenburg.str.redhat.com> Date: Wed, 28 Jul 2021 10:22:05 -0700 Message-ID: Subject: [PATCH] Typo: Rename HAVE_CLONE3_WAPPER to HAVE_CLONE3_WRAPPER To: Florian Weimer , "Carlos O'Donell" X-Spam-Status: No, score=-3031.5 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, FREEMAIL_FROM, GIT_PATCH_0, RCVD_IN_DNSWL_NONE, SPF_HELO_NONE, SPF_PASS, TXREP autolearn=ham autolearn_force=no version=3.4.4 X-Spam-Checker-Version: SpamAssassin 3.4.4 (2020-01-24) on server2.sourceware.org X-BeenThere: libc-alpha@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Libc-alpha mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-Patchwork-Original-From: "H.J. Lu via Libc-alpha" From: "H.J. Lu" Reply-To: "H.J. Lu" Cc: "Andreas K. Huettel via Libc-alpha" Errors-To: libc-alpha-bounces+patchwork=sourceware.org@sourceware.org Sender: "Libc-alpha" On Tue, Jul 27, 2021 at 9:59 PM Florian Weimer via Libc-alpha wrote: > > * Andreas K. Huettel via Libc-alpha: > > > Semi-related... > > > >> int ret; > >> -#ifdef HAVE_CLONE3_WAPPER > >> - /* Try clone3 first. */ > >> - int saved_errno = errno; > > > > shouldn't this be WRAPPER ? > > > > (It seems to be consistent in the code, so no harm done so far...) > > Yes, it should be. And yes, it's currently consistent. But it's > confusing if you search for it and don't make the typo. > > Thanks, > Florian > Here is the patch. OK for master? From c25c32165d8b7c506442fdc0304f7a3a223e1f42 Mon Sep 17 00:00:00 2001 From: "H.J. Lu" Date: Wed, 28 Jul 2021 10:19:08 -0700 Subject: [PATCH] Typo: Rename HAVE_CLONE3_WAPPER to HAVE_CLONE3_WRAPPER --- sysdeps/unix/sysv/linux/clone-internal.c | 2 +- sysdeps/unix/sysv/linux/i386/sysdep.h | 2 +- sysdeps/unix/sysv/linux/x86_64/sysdep.h | 2 +- 3 files changed, 3 insertions(+), 3 deletions(-) diff --git a/sysdeps/unix/sysv/linux/clone-internal.c b/sysdeps/unix/sysv/linux/clone-internal.c index 1e7a8f6b35..979f7880be 100644 --- a/sysdeps/unix/sysv/linux/clone-internal.c +++ b/sysdeps/unix/sysv/linux/clone-internal.c @@ -48,7 +48,7 @@ __clone_internal (struct clone_args *cl_args, int (*func) (void *arg), void *arg) { int ret; -#ifdef HAVE_CLONE3_WAPPER +#ifdef HAVE_CLONE3_WRAPPER /* Try clone3 first. */ int saved_errno = errno; ret = __clone3 (cl_args, sizeof (*cl_args), func, arg); diff --git a/sysdeps/unix/sysv/linux/i386/sysdep.h b/sysdeps/unix/sysv/linux/i386/sysdep.h index 3927a1a6e0..8a9911b7ac 100644 --- a/sysdeps/unix/sysv/linux/i386/sysdep.h +++ b/sysdeps/unix/sysv/linux/i386/sysdep.h @@ -291,7 +291,7 @@ struct libc_do_syscall_args # define HAVE_TIME_VSYSCALL "__vdso_time" # define HAVE_CLOCK_GETRES_VSYSCALL "__vdso_clock_getres" -# define HAVE_CLONE3_WAPPER 1 +# define HAVE_CLONE3_WRAPPER 1 # undef HAVE_INTERNAL_BRK_ADDR_SYMBOL # define HAVE_INTERNAL_BRK_ADDR_SYMBOL 1 diff --git a/sysdeps/unix/sysv/linux/x86_64/sysdep.h b/sysdeps/unix/sysv/linux/x86_64/sysdep.h index f26ffc68ae..327e59388b 100644 --- a/sysdeps/unix/sysv/linux/x86_64/sysdep.h +++ b/sysdeps/unix/sysv/linux/x86_64/sysdep.h @@ -377,7 +377,7 @@ # define HAVE_GETCPU_VSYSCALL "__vdso_getcpu" # define HAVE_CLOCK_GETRES64_VSYSCALL "__vdso_clock_getres" -# define HAVE_CLONE3_WAPPER 1 +# define HAVE_CLONE3_WRAPPER 1 # define SINGLE_THREAD_BY_GLOBAL 1 -- 2.31.1