From patchwork Mon Dec 12 15:44:29 2016
Content-Type: text/plain; charset="utf-8"
MIME-Version: 1.0
Content-Transfer-Encoding: 7bit
X-Patchwork-Submitter: Andrew Senkevich <andrew.n.senkevich@gmail.com>
X-Patchwork-Id: 18406
Received: (qmail 7027 invoked by alias); 12 Dec 2016 15:45:26 -0000
Mailing-List: contact libc-alpha-help@sourceware.org; run by ezmlm
Precedence: bulk
List-Id: <libc-alpha.sourceware.org>
List-Unsubscribe: <mailto:libc-alpha-unsubscribe-##L=##H@sourceware.org>
List-Subscribe: <mailto:libc-alpha-subscribe@sourceware.org>
List-Archive: <http://sourceware.org/ml/libc-alpha/>
List-Post: <mailto:libc-alpha@sourceware.org>
List-Help: <mailto:libc-alpha-help@sourceware.org>,
	<http://sourceware.org/ml/#faqs>
Sender: libc-alpha-owner@sourceware.org
Delivered-To: mailing list libc-alpha@sourceware.org
Received: (qmail 5163 invoked by uid 89); 12 Dec 2016 15:45:19 -0000
Authentication-Results: sourceware.org; auth=none
X-Virus-Found: No
X-Spam-SWARE-Status: No, score=-1.8 required=5.0 tests=AWL, BAYES_00,
	FREEMAIL_FROM, RCVD_IN_DNSWL_NONE,
	SPF_PASS autolearn=ham version=3.3.2 spammy=H*c:sk:001a113,
	U*$
X-HELO: mail-ua0-f173.google.com
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
	d=1e100.net; s=20130820;
	h=x-gm-message-state:mime-version:in-reply-to:references:from:date
	:message-id:subject:to:cc;
	bh=+EK0jw/QaFHy+z9a8aQX/k3ghEWaeV2bN0y35asvI9A=;
	b=S8CfdvVvmPA5jn/D+GK3Nv5XWRmyvr1K8z8unfCY3P/bRzIwZ7YoFUIjT74l08+K0M
	LR6B5f0N8/+lzxVU+PhjvtVuV5OM8ZDgGHWLesNGOiAgMxMoOObq9lKfLlnIdYmFJudo
	twsFTe00euYage1xwropHpagVHtwSgOtvWSP1X6OMu/WTNonysQU0H5NmahyPPNlufcq
	d8QPNYiXutvGkQFOKdcXAJwrISEyQIGW7klbImtcFbNcGXXdWNGv1BW3vlhIBRi2N9/z
	G0un0jayWmqycojdztrroNOWYU576v0fc/ulvYbYD7ZJubBU3pMxVf8gRTvg95FxnjHc
	WdCA==
X-Gm-Message-State: 
 AKaTC00GBALIJLtvCrCaSPKHkBWXk3uQfvMut1T6vmswHlR48Mlbw2A7LRA3q/FV1sKbJj5X/BNBKgo2xs+gfg==
X-Received: by 10.159.33.207 with SMTP id 73mr74321136uac.150.1481557500222;
	Mon, 12 Dec 2016 07:45:00 -0800 (PST)
MIME-Version: 1.0
In-Reply-To: <87d1h1rmfm.fsf@linux-m68k.org>
References: 
 <CAMXFM3szvCP13C1P_Ed8NVV_FTt4Q8avz4uW-a=UbpWqMnF5aw@mail.gmail.com>
	<CAMe9rOqirjhp+cpWGTVeQKd8p-yNdsO=mQ+-Ww-B4ULSjfUSWA@mail.gmail.com>
	<CAMXFM3u+VyNo0Y0DzZcZc0JaAqP8pqy44==Fg3dw0QxS=gzPaw@mail.gmail.com>
	<CAMe9rOoZMyS2wgV9wxGAj-KzWA9UAJHV5VDN+2oen9YQhfTJUQ@mail.gmail.com>
	<CAMXFM3tVcbMS1ShEv9_GB5MVeH0ombWucvHm32H0AP8TKNpucA@mail.gmail.com>
	<mvm8trtjg54.fsf@hawking.suse.de>
	<CAMXFM3tFrVDJYwdgr=HXw4vu6JkpwMpfEYhsf9mXDJJ0S7QL3w@mail.gmail.com>
	<mvmvauxhym3.fsf@hawking.suse.de>
	<CAMXFM3vbgbmXW4YKRR5VVXAng=FtZ2wFY5HmaH-nqxwOcgHu8Q@mail.gmail.com>
	<CAMe9rOqGZWgQhDQYO9NQBehG90dX4uTAjCwZdZ+xBn6hALgoZQ@mail.gmail.com>
	<CAMXFM3uOCL44j=TNO3x8HO1AtxEj36Z1PcCXu1SfVoqLD1jjqA@mail.gmail.com>
	<CAMe9rOr713WNJvs73-kNYEJ9kZiTzoevCK-7xMeD3SCUoLwXcg@mail.gmail.com>
	<CAMXFM3uXUkSysVmFrqM5M4wPPkmEZbzFUO1mvNzNu89w_bVarA@mail.gmail.com>
	<87h96dru2a.fsf@linux-m68k.org>
	<CAMXFM3utwitJ-k-=D2N3j5MqZzee8Uy5eBnSGYU1XzMop1NOMw@mail.gmail.com>
	<87d1h1rmfm.fsf@linux-m68k.org>
From: Andrew Senkevich <andrew.n.senkevich@gmail.com>
Date: Mon, 12 Dec 2016 18:44:29 +0300
Message-ID: 
 <CAMXFM3uyGBgNhZpWr3EzEiQOsHouAPxrfvuqgdD9OkFy4xRUog@mail.gmail.com>
Subject: Re: [PATCH] Install libm.a as linker script [BZ #20539]
To: Andreas Schwab <schwab@suse.de>
Cc: "H.J. Lu" <hjl.tools@gmail.com>, libc-alpha <libc-alpha@sourceware.org>

2016-12-09 21:23 GMT+03:00 Andreas Schwab <schwab@suse.de>:
> On Dez 09 2016, Andrew Senkevich <andrew.n.senkevich@gmail.com> wrote:
>
>> 2016-12-09 18:38 GMT+03:00 Andreas Schwab <schwab@suse.de>:
>>> On Dez 07 2016, Andrew Senkevich <andrew.n.senkevich@gmail.com> wrote:
>>>
>>>> +$(inst_libdir)/libm.a: $(common-objpfx)format.lds \
>>>> +                    $(libm) \
>>>> +                    $(libmvec) \
>>>> +                    $(+force)
>>>> +     (echo '/* GNU ld script'; echo '*/';\
>>>> +      cat $<; \
>>>> +      echo 'GROUP ( $(libdir)/libm-$(lib-version).a $(libdir)/libmvec.a )' \
>>>> +     ) > $@.new
>>>> +     cp $(objpfx)libm.a $(inst_libdir)/libm-$(lib-version).a
>>>
>>> A rule should only create the target, nothing else.
>>
>> Is the following update Ok?
>
> There is no neeed to go through a stamp file, just depend on
> $(inst_libdir)/libm-$(lib-version).a, and add a rule which copies
> $(objpfx)libm.a there.

I see. Is it ok:
---
WBR,
Andrew

diff --git a/ChangeLog b/ChangeLog
index 4d31f4f..a5336d3 100644
--- a/ChangeLog
+++ b/ChangeLog
@@ -1,3 +1,8 @@
+2016-12-12  Andrew Senkevich  <andrew.senkevich@intel.com>
+
+ * math/Makefile ($(inst_libdir)/libm-$(lib-version).a): New target.
+ ($(inst_libdir)/libm.a): Correct rule to create the target only.
+
 2016-12-10  Florian Weimer  <fweimer@redhat.com>

  [BZ #20956]
diff --git a/math/Makefile b/math/Makefile
index 49556f6..38ce4ab 100644
--- a/math/Makefile
+++ b/math/Makefile
@@ -143,15 +143,17 @@ $(inst_libdir)/libm.so: $(common-objpfx)format.lds \
  ) > $@.new
  mv -f $@.new $@

+$(inst_libdir)/libm-$(lib-version).a: $(objpfx)libm.a
+ cp $(objpfx)libm.a $(inst_libdir)/libm-$(lib-version).a
+
 $(inst_libdir)/libm.a: $(common-objpfx)format.lds \
-       $(libm) \
-       $(libmvec) \
+       $(inst_libdir)/libm-$(lib-version).a \
+       $(objpfx)../mathvec/libmvec.a \
        $(+force)
  (echo '/* GNU ld script'; echo '*/';\
  cat $<; \
  echo 'GROUP ( $(libdir)/libm-$(lib-version).a $(libdir)/libmvec.a )' \
  ) > $@.new
- cp $(objpfx)libm.a $(inst_libdir)/libm-$(lib-version).a
  mv -f $@.new $@
 endif