From patchwork Mon Dec 12 17:58:06 2016 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Andrew Senkevich X-Patchwork-Id: 18409 Received: (qmail 28774 invoked by alias); 12 Dec 2016 17:58:50 -0000 Mailing-List: contact libc-alpha-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Unsubscribe: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: libc-alpha-owner@sourceware.org Delivered-To: mailing list libc-alpha@sourceware.org Received: (qmail 28277 invoked by uid 89); 12 Dec 2016 17:58:49 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-1.3 required=5.0 tests=AWL, BAYES_00, FREEMAIL_FROM, RCVD_IN_DNSWL_NONE, RCVD_IN_SORBS_SPAM, SPF_PASS autolearn=no version=3.3.2 spammy=andrewsenkevichintelcom, andrew.senkevich@intel.com X-HELO: mail-ua0-f194.google.com X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:mime-version:in-reply-to:references:from:date :message-id:subject:to:cc; bh=dkt8zpwqwXoYZeAT8kdLAYYKnQzqj9TQ0OxHIdsml6g=; b=XkwHVNXaRTCMHprd3eHFCj0mnWdFZG/r8D5pderfs7liAzoVXiLWNMI4NQHX23MPQ+ 5DyF578+SnDCEuGkIak86yzynsBYC8KyJy0OlN+1/a9rXPDzHWI5PsvkNNrekEUxHHU+ JhC9b+hpcSd3AFVvcOYjPhVf170yIdO+0iSGYwvnA6d9XNJDDl2CwsqSlx01h+yCPx1r +LK8YPhStdYS/FbeRo10EcFAfYs92zMLUny89KoiZRzvKeDK/TXLb+93g/UgvnkgXYm5 bwHCE9EDqNNtE5j1TO2t5oxzojel5eP+nOsNUyCVIc9teBv6bEIgyGG+Ge387Y6yRkF5 kb8A== X-Gm-Message-State: AKaTC022zkw2DvsCgsFw8QRQFqNL9vnIbhv/w/6TIWua4NDWuix43E+8vVlu23ZOAbxM3eRq4t096/KDXC6qMw== X-Received: by 10.176.86.23 with SMTP id y23mr59202346uaa.88.1481565517751; Mon, 12 Dec 2016 09:58:37 -0800 (PST) MIME-Version: 1.0 In-Reply-To: References: <87h96dru2a.fsf@linux-m68k.org> <87d1h1rmfm.fsf@linux-m68k.org> From: Andrew Senkevich Date: Mon, 12 Dec 2016 20:58:06 +0300 Message-ID: Subject: Re: [PATCH] Install libm.a as linker script [BZ #20539] To: Andreas Schwab Cc: "H.J. Lu" , libc-alpha 2016-12-12 19:42 GMT+03:00 Andreas Schwab : > On Dez 12 2016, Andrew Senkevich wrote: > >> 2016-12-12 19:18 GMT+03:00 Andreas Schwab : >>> On Dez 12 2016, Andrew Senkevich wrote: >>> >>>> diff --git a/math/Makefile b/math/Makefile >>>> index 49556f6..38ce4ab 100644 >>>> --- a/math/Makefile >>>> +++ b/math/Makefile >>>> @@ -143,15 +143,17 @@ $(inst_libdir)/libm.so: $(common-objpfx)format.lds \ >>>> ) > $@.new >>>> mv -f $@.new $@ >>>> >>>> +$(inst_libdir)/libm-$(lib-version).a: $(objpfx)libm.a >>>> + cp $(objpfx)libm.a $(inst_libdir)/libm-$(lib-version).a >>> >>> Use automatic variables. >> >> I also have tried >> >>>> +$(inst_libdir)/libm-$(lib-version).a: $(objpfx)libm.a >>>> + cp $(objpfx)libm.a $@ >> >> but it doesn't work. libm-.a was created instead of libm-2.24.90.a. > > That means that the target is wrong. Indeed, we need to use $(version). Ok for trunk? --- WBR, Andrew diff --git a/ChangeLog b/ChangeLog index 91cc64d..f6ffda8 100644 --- a/ChangeLog +++ b/ChangeLog @@ -1,3 +1,8 @@ +2016-12-12 Andrew Senkevich + + * math/Makefile ($(inst_libdir)/libm-$(version).a): New target. + ($(inst_libdir)/libm.a): Correct rule to create the target only. + 2016-12-12 Florian Weimer [BZ #17252] diff --git a/math/Makefile b/math/Makefile index 49556f6..1973bf2 100644 --- a/math/Makefile +++ b/math/Makefile @@ -143,15 +143,17 @@ $(inst_libdir)/libm.so: $(common-objpfx)format.lds \ ) > $@.new mv -f $@.new $@ +$(inst_libdir)/libm-$(version).a: $(objpfx)libm.a + cp $(objpfx)libm.a $@ + $(inst_libdir)/libm.a: $(common-objpfx)format.lds \ - $(libm) \ - $(libmvec) \ + $(inst_libdir)/libm-$(version).a \ + $(objpfx)../mathvec/libmvec.a \ $(+force) (echo '/* GNU ld script'; echo '*/';\ cat $<; \ - echo 'GROUP ( $(libdir)/libm-$(lib-version).a $(libdir)/libmvec.a )' \ + echo 'GROUP ( $(libdir)/libm-$(version).a $(libdir)/libmvec.a )' \ ) > $@.new - cp $(objpfx)libm.a $(inst_libdir)/libm-$(lib-version).a mv -f $@.new $@ endif