[13/14,x86_64] Vector math functions (sincos and tests)

  2015-06-19 20:06 GMT+03:00 Joseph Myers <joseph@codesourcery.com>:
> On Fri, 19 Jun 2015, Tulio Magno Quites Machado Filho wrote:
>
>> >> It doesn't fix the problem.
>> >
>> > Could you please explain why with more details (exact compilation
>> > command caused fail will the best help)?
>>
>> Sure!
>> All the log is available in the community BuildBot at
>> http://glibc-build.hack.frob.com/waterfall
>>
>> The log of the build is here:
>> http://130.211.48.148:8080/builders/glibc-power8-linux/builds/0/steps/annotate/logs/stdio
>
> Preprocessed source might help as well, to show what the code looks like
> that produces the parse errors and where it appears in the sequence of
> nested includes.  I wonder if, as well as __DECL_SIMD_sincos_disable,
> __DECL_SIMD_sincos_disablef and __DECL_SIMD_sincos_disablel need to be
> defined.

Yes, I also found it through preprocessor output.



--
WBR,
Andrew
  

On Fri, 19 Jun 2015, Andrew Senkevich wrote:

> diff --git a/ChangeLog b/ChangeLog
> index 7dedfb4..8951f85 100644
> --- a/ChangeLog
> +++ b/ChangeLog
> @@ -1,3 +1,8 @@
> +2015-06-19  Andrew Senkevich  <andrew.senkevich@intel.com>
> +
> +       * sysdeps/ieee754/ldbl-opt/s_sin.c (__DECL_SIMD_sincos_disable): Added
> +       empty definitions for proper unfolding of __MATHDECL_VEC.

OK, though the ChangeLog entry should name all three symbols added, and I 
don't know what "Stabs" means in the comment (stubs?).
  

Andrew Senkevich <andrew.n.senkevich@gmail.com> writes:

> 2015-06-19 20:06 GMT+03:00 Joseph Myers <joseph@codesourcery.com>:
>> Preprocessed source might help as well, to show what the code looks like
>> that produces the parse errors and where it appears in the sequence of
>> nested includes.  I wonder if, as well as __DECL_SIMD_sincos_disable,
>> __DECL_SIMD_sincos_disablef and __DECL_SIMD_sincos_disablel need to be
>> defined.
>
> Yes, I also found it through preprocessor output.
>
> diff --git a/ChangeLog b/ChangeLog
> index 7dedfb4..8951f85 100644
> --- a/ChangeLog
> +++ b/ChangeLog
> @@ -1,3 +1,8 @@
> +2015-06-19  Andrew Senkevich  <andrew.senkevich@intel.com>
> +
> +       * sysdeps/ieee754/ldbl-opt/s_sin.c (__DECL_SIMD_sincos_disable): Added
> +       empty definitions for proper unfolding of __MATHDECL_VEC.
> +
>  2015-06-19  Stefan Liebler  <stli@linux.vnet.ibm.com>
>
>         * benchtests/bench-strcoll.c:
> diff --git a/sysdeps/ieee754/ldbl-opt/s_sin.c b/sysdeps/ieee754/ldbl-opt/s_sin.c
> index a11d5a3..10f5ea7 100644
> --- a/sysdeps/ieee754/ldbl-opt/s_sin.c
> +++ b/sysdeps/ieee754/ldbl-opt/s_sin.c
> @@ -1,5 +1,9 @@
>  /* dbl-64/s_sin.c uses NAN and sincos identifiers internally.  */
>  #define sincos sincos_disable
> +/* Stabs needed for proper unfolding of __MATHDECL_VEC.  */
> +#define __DECL_SIMD_sincos_disable
> +#define __DECL_SIMD_sincos_disablef
> +#define __DECL_SIMD_sincos_disablel
>  #include <math_ldbl_opt.h>
>  #undef NAN
>  #undef sincos

This patch does fix the build error.

Thanks Andrew, Anton and Joseph!