From patchwork Fri Jun 19 11:06:55 2015
Content-Type: text/plain; charset="utf-8"
MIME-Version: 1.0
Content-Transfer-Encoding: 7bit
X-Patchwork-Submitter: Andrew Senkevich <andrew.n.senkevich@gmail.com>
X-Patchwork-Id: 7254
Received: (qmail 79330 invoked by alias); 19 Jun 2015 11:07:31 -0000
Mailing-List: contact libc-alpha-help@sourceware.org; run by ezmlm
Precedence: bulk
List-Id: <libc-alpha.sourceware.org>
List-Unsubscribe: <mailto:libc-alpha-unsubscribe-##L=##H@sourceware.org>
List-Subscribe: <mailto:libc-alpha-subscribe@sourceware.org>
List-Archive: <http://sourceware.org/ml/libc-alpha/>
List-Post: <mailto:libc-alpha@sourceware.org>
List-Help: <mailto:libc-alpha-help@sourceware.org>,
	<http://sourceware.org/ml/#faqs>
Sender: libc-alpha-owner@sourceware.org
Delivered-To: mailing list libc-alpha@sourceware.org
Received: (qmail 79313 invoked by uid 89); 19 Jun 2015 11:07:31 -0000
Authentication-Results: sourceware.org; auth=none
X-Virus-Found: No
X-Spam-SWARE-Status: No, score=-1.5 required=5.0 tests=AWL, BAYES_40,
	FREEMAIL_FROM, RCVD_IN_DNSWL_LOW,
	SPF_PASS autolearn=ham version=3.3.2
X-HELO: mail-lb0-f181.google.com
X-Received: by 10.152.29.6 with SMTP id f6mr16872823lah.85.1434712046034;
	Fri, 19 Jun 2015 04:07:26 -0700 (PDT)
MIME-Version: 1.0
In-Reply-To: <20150619075546.4284b164@kryten>
References: 
 <CAMXFM3t4CRSW2pRELmJMU5bE0eoYfUx7pO2-iLqLiGvgE79d_A@mail.gmail.com>
	<20150619075546.4284b164@kryten>
From: Andrew Senkevich <andrew.n.senkevich@gmail.com>
Date: Fri, 19 Jun 2015 14:06:55 +0300
Message-ID: 
 <CAMXFM3srg-a6+MJQ7btm-wMVUBazEif53EyHbnpv=+RCgAocvA@mail.gmail.com>
Subject: Re: [PATCH 13/14] [x86_64] Vector math functions (sincos and tests)
To: "Joseph S. Myers" <joseph@codesourcery.com>
Cc: libc-alpha <libc-alpha@sourceware.org>, sjmunroe@us.ibm.com,
	tuliom@linux.vnet.ibm.com, Anton Blanchard <anton@samba.org>

2015-06-19 0:55 GMT+03:00 Anton Blanchard <anton@samba.org>:
> Hi Andrew,
>
>> here is implementation of vectorized sincos containing SSE, AVX,
>> AVX2 and AVX512 versions according to Vector ABI
>> <https://groups.google.com/forum/#!topic/x86-64-abi/LmppCfN1rZ4>.
>
> This breaks powerpc64 builds, in sysdeps/ieee754/ldbl-opt/s_sin.c:
>
> #define sincos sincos_disable
>
> Which means we end up with:
>
> __DECL_SIMD_sincos_disable extern void sincos_disable (double __x,
> double *__sinx, double *__cosx) __attribute__ ((__nothrow__ )); extern void __sincos_disable (double __x, double *__sinx, double *__cosx) __attribute__ ((__nothrow__ ))
>                                                         ;
> Regards,
> Anton

Proposal is fix it so:


Ok?
---
WBR,
Andrew

diff --git a/bits/libm-simd-decl-stubs.h b/bits/libm-simd-decl-stubs.h
index ec1fa69..6d0558a 100644
--- a/bits/libm-simd-decl-stubs.h
+++ b/bits/libm-simd-decl-stubs.h
@@ -45,6 +45,10 @@
 #define __DECL_SIMD_sincosf
 #define __DECL_SIMD_sincosl

+/* This is needed because of definition of sincos
+   in sysdeps/ieee754/ldbl-opt/s_sin.c.  */
+# define __DECL_SIMD_sincos_disable
+
 #define __DECL_SIMD_log
 #define __DECL_SIMD_logf
 #define __DECL_SIMD_logl