From patchwork Fri Apr 11 19:35:45 2014 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Paul Pluzhnikov X-Patchwork-Id: 515 Return-Path: X-Original-To: siddhesh@wilcox.dreamhost.com Delivered-To: siddhesh@wilcox.dreamhost.com Received: from homiemail-mx21.g.dreamhost.com (peon2454.g.dreamhost.com [208.113.200.127]) by wilcox.dreamhost.com (Postfix) with ESMTP id E9342360078 for ; Fri, 11 Apr 2014 12:36:21 -0700 (PDT) Received: by homiemail-mx21.g.dreamhost.com (Postfix, from userid 14307373) id 8792811C9E85; Fri, 11 Apr 2014 12:36:21 -0700 (PDT) X-Original-To: glibc@patchwork.siddhesh.in Delivered-To: x14307373@homiemail-mx21.g.dreamhost.com Received: from sourceware.org (server1.sourceware.org [209.132.180.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by homiemail-mx21.g.dreamhost.com (Postfix) with ESMTPS id 4F52811C6D19 for ; Fri, 11 Apr 2014 12:36:21 -0700 (PDT) DomainKey-Signature: a=rsa-sha1; c=nofws; d=sourceware.org; h=list-id :list-unsubscribe:list-subscribe:list-archive:list-post :list-help:sender:mime-version:in-reply-to:references:from:date :message-id:subject:to:cc:content-type; q=dns; s=default; b=Z6nb RD9SOxCyFVYAomjkHKDHc+V9XCRzP1tmcoyHRX3cxtiz6WqZdk7W43+kRq5jlBiO 0YDl+motwWS7LRxdB1DZI+aDR0Nho8KS1Ui2VQPaGufcqs1bR3C06cw3w3b4lFGr SnGwvqu2S8sndub9oOCUJGxz+GqkePlOfoA9asw= DKIM-Signature: v=1; a=rsa-sha1; c=relaxed; d=sourceware.org; h=list-id :list-unsubscribe:list-subscribe:list-archive:list-post :list-help:sender:mime-version:in-reply-to:references:from:date :message-id:subject:to:cc:content-type; s=default; bh=4jOJHI3FFp bT1ELE8PrmSRO34i4=; b=JAv39/DEVPSHi5SAUJNLfke+6gnzIL6YAnZtjdO3z2 F+pVsmYc12x1wXGY4URidrEOsotb3Ta5vEZuT4Q5vo2Ub1VjZXs98i0PaFnLRqXI 2DShisYk0i+HpcOG170aA69eRp1xsFMIPd5B92xpUbsfNGC2BMvMVBKAulJqLt2g c= Received: (qmail 30085 invoked by alias); 11 Apr 2014 19:36:19 -0000 Mailing-List: contact libc-alpha-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Unsubscribe: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: libc-alpha-owner@sourceware.org Delivered-To: mailing list libc-alpha@sourceware.org Received: (qmail 30072 invoked by uid 89); 11 Apr 2014 19:36:18 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-2.8 required=5.0 tests=AWL, BAYES_00, RCVD_IN_DNSWL_LOW, RP_MATCHES_RCVD, SPF_PASS autolearn=ham version=3.3.2 X-HELO: mail-ie0-f174.google.com X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:mime-version:in-reply-to:references:from:date :message-id:subject:to:cc:content-type; bh=buA5BCojZuk4wBmOvqJXlBRIoSthKAXmVuUwZu8bcww=; b=elieYkxwbaZ0l8eaYN73dIm7jdW7i2tGI8s3Xy1+lVOuc5fJn4acC1RtWOIvB65bPY gwwkoJ/9++eSJGNb5lQdMF1/bIOzUUJn94uB8u6IzHAHPzbkaNtsk+S71RVbq+wptXxz liO4xi17O/yUqhyMNS2ipyb02KWQYtvtDf7lX9uxGGVanjuzl1GhsHibBgXGI0UsLwZW F7ANChV4mETaslWVhLH85/sgpA1QmLCk+UtvjnT/1Ehh8iSdGN6yJgr3KHJ7yeFNCMtL ZD0MvTHfujBg7buxgMprfunzLSOUxk+ruKvZpXE97HMzLGjg/DvmTvfs7IsexZoSczYe XEbQ== X-Gm-Message-State: ALoCoQlMvwMQfKZRTJOZaN93+uw5AVnFWcFNVGHuc+EwPqHGdolkN1GKUHpCfA+XnrzkfX9HxhwE8bJHawchsTQx0KRVVGDxpJeazbD0nJFZKMvRRHp+MKF8AqV+Mhmunru+7zc2MgYyOUhQCDU53Ep9cnv6K/1l44y6SWKCovXvhlA2x7U1UWelM2ofmvFWht8epIuV3Aie6JgJZPNQJBtLKm84Nkn65w== X-Received: by 10.50.126.106 with SMTP id mx10mr5903626igb.27.1397244975620; Fri, 11 Apr 2014 12:36:15 -0700 (PDT) MIME-Version: 1.0 In-Reply-To: <87k3aveq44.fsf@igel.home> References: <534731A1.3000503@redhat.com> <87k3aveq44.fsf@igel.home> From: Paul Pluzhnikov Date: Fri, 11 Apr 2014 12:35:45 -0700 Message-ID: Subject: Re: FAIL: elf/tst-dlopen-aout? To: Andreas Schwab Cc: "Carlos O'Donell" , GNU C Library X-DH-Original-To: glibc@patchwork.siddhesh.in On Fri, Apr 11, 2014 at 10:24 AM, Andreas Schwab wrote: > Paul Pluzhnikov writes: > >> That requires that I build a separate b.out, and try to dlopen it from >> tst-dlopen-aout. Unfortunately, I completely failed to understand the >> Makefile machinery to have a test that depends on another binary. > > Add it to the dependency list of the *.out file. I have added new source: elf/tst-dlopen-aout-helper.c, and modified elf/Makefile like so: ifneq ($(selinux-enabled),1) @@ -1060,6 +1057,8 @@ $(objpfx)tst-addr1: $(libdl) $(objpfx)tst-thrlock: $(libdl) $(shared-thread-library) $(objpfx)tst-dlopen-aout: $(libdl) $(shared-thread-library) +$(objpfx)tst-dlopen-aout.out: $(objpfx)tst-dlopen-aout-helper +# $(objpfx)tst-dlopen-aout-helper: tst-dlopen-aout-helper.c CFLAGS-ifuncmain1pic.c += $(pic-ccflag) CFLAGS-ifuncmain1picstatic.c += $(pic-ccflag) This produces make[1]: Leaving directory `/glibc/elf' make: *** No rule to make target `/build/elf/tst-dlopen-aout-helper', needed by `/build/elf/tst-dlopen-aout.out'. Stop. If I comment in this line: $(objpfx)tst-dlopen-aout-helper: tst-dlopen-aout-helper.c then there is no make error (but no tst-dlopen-aout-helper is linked either). I am utterly failing to understand why implicit rules aren't kicking in, or what I need to do to get tst-dlopen-aout-helper built. Help? Thanks, --- a/elf/Makefile +++ b/elf/Makefile @@ -148,11 +148,8 @@ tests += loadtest restest1 preloadtest loadfail multiload origtest resolvfail \ tst-stackguard1 tst-addr1 tst-thrlock \ tst-unique1 tst-unique2 tst-unique3 tst-unique4 \ tst-initorder tst-initorder2 tst-relsort1 tst-null-argv \ - tst-ptrguard1 + tst-ptrguard1 tst-dlopen-aout # reldep9 -ifeq ($(build-hardcoded-path-in-tests),yes) -tests += tst-dlopen-aout -endif test-srcs = tst-pathopt selinux-enabled := $(shell cat /selinux/enforce 2> /dev/null)