From patchwork Sun May 21 13:55:07 2017 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Zack Weinberg X-Patchwork-Id: 20524 Received: (qmail 21329 invoked by alias); 21 May 2017 13:55:10 -0000 Mailing-List: contact libc-alpha-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Unsubscribe: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: libc-alpha-owner@sourceware.org Delivered-To: mailing list libc-alpha@sourceware.org Received: (qmail 21310 invoked by uid 89); 21 May 2017 13:55:08 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-23.9 required=5.0 tests=AWL, BAYES_00, GIT_PATCH_0, GIT_PATCH_1, GIT_PATCH_2, GIT_PATCH_3, RCVD_IN_SORBS_SPAM, RP_MATCHES_RCVD, SPF_PASS autolearn=ham version=3.3.2 spammy= X-HELO: mailbackend.panix.com X-Gm-Message-State: AODbwcDFtEhZAYS9RKvesAjn+5dictaCW6TKcxsezKWdCU+4Xlgmo6IU aMEgCySJtYN69JSt1bT254MYW2WGZg== X-Received: by 10.36.131.137 with SMTP id d131mr18842575ite.113.1495374908497; Sun, 21 May 2017 06:55:08 -0700 (PDT) MIME-Version: 1.0 In-Reply-To: References: <20170520231823.20924-1-zackw@panix.com> <20170520231823.20924-3-zackw@panix.com> From: Zack Weinberg Date: Sun, 21 May 2017 09:55:07 -0400 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: [PATCH 2/6] Committed: Remove __need macros from signal.h. To: Andreas Schwab Cc: GNU C Library On Sun, May 21, 2017 at 3:19 AM, Andreas Schwab wrote: > > /usr/include/bits/types/siginfo_t.h:6:33: fatal error: bits/types/sigval_t.h: No such file or directory > #include Fixed by appended patch. Given the difficulty of test-installing glibc and then testing compilation with it, I would have appreciated somewhat more explanation of what the problem was, e.g. including the words "Any program that includes signal.h fails to compile against an installed glibc with this patch applied" in your message would have saved me from a couple of false leads. zw * signal/Makefile (headers): Add bits/types/sigval_t.h. --- ChangeLog | 4 ++++ signal/Makefile | 4 ++-- 2 files changed, 6 insertions(+), 2 deletions(-) diff --git a/ChangeLog b/ChangeLog index 62341b8ed3..ce060eb8de 100644 --- a/ChangeLog +++ b/ChangeLog @@ -1,3 +1,7 @@ +2017-05-21 Zack Weinberg + + * signal/Makefile (headers): Add bits/types/sigval_t.h. + 2017-05-20 Zack Weinberg * bits/sigevent-consts.h diff --git a/signal/Makefile b/signal/Makefile index de92558f2c..9ce8232d43 100644 --- a/signal/Makefile +++ b/signal/Makefile @@ -28,8 +28,8 @@ headers := signal.h sys/signal.h \ bits/sigstack.h bits/sigthread.h bits/ss_flags.h \ bits/types/__sigset_t.h bits/types/sig_atomic_t.h \ bits/types/sigevent_t.h bits/types/siginfo_t.h \ - bits/types/sigset_t.h bits/types/stack_t.h \ - bits/types/struct_sigstack.h + bits/types/sigset_t.h bits/types/sigval_t.h \ + bits/types/stack_t.h bits/types/struct_sigstack.h routines := signal raise killpg \ sigaction sigprocmask kill \