[BZ,15578] The kk_KZ locale update

  On Fri, Oct 30, 2015 at 9:46 PM, Mike Frysinger <vapier@gentoo.org> wrote:
> On 30 Oct 2015 14:57, Baurzhan Muftakhidinov wrote:
>> Please review the patch for Kazakh locale update,
>
> patches should be attached to e-mails sent here, not indirectly referenced
> -mike

I am sorry, I am not even an author of this patch

From e6a29f9d968c3818d4aa9525dc3e264cd70c53e1 Mon Sep 17 00:00:00 2001
From: Timur Birsh <taem@linukz.org>
Date: Thu, 30 May 2013 15:10:51 +0600
Subject: [PATCH] Update kk_KZ locale

---
 localedata/locales/kk_KZ |   98 ++++++++++++++++++++++++++++++----------------
 1 file changed, 64 insertions(+), 34 deletions(-)

 END LC_ADDRESS
  

Ping,

Dear Carlos, as commented in bugreport, FYI

Thanks,

On Fri, Oct 30, 2015 at 10:27 PM, Baurzhan Muftakhidinov
<baurthefirst@gmail.com> wrote:
> On Fri, Oct 30, 2015 at 9:46 PM, Mike Frysinger <vapier@gentoo.org> wrote:
>> On 30 Oct 2015 14:57, Baurzhan Muftakhidinov wrote:
>>> Please review the patch for Kazakh locale update,
>>
>> patches should be attached to e-mails sent here, not indirectly referenced
>> -mike
>
> I am sorry, I am not even an author of this patch
>
> From e6a29f9d968c3818d4aa9525dc3e264cd70c53e1 Mon Sep 17 00:00:00 2001
> From: Timur Birsh <taem@linukz.org>
> Date: Thu, 30 May 2013 15:10:51 +0600
> Subject: [PATCH] Update kk_KZ locale
>
> ---
>  localedata/locales/kk_KZ |   98 ++++++++++++++++++++++++++++++----------------
>  1 file changed, 64 insertions(+), 34 deletions(-)
>
> diff --git a/localedata/locales/kk_KZ b/localedata/locales/kk_KZ
> index cec3891..bb04203 100644
> --- a/localedata/locales/kk_KZ
> +++ b/localedata/locales/kk_KZ
> @@ -2,46 +2,46 @@ comment_char %
>  escape_char  /
>  %
>  % Kazakh Language Locale for Kazakhstan
> -% Source: NIPI, Kazakhstan Copper Corporation
> -% Address: 6, Gagarin, 477000, Zhezkazgan, Kazakhstan
> +% Source: linukz.org
> +% Address:
>  % Contact: Timur Birsh
> -% Email: birsh@mail.kz
> -% Tel: +7 (310-2) 74-80-12
> +% Email: taem@linukz.org
> +% Tel:
>  % Fax:
>  % Language: kk
>  % Territory: KZ
> -% Revision: 1.0
> -% Date: 2003-06-06
> +% Revision: 1.1
> +% Date: 2013-05-30
>  % Application: general
>  % Users: general
> -% Charset: PT154
> -% Distribution and use is free, also
> -% for commercial purposes.
> +% Charset: UTF-8
> +% License: Public Domain
>
>  LC_IDENTIFICATION
>  title      "Kazakh locale for Kazakhstan"
> -source     "NIPI, Kazakhstan Copper Corporation"
> +source     "linukz.org"
>  address    ""
> -contact    ""
> -email      "bug-glibc-locales@gnu.org"
> +contact    "Timur Birsh"
> +email      "libc-locales@sourceware.org"
>  tel        ""
>  fax        ""
>  language   "Kazakh"
>  territory  "Kazakhstan"
> -revision   "1.0"
> -date       "2003-06-06"
> +revision   "1.1"
> +date       "2013-05-30"
>  %
> -category  "kk_KZ:2000";LC_IDENTIFICATION
> -category  "kk_KZ:2000";LC_CTYPE
> -category  "kk_KZ:2000";LC_COLLATE
> -category  "kk_KZ:2000";LC_TIME
> -category  "kk_KZ:2000";LC_NUMERIC
> -category  "kk_KZ:2000";LC_MONETARY
> -category  "kk_KZ:2000";LC_MESSAGES
> -category  "kk_KZ:2000";LC_PAPER
> -category  "kk_KZ:2000";LC_NAME
> -category  "kk_KZ:2000";LC_ADDRESS
> -category  "kk_KZ:2000";LC_TELEPHONE
> +category  "i18n:2002";LC_IDENTIFICATION
> +category  "i18n:2002";LC_CTYPE
> +category  "i18n:2002";LC_COLLATE
> +category  "i18n:2002";LC_TIME
> +category  "i18n:2002";LC_NUMERIC
> +category  "i18n:2002";LC_MONETARY
> +category  "i18n:2002";LC_MESSAGES
> +category  "i18n:2002";LC_PAPER
> +category  "i18n:2002";LC_NAME
> +category  "i18n:2002";LC_ADDRESS
> +category  "i18n:2002";LC_TELEPHONE
> +category  "i18n:2002";LC_MEASUREMENT
>
>  END LC_IDENTIFICATION
>
> @@ -135,13 +135,13 @@ reorder-after <U0445>
>  reorder-after <U0425>
>  <U04BA> <CYR-SHHA>;<BAS>;<CAP>;IGNORE
>
> -reorder-after <CYR-I>
> +reorder-after <CYR-YEROU>
>  <CYR-BEL-UKR-I>
>
> -reorder-after <U0438>
> +reorder-after <U044B>
>  <U0456> <CYR-BEL-UKR-I>;<BAS>;<MIN>;IGNORE
>
> -reorder-after <U0418>
> +reorder-after <U042B>
>  <U0406> <CYR-BEL-UKR-I>;<BAS>;<CAP>;IGNORE
>
>  reorder-end
> @@ -163,24 +163,30 @@ END LC_MESSAGES
>  LC_MONETARY
>  int_curr_symbol           "<U004B><U005A><U0054><U0020>"
>  currency_symbol           "<U0442><U0433>"
> -mon_decimal_point         "<U002E>"
> -mon_thousands_sep         "<U0020>"
> +mon_decimal_point         "<U002C>"
> +mon_thousands_sep         "<U00A0>"
>  mon_grouping              3;3
>  positive_sign             ""
>  negative_sign             "<U002D>"
>  int_frac_digits           2
>  frac_digits               2
>  p_cs_precedes             0
> -p_sep_by_space            1
> +p_sep_by_space            2
>  n_cs_precedes             0
>  n_sep_by_space            1
>  p_sign_posn               1
>  n_sign_posn               1
> +int_p_cs_precedes         1
> +int_p_sep_by_space        2
> +int_n_cs_precedes         1
> +int_n_sep_by_space        1
> +int_p_sign_posn           4
> +int_n_sign_posn           4
>  END LC_MONETARY
>
>  LC_NUMERIC
>  decimal_point             "<U002C>"
> -thousands_sep             "<U002E>"
> +thousands_sep             "<U00A0>"
>  grouping                  3;3
>  END LC_NUMERIC
>
> @@ -232,6 +238,9 @@ t_fmt_ampm ""
>  date_fmt       "<U0025><U0061><U0020><U0025><U0062><U0020><U0025><U0065>/
>  <U0020><U0025><U0048><U003A><U0025><U004D><U003A><U0025><U0053><U0020>/
>  <U0025><U005A><U0020><U0025><U0059>"
> +week 7;19971201;4
> +first_weekday 2
> +first_workday 2
>  END LC_TIME
>
>  LC_PAPER
> @@ -242,17 +251,27 @@ END LC_PAPER
>  LC_TELEPHONE
>  tel_int_fmt    "<U002B><U0025><U0063><U0020><U0025><U0061><U0020><U0025>/
>  <U006C>"
> -int_prefix     "<U0037>"
> +tel_dom_fmt    "<U0028><U0025><U0041><U0029><U0020><U0025><U006C>"
> +int_prefix     "<U002B><U0037>"
> +int_select     "<U0038><U007E><U0031><U0030>"
>  END LC_TELEPHONE
>
>  LC_MEASUREMENT
> -% FIXME
> +% This is the ISO_IEC TR14652 Locale definition for the LC_MEASUREMENT
> +% 1 is ISO 1000 (metric)
> +%
>  measurement    1
>  END LC_MEASUREMENT
>
>  LC_NAME
> +% FIXME: operands should be filled with the correct values
>  name_fmt    "<U0025><U0064><U0025><U0074><U0025><U0067><U0025><U0074>/
>  <U0025><U006D><U0025><U0074><U0025><U0066>"
> +name_gen    ""
> +name_mr     ""
> +name_mrs    ""
> +name_miss   ""
> +name_ms     ""
>  END LC_NAME
>
>  LC_ADDRESS
> @@ -261,4 +280,15 @@ postal_fmt
> "<U0025><U0066><U0025><U004E><U0025><U0061><U0025><U004E>/
>  <U0020><U0025><U0068><U0020><U0025><U0065><U0020><U0025><U0072><U0025>/
>  <U004E><U0025><U007A><U0020><U0025><U0054><U0025>/
>  <U004E><U0025><U0063><U0025><U004E>"
> +country_name "<U049A><U0430><U0437><U0430><U049B><U0441><U0442><U0430>/
> +<U043D>"
> +country_post "<U004B><U0041><U005A>"
> +country_ab2 "<U004B><U005A>"
> +country_ab3 "<U004B><U0041><U005A>"
> +country_num 398
> +lang_name "<U049A><U0430><U0437><U0430><U049B><U0448><U0430>"
> +lang_ab "<U006B><U006B>"
> +lang_term "<U006B><U0061><U007A>"
> +country_isbn "<U0039><U0037><U0038><U002D><U0036><U0030><U0031>"
> +country_car "<U004B><U0041><U005A>"
>  END LC_ADDRESS
> --
> 1.7.10.4
  

Dear all,

Please review the changes of kk_KZ locale.
While it seems trivial, it is an important change for us.

Thanks,
https://www.sourceware.org/bugzilla/show_bug.cgi?id=15578

On Mon, Nov 2, 2015 at 9:27 AM, Baurzhan Muftakhidinov
<baurthefirst@gmail.com> wrote:
> Ping,
>
> Dear Carlos, as commented in bugreport, FYI
>
> Thanks,
>
> On Fri, Oct 30, 2015 at 10:27 PM, Baurzhan Muftakhidinov
> <baurthefirst@gmail.com> wrote:
>> On Fri, Oct 30, 2015 at 9:46 PM, Mike Frysinger <vapier@gentoo.org> wrote:
>>> On 30 Oct 2015 14:57, Baurzhan Muftakhidinov wrote:
>>>> Please review the patch for Kazakh locale update,
>>>
>>> patches should be attached to e-mails sent here, not indirectly referenced
>>> -mike
>>
>> I am sorry, I am not even an author of this patch
>>
>> From e6a29f9d968c3818d4aa9525dc3e264cd70c53e1 Mon Sep 17 00:00:00 2001
>> From: Timur Birsh <taem@linukz.org>
>> Date: Thu, 30 May 2013 15:10:51 +0600
>> Subject: [PATCH] Update kk_KZ locale
>>
>> ---
>>  localedata/locales/kk_KZ |   98 ++++++++++++++++++++++++++++++----------------
>>  1 file changed, 64 insertions(+), 34 deletions(-)
>>
>> diff --git a/localedata/locales/kk_KZ b/localedata/locales/kk_KZ
>> index cec3891..bb04203 100644
>> --- a/localedata/locales/kk_KZ
>> +++ b/localedata/locales/kk_KZ
>> @@ -2,46 +2,46 @@ comment_char %
>>  escape_char  /
>>  %
>>  % Kazakh Language Locale for Kazakhstan
>> -% Source: NIPI, Kazakhstan Copper Corporation
>> -% Address: 6, Gagarin, 477000, Zhezkazgan, Kazakhstan
>> +% Source: linukz.org
>> +% Address:
>>  % Contact: Timur Birsh
>> -% Email: birsh@mail.kz
>> -% Tel: +7 (310-2) 74-80-12
>> +% Email: taem@linukz.org
>> +% Tel:
>>  % Fax:
>>  % Language: kk
>>  % Territory: KZ
>> -% Revision: 1.0
>> -% Date: 2003-06-06
>> +% Revision: 1.1
>> +% Date: 2013-05-30
>>  % Application: general
>>  % Users: general
>> -% Charset: PT154
>> -% Distribution and use is free, also
>> -% for commercial purposes.
>> +% Charset: UTF-8
>> +% License: Public Domain
>>
>>  LC_IDENTIFICATION
>>  title      "Kazakh locale for Kazakhstan"
>> -source     "NIPI, Kazakhstan Copper Corporation"
>> +source     "linukz.org"
>>  address    ""
>> -contact    ""
>> -email      "bug-glibc-locales@gnu.org"
>> +contact    "Timur Birsh"
>> +email      "libc-locales@sourceware.org"
>>  tel        ""
>>  fax        ""
>>  language   "Kazakh"
>>  territory  "Kazakhstan"
>> -revision   "1.0"
>> -date       "2003-06-06"
>> +revision   "1.1"
>> +date       "2013-05-30"
>>  %
>> -category  "kk_KZ:2000";LC_IDENTIFICATION
>> -category  "kk_KZ:2000";LC_CTYPE
>> -category  "kk_KZ:2000";LC_COLLATE
>> -category  "kk_KZ:2000";LC_TIME
>> -category  "kk_KZ:2000";LC_NUMERIC
>> -category  "kk_KZ:2000";LC_MONETARY
>> -category  "kk_KZ:2000";LC_MESSAGES
>> -category  "kk_KZ:2000";LC_PAPER
>> -category  "kk_KZ:2000";LC_NAME
>> -category  "kk_KZ:2000";LC_ADDRESS
>> -category  "kk_KZ:2000";LC_TELEPHONE
>> +category  "i18n:2002";LC_IDENTIFICATION
>> +category  "i18n:2002";LC_CTYPE
>> +category  "i18n:2002";LC_COLLATE
>> +category  "i18n:2002";LC_TIME
>> +category  "i18n:2002";LC_NUMERIC
>> +category  "i18n:2002";LC_MONETARY
>> +category  "i18n:2002";LC_MESSAGES
>> +category  "i18n:2002";LC_PAPER
>> +category  "i18n:2002";LC_NAME
>> +category  "i18n:2002";LC_ADDRESS
>> +category  "i18n:2002";LC_TELEPHONE
>> +category  "i18n:2002";LC_MEASUREMENT
>>
>>  END LC_IDENTIFICATION
>>
>> @@ -135,13 +135,13 @@ reorder-after <U0445>
>>  reorder-after <U0425>
>>  <U04BA> <CYR-SHHA>;<BAS>;<CAP>;IGNORE
>>
>> -reorder-after <CYR-I>
>> +reorder-after <CYR-YEROU>
>>  <CYR-BEL-UKR-I>
>>
>> -reorder-after <U0438>
>> +reorder-after <U044B>
>>  <U0456> <CYR-BEL-UKR-I>;<BAS>;<MIN>;IGNORE
>>
>> -reorder-after <U0418>
>> +reorder-after <U042B>
>>  <U0406> <CYR-BEL-UKR-I>;<BAS>;<CAP>;IGNORE
>>
>>  reorder-end
>> @@ -163,24 +163,30 @@ END LC_MESSAGES
>>  LC_MONETARY
>>  int_curr_symbol           "<U004B><U005A><U0054><U0020>"
>>  currency_symbol           "<U0442><U0433>"
>> -mon_decimal_point         "<U002E>"
>> -mon_thousands_sep         "<U0020>"
>> +mon_decimal_point         "<U002C>"
>> +mon_thousands_sep         "<U00A0>"
>>  mon_grouping              3;3
>>  positive_sign             ""
>>  negative_sign             "<U002D>"
>>  int_frac_digits           2
>>  frac_digits               2
>>  p_cs_precedes             0
>> -p_sep_by_space            1
>> +p_sep_by_space            2
>>  n_cs_precedes             0
>>  n_sep_by_space            1
>>  p_sign_posn               1
>>  n_sign_posn               1
>> +int_p_cs_precedes         1
>> +int_p_sep_by_space        2
>> +int_n_cs_precedes         1
>> +int_n_sep_by_space        1
>> +int_p_sign_posn           4
>> +int_n_sign_posn           4
>>  END LC_MONETARY
>>
>>  LC_NUMERIC
>>  decimal_point             "<U002C>"
>> -thousands_sep             "<U002E>"
>> +thousands_sep             "<U00A0>"
>>  grouping                  3;3
>>  END LC_NUMERIC
>>
>> @@ -232,6 +238,9 @@ t_fmt_ampm ""
>>  date_fmt       "<U0025><U0061><U0020><U0025><U0062><U0020><U0025><U0065>/
>>  <U0020><U0025><U0048><U003A><U0025><U004D><U003A><U0025><U0053><U0020>/
>>  <U0025><U005A><U0020><U0025><U0059>"
>> +week 7;19971201;4
>> +first_weekday 2
>> +first_workday 2
>>  END LC_TIME
>>
>>  LC_PAPER
>> @@ -242,17 +251,27 @@ END LC_PAPER
>>  LC_TELEPHONE
>>  tel_int_fmt    "<U002B><U0025><U0063><U0020><U0025><U0061><U0020><U0025>/
>>  <U006C>"
>> -int_prefix     "<U0037>"
>> +tel_dom_fmt    "<U0028><U0025><U0041><U0029><U0020><U0025><U006C>"
>> +int_prefix     "<U002B><U0037>"
>> +int_select     "<U0038><U007E><U0031><U0030>"
>>  END LC_TELEPHONE
>>
>>  LC_MEASUREMENT
>> -% FIXME
>> +% This is the ISO_IEC TR14652 Locale definition for the LC_MEASUREMENT
>> +% 1 is ISO 1000 (metric)
>> +%
>>  measurement    1
>>  END LC_MEASUREMENT
>>
>>  LC_NAME
>> +% FIXME: operands should be filled with the correct values
>>  name_fmt    "<U0025><U0064><U0025><U0074><U0025><U0067><U0025><U0074>/
>>  <U0025><U006D><U0025><U0074><U0025><U0066>"
>> +name_gen    ""
>> +name_mr     ""
>> +name_mrs    ""
>> +name_miss   ""
>> +name_ms     ""
>>  END LC_NAME
>>
>>  LC_ADDRESS
>> @@ -261,4 +280,15 @@ postal_fmt
>> "<U0025><U0066><U0025><U004E><U0025><U0061><U0025><U004E>/
>>  <U0020><U0025><U0068><U0020><U0025><U0065><U0020><U0025><U0072><U0025>/
>>  <U004E><U0025><U007A><U0020><U0025><U0054><U0025>/
>>  <U004E><U0025><U0063><U0025><U004E>"
>> +country_name "<U049A><U0430><U0437><U0430><U049B><U0441><U0442><U0430>/
>> +<U043D>"
>> +country_post "<U004B><U0041><U005A>"
>> +country_ab2 "<U004B><U005A>"
>> +country_ab3 "<U004B><U0041><U005A>"
>> +country_num 398
>> +lang_name "<U049A><U0430><U0437><U0430><U049B><U0448><U0430>"
>> +lang_ab "<U006B><U006B>"
>> +lang_term "<U006B><U0061><U007A>"
>> +country_isbn "<U0039><U0037><U0038><U002D><U0036><U0030><U0031>"
>> +country_car "<U004B><U0041><U005A>"
>>  END LC_ADDRESS
>> --
>> 1.7.10.4
  

Hi,

On 2015-11-11 05:24, Baurzhan Muftakhidinov wrote:
> 
> Please review the changes of kk_KZ locale.
> While it seems trivial, it is an important change for us.
> 
> https://www.sourceware.org/bugzilla/show_bug.cgi?id=15578

I had a quick look at it:

- the patch doesn't apply
- I don't know the rationale for LC_IDENTIFICATION/category changes
- I'd rather leave titles in LC_NAME undefined than use empty strings
- I'd shorten the LC_MEASUREMENT comment, it should be obvious
- otherwise looks good but I didn't check every change in detail

Cheers,