[PING,3,BZ,#18265] Updated __nonnull annotations for wcscat, wcsncat, wcscmp and wcsncmp

Message ID CA180F4D0C023044AA10FB1BDCAC4D1F01736B6E@EX01.evidente.local
State Superseded
Headers

Commit Message

Daniel Marjamäki July 1, 2015, 1:42 p.m. UTC
  Hello!

This patch adds __nonnull annotations for wcscat, wcsncat, wcscmp and wcsncmp.

These added annotations match the annoations for strcat, strncat, strcmp, strncmp in glibc.

For information, I have completed the "copyright assignment form for glibc".

Please apply it.

Best regards,
Daniel Marjamäki

..................................................................................................................
Daniel Marjamäki Senior Engineer
Evidente ES East AB  Warfvinges väg 34  SE-112 51 Stockholm  Sweden

Mobile:                 +46 (0)709 12 42 62
E-mail:                 Daniel.Marjamaki@evidente.se

www.evidente.se
  

Patch

diff --git a/ChangeLog b/ChangeLog
index 8a6c668..a6ee799 100644
--- a/ChangeLog
+++ b/ChangeLog
@@ -1,3 +1,11 @@ 
+2015-07-01  Daniel Marjamäki  <daniel.marjamaki@evidente.se>
+
+       [BZ #18265]
+       * wcsmbs/wchar.h (wcscat): Add __nonnull attribute.
+       (wcsncat): Likewise.
+       (wcscmp): Likewise.
+       (wcsncmp): Likewise.
+
 2015-06-30  Torvald Riegel  <triegel@redhat.com>
 
 	* nptl/DESIGN-systemtap-probes.txt: Remove lll_lock_wait,
diff --git a/wcsmbs/wchar.h b/wcsmbs/wchar.h
index 0d68cda..10c1b5f 100644
--- a/wcsmbs/wchar.h
+++ b/wcsmbs/wchar.h
@@ -155,18 +155,19 @@  extern wchar_t *wcsncpy (wchar_t *__restrict __dest,
 
 /* Append SRC onto DEST.  */
 extern wchar_t *wcscat (wchar_t *__restrict __dest,
-			const wchar_t *__restrict __src) __THROW;
+			const wchar_t *__restrict __src)
+     __THROW __nonnull ((1, 2));
 /* Append no more than N wide-characters of SRC onto DEST.  */
 extern wchar_t *wcsncat (wchar_t *__restrict __dest,
 			 const wchar_t *__restrict __src, size_t __n)
-     __THROW;
+     __THROW __nonnull ((1, 2));
 
 /* Compare S1 and S2.  */
 extern int wcscmp (const wchar_t *__s1, const wchar_t *__s2)
-     __THROW __attribute_pure__;
+     __THROW __attribute_pure__ __nonnull ((1, 2));
 /* Compare N wide-characters of S1 and S2.  */
 extern int wcsncmp (const wchar_t *__s1, const wchar_t *__s2, size_t __n)
-     __THROW __attribute_pure__;
+     __THROW __attribute_pure__ __nonnull ((1, 2));
 __END_NAMESPACE_STD
 
 #ifdef __USE_XOPEN2K8