From patchwork Wed Dec 11 17:42:39 2019 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: Paul Eggert X-Patchwork-Id: 36722 Received: (qmail 20999 invoked by alias); 11 Dec 2019 17:42:42 -0000 Mailing-List: contact libc-alpha-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Unsubscribe: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: libc-alpha-owner@sourceware.org Delivered-To: mailing list libc-alpha@sourceware.org Received: (qmail 20989 invoked by uid 89); 11 Dec 2019 17:42:42 -0000 Authentication-Results: sourceware.org; auth=none X-Spam-SWARE-Status: No, score=-15.2 required=5.0 tests=AWL, BAYES_00, GIT_PATCH_0, GIT_PATCH_1, GIT_PATCH_2, GIT_PATCH_3, KAM_NUMSUBJECT, SPF_PASS autolearn=ham version=3.3.1 spammy=H*f:sk:aa4cdd1, H*f:sk:87h827p, H*MI:sk:87h827p, H*i:sk:87h827p X-HELO: zimbra.cs.ucla.edu Subject: Re: [PATCH] manual: fopen with the x flag does not follow ISO C11 To: Florian Weimer Cc: libc-alpha@sourceware.org References: <877e3571jh.fsf@oldenburg2.str.redhat.com> <5337dac7-77ad-85d2-e3ba-254e6f41e468@cs.ucla.edu> <87muc05q87.fsf@oldenburg2.str.redhat.com> <87h827p4rq.fsf@oldenburg2.str.redhat.com> From: Paul Eggert Message-ID: <8be178b8-01fa-6969-970b-10a2b7a01134@cs.ucla.edu> Date: Wed, 11 Dec 2019 09:42:39 -0800 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.2.2 MIME-Version: 1.0 In-Reply-To: <87h827p4rq.fsf@oldenburg2.str.redhat.com> On 12/11/19 1:53 AM, Florian Weimer wrote: > I'm not sure about the “common practice” part. This would need > checking. I would just drop it. Sure, that's fine. I installed the attached. I left the "ISO C11" vs "ISO C" issue for some later time. From ef4e158c736d067304164c3daa763e4f425af248 Mon Sep 17 00:00:00 2001 From: Paul Eggert Date: Wed, 11 Dec 2019 09:34:06 -0800 Subject: [PATCH] manual: clarify fopen with the x flag * manual/stdio.texi (Opening Streams): Say how glibc's implementation of fopen with "x" follows ISO C11. --- manual/stdio.texi | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/manual/stdio.texi b/manual/stdio.texi index bbd3061bab..8051603321 100644 --- a/manual/stdio.texi +++ b/manual/stdio.texi @@ -216,7 +216,9 @@ exists, @code{fopen} fails rather than opening it. If you use file. This is equivalent to the @code{O_EXCL} option to the @code{open} function (@pxref{Opening and Closing Files}). -The @samp{x} modifier is part of @w{ISO C11}. +The @samp{x} modifier is part of @w{ISO C11}, which says the file is +created with exclusive access; in @theglibc{} this means the +equivalent of @code{O_EXCL}. @end table The character @samp{b} in @var{opentype} has a standard meaning; it -- 2.23.0