From patchwork Thu Dec 22 15:00:29 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Florian Weimer X-Patchwork-Id: 62264 Return-Path: X-Original-To: patchwork@sourceware.org Delivered-To: patchwork@sourceware.org Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id A73CE3858298 for ; Thu, 22 Dec 2022 15:00:54 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org A73CE3858298 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=sourceware.org; s=default; t=1671721254; bh=rp+qjIdP8iNVTWu9z7hs1yTVGH/lhm+HUMUUhjd6PrE=; h=To:Cc:Subject:Date:List-Id:List-Unsubscribe:List-Archive: List-Post:List-Help:List-Subscribe:From:Reply-To:From; b=LcLDTchnfX3vD03zws5SIEtwdZm5Ga371MGGg1E7giXDvFm/kSYSMAv2T5HoU8z0Z mTvQOYOxfQs6u1ua4EWLIY1HM725jw3F4I78Fiz/IS9LtN4vJGHC7Cl46eUIwMAzBf Wte4xzWxOuG7NvVDNLxZ6uaA/NcSmK0iWwIXrB8w= X-Original-To: libc-alpha@sourceware.org Delivered-To: libc-alpha@sourceware.org Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by sourceware.org (Postfix) with ESMTPS id 941953858D1E for ; Thu, 22 Dec 2022 15:00:33 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 941953858D1E Received: from mimecast-mx02.redhat.com (mimecast-mx02.redhat.com [66.187.233.88]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-108-zcQjlswvMWy3Rvxp2lDGCA-1; Thu, 22 Dec 2022 10:00:32 -0500 X-MC-Unique: zcQjlswvMWy3Rvxp2lDGCA-1 Received: from smtp.corp.redhat.com (int-mx08.intmail.prod.int.rdu2.redhat.com [10.11.54.8]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id A6ACF85CBCE; Thu, 22 Dec 2022 15:00:31 +0000 (UTC) Received: from oldenburg.str.redhat.com (unknown [10.2.16.27]) by smtp.corp.redhat.com (Postfix) with ESMTPS id EFC41C16028; Thu, 22 Dec 2022 15:00:30 +0000 (UTC) To: libc-alpha@sourceware.org Cc: Adhemerval Zanella , Carlos O'Donell Subject: [PATCH] Linux: Pass size argument of epoll_create to the kernel Date: Thu, 22 Dec 2022 16:00:29 +0100 Message-ID: <87y1qzmqk2.fsf@oldenburg.str.redhat.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.1 (gnu/linux) MIME-Version: 1.0 X-Scanned-By: MIMEDefang 3.1 on 10.11.54.8 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com X-Spam-Status: No, score=-10.6 required=5.0 tests=BAYES_00, DKIMWL_WL_HIGH, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, GIT_PATCH_0, RCVD_IN_DNSWL_NONE, RCVD_IN_MSPIKE_H2, SPF_HELO_NONE, SPF_NONE, TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org X-BeenThere: libc-alpha@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Libc-alpha mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-Patchwork-Original-From: Florian Weimer via Libc-alpha From: Florian Weimer Reply-To: Florian Weimer Errors-To: libc-alpha-bounces+patchwork=sourceware.org@sourceware.org Sender: "Libc-alpha" The kernel actually verifies it, and a garbage value in the register causes improper system call failures. Fixes commit c1c0dea38833751f36a145c32 ("Linux: Remove epoll_create, inotify_init from syscalls.list") and commit d1d23b134244d59c4d6ef2295 ("Lninux: consolidate epoll_create implementation"). Tested on i686-linux-gnu, x86_64-linux-gnu. Reviewed-by: Carlos O'Donell --- sysdeps/unix/sysv/linux/epoll_create.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) base-commit: e2b68828fab4fdfa5595fa89180230cdc4373ec1 diff --git a/sysdeps/unix/sysv/linux/epoll_create.c b/sysdeps/unix/sysv/linux/epoll_create.c index afb1921637..cb6a67e602 100644 --- a/sysdeps/unix/sysv/linux/epoll_create.c +++ b/sysdeps/unix/sysv/linux/epoll_create.c @@ -25,7 +25,7 @@ int epoll_create (int size) { #ifdef __NR_epoll_create - return INLINE_SYSCALL_CALL (epoll_create); + return INLINE_SYSCALL_CALL (epoll_create, size); #else if (size <= 0) {