build-many-glibcs.py: Add x86_64-linux-gnu-minimal configuration
Checks
Context |
Check |
Description |
dj/TryBot-apply_patch |
success
|
Patch applied to master at the time it was sent
|
Commit Message
This configuration exercises various --disable-* configure options.
It is expected to catch -Werror failures that only affect these
configurations.
---
scripts/build-many-glibcs.py | 9 +++++++++
1 file changed, 9 insertions(+)
Comments
On 7/23/21 2:56 PM, Florian Weimer via Libc-alpha wrote:
> This configuration exercises various --disable-* configure options.
> It is expected to catch -Werror failures that only affect these
> configurations.
>
> ---
> scripts/build-many-glibcs.py | 9 +++++++++
> 1 file changed, 9 insertions(+)
>
> diff --git a/scripts/build-many-glibcs.py b/scripts/build-many-glibcs.py
> index 6643bb6e92..6539ab76cb 100755
> --- a/scripts/build-many-glibcs.py
> +++ b/scripts/build-many-glibcs.py
> @@ -425,6 +425,15 @@ class Context(object):
> {'arch': 'i686', 'ccopts': '-m32 -march=i686'}],
> extra_glibcs=[{'variant': 'disable-multi-arch',
> 'cfg': ['--disable-multi-arch']},
> + {'variant': 'minimal',
> + 'cfg': ['--disable-multi-arch',
> + '--disable-profile',
> + '--disable-timezone-tools',
> + '--disable-mathvec',
> + '--enable-tunables=no',
There is a --disable-tunables too which works the same and looks
prettier in that context ;)
> + '--disable-crypt',
> + '--disable-build-nscd',
> + '--disable-nscd']},
The INSTALL lists --disable-scv and --disable-experimental-malloc too.
As an aside, maybe we should graduate tcache from being 'experimental'
to being more permanent in 2.35 and then make this option nop.
> {'variant': 'static-pie',
> 'cfg': ['--enable-static-pie']},
> {'variant': 'x32-static-pie',
>
* Siddhesh Poyarekar:
> On 7/23/21 2:56 PM, Florian Weimer via Libc-alpha wrote:
>> This configuration exercises various --disable-* configure options.
>> It is expected to catch -Werror failures that only affect these
>> configurations.
>> ---
>> scripts/build-many-glibcs.py | 9 +++++++++
>> 1 file changed, 9 insertions(+)
>> diff --git a/scripts/build-many-glibcs.py
>> b/scripts/build-many-glibcs.py
>> index 6643bb6e92..6539ab76cb 100755
>> --- a/scripts/build-many-glibcs.py
>> +++ b/scripts/build-many-glibcs.py
>> @@ -425,6 +425,15 @@ class Context(object):
>> {'arch': 'i686', 'ccopts': '-m32 -march=i686'}],
>> extra_glibcs=[{'variant': 'disable-multi-arch',
>> 'cfg': ['--disable-multi-arch']},
>> + {'variant': 'minimal',
>> + 'cfg': ['--disable-multi-arch',
>> + '--disable-profile',
>> + '--disable-timezone-tools',
>> + '--disable-mathvec',
>> + '--enable-tunables=no',
>
> There is a --disable-tunables too which works the same and looks
> prettier in that context ;)
It's not documented, but I can use it still.
>> + '--disable-crypt',
>> + '--disable-build-nscd',
>> + '--disable-nscd']},
>
> The INSTALL lists --disable-scv and --disable-experimental-malloc
> too. As an aside, maybe we should graduate tcache from being
> 'experimental' to being more permanent in 2.35 and then make this
> option nop.
--disable-scv isn't about minimization. I forgot that
--disable-experimental-malloc controls tcache.
I'm going to send an updated patch.
Thanks,
Florian
@@ -425,6 +425,15 @@ class Context(object):
{'arch': 'i686', 'ccopts': '-m32 -march=i686'}],
extra_glibcs=[{'variant': 'disable-multi-arch',
'cfg': ['--disable-multi-arch']},
+ {'variant': 'minimal',
+ 'cfg': ['--disable-multi-arch',
+ '--disable-profile',
+ '--disable-timezone-tools',
+ '--disable-mathvec',
+ '--enable-tunables=no',
+ '--disable-crypt',
+ '--disable-build-nscd',
+ '--disable-nscd']},
{'variant': 'static-pie',
'cfg': ['--enable-static-pie']},
{'variant': 'x32-static-pie',