Linux: Include <dl-symbol-redir-ifunc.h> in dl-sysdep.c

Message ID 87tthr1cly.fsf@oldenburg.str.redhat.com
State Committed
Commit f6ea5d1291cf3f264514d03872ebae84e0293b69
Headers
Series Linux: Include <dl-symbol-redir-ifunc.h> in dl-sysdep.c |

Checks

Context Check Description
redhat-pt-bot/TryBot-apply_patch success Patch applied to master at the time it was sent
redhat-pt-bot/TryBot-32bit success Build for i686
linaro-tcwg-bot/tcwg_glibc_build--master-aarch64 success Build passed
linaro-tcwg-bot/tcwg_glibc_check--master-aarch64 success Test passed
linaro-tcwg-bot/tcwg_glibc_build--master-arm success Build passed
linaro-tcwg-bot/tcwg_glibc_check--master-arm success Test passed

Commit Message

Florian Weimer June 17, 2024, 9:30 p.m. UTC
  The _dl_sysdep_parse_arguments function contains initalization
of a large on-stack variable:

  dl_parse_auxv_t auxv_values = { 0, };

This uses a non-inline version of memset on powerpc64le-linux-gnu,
so it must use the baseline memset.

---
 sysdeps/unix/sysv/linux/dl-sysdep.c | 1 +
 1 file changed, 1 insertion(+)


base-commit: 55eb99e9a9d840ba452b128be14d6529c2dde039
  

Comments

Andreas Schwab June 18, 2024, 8:36 a.m. UTC | #1
On Jun 17 2024, Florian Weimer wrote:

> The _dl_sysdep_parse_arguments function contains initalization
> of a large on-stack variable:
>
>   dl_parse_auxv_t auxv_values = { 0, };
>
> This uses a non-inline version of memset on powerpc64le-linux-gnu,
> so it must use the baseline memset.

Ok.
  

Patch

diff --git a/sysdeps/unix/sysv/linux/dl-sysdep.c b/sysdeps/unix/sysv/linux/dl-sysdep.c
index e1b14e9eb3..a8ec2d7c18 100644
--- a/sysdeps/unix/sysv/linux/dl-sysdep.c
+++ b/sysdeps/unix/sysv/linux/dl-sysdep.c
@@ -40,6 +40,7 @@ 
 #include <sys/utsname.h>
 #include <tls.h>
 #include <unistd.h>
+#include <dl-symbol-redir-ifunc.h>
 
 #include <dl-machine.h>
 #include <dl-hwcap-check.h>