powerpc64le: Also avoid IFUNC for __mempcpy_power7

Message ID 87tt9c9xto.fsf@oldenburg.str.redhat.com (mailing list archive)
State Committed
Commit 3755ffb665ab544396d871c517a218d863f1cf52
Headers
Series powerpc64le: Also avoid IFUNC for __mempcpy_power7 |

Checks

Context Check Description
redhat-pt-bot/TryBot-apply_patch success Patch applied to master at the time it was sent
linaro-tcwg-bot/tcwg_glibc_build--master-aarch64 success Build passed
redhat-pt-bot/TryBot-32bit success Build for i686
linaro-tcwg-bot/tcwg_glibc_check--master-aarch64 success Test passed
linaro-tcwg-bot/tcwg_glibc_build--master-arm success Build passed
linaro-tcwg-bot/tcwg_glibc_check--master-arm success Test passed

Commit Message

Florian Weimer Feb. 2, 2025, 3:21 p.m. UTC
  Code used during early static startup in elf/dl-tls.c uses
__mempcpy.

Fixes commit cbd9fd236981717d3d4ee942986ea912e9707c32 ("Consolidate
TLS block allocation for static binaries with ld.so").

---
 sysdeps/powerpc/powerpc64/le/multiarch/dl-symbol-redir-ifunc.h | 1 +
 1 file changed, 1 insertion(+)
  

Comments

Adhemerval Zanella Netto Feb. 3, 2025, 1:03 p.m. UTC | #1
On 02/02/25 12:21, Florian Weimer wrote:
> Code used during early static startup in elf/dl-tls.c uses
> __mempcpy.
> 
> Fixes commit cbd9fd236981717d3d4ee942986ea912e9707c32 ("Consolidate
> TLS block allocation for static binaries with ld.so").

LGTM, thanks.

Reviewed-by: Adhemerval Zanella  <adhemerval.zanella@linaro.org>

> 
> ---
>  sysdeps/powerpc/powerpc64/le/multiarch/dl-symbol-redir-ifunc.h | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/sysdeps/powerpc/powerpc64/le/multiarch/dl-symbol-redir-ifunc.h b/sysdeps/powerpc/powerpc64/le/multiarch/dl-symbol-redir-ifunc.h
> index e559ab03e3..93276e1578 100644
> --- a/sysdeps/powerpc/powerpc64/le/multiarch/dl-symbol-redir-ifunc.h
> +++ b/sysdeps/powerpc/powerpc64/le/multiarch/dl-symbol-redir-ifunc.h
> @@ -20,5 +20,6 @@
>  #define _DL_IFUNC_GENERIC_H
>  
>  asm ("memset = __memset_power8");
> +asm ("__mempcpy = __mempcpy_power7");
>  
>  #endif
>
  
Peter Bergner Feb. 7, 2025, 8:34 p.m. UTC | #2
On 2/3/25 7:03 AM, Adhemerval Zanella Netto wrote:
> On 02/02/25 12:21, Florian Weimer wrote:
>> Code used during early static startup in elf/dl-tls.c uses
>> __mempcpy.
>>
>> Fixes commit cbd9fd236981717d3d4ee942986ea912e9707c32 ("Consolidate
>> TLS block allocation for static binaries with ld.so").
> 
> LGTM, thanks.
> 
> Reviewed-by: Adhemerval Zanella  <adhemerval.zanella@linaro.org>

I just returned from vacation, but LGTM too.  Thanks for reviewing Adhemerval!

Peter
  

Patch

diff --git a/sysdeps/powerpc/powerpc64/le/multiarch/dl-symbol-redir-ifunc.h b/sysdeps/powerpc/powerpc64/le/multiarch/dl-symbol-redir-ifunc.h
index e559ab03e3..93276e1578 100644
--- a/sysdeps/powerpc/powerpc64/le/multiarch/dl-symbol-redir-ifunc.h
+++ b/sysdeps/powerpc/powerpc64/le/multiarch/dl-symbol-redir-ifunc.h
@@ -20,5 +20,6 @@ 
 #define _DL_IFUNC_GENERIC_H
 
 asm ("memset = __memset_power8");
+asm ("__mempcpy = __mempcpy_power7");
 
 #endif