INSTALL: Rephrase -with-default-link documentation
Checks
Context |
Check |
Description |
dj/TryBot-apply_patch |
success
|
Patch applied to master at the time it was sent
|
dj/TryBot-32bit |
success
|
Build for i686
|
Commit Message
---
INSTALL | 8 ++++----
manual/install.texi | 10 +++++-----
2 files changed, 9 insertions(+), 9 deletions(-)
Comments
On 4/22/22 06:27, Florian Weimer via Libc-alpha wrote:
LGTM. Double checked --with-default-link (use-default-link=yes) and
--without-default-link (use-default-link=no)
Reviewed-by: Carlos O'Donell <carlos@redhat.com>
> ---
> INSTALL | 8 ++++----
> manual/install.texi | 10 +++++-----
> 2 files changed, 9 insertions(+), 9 deletions(-)
>
> diff --git a/INSTALL b/INSTALL
> index b68884ccd6..237a2f9482 100644
> --- a/INSTALL
> +++ b/INSTALL
> @@ -90,10 +90,10 @@ if 'CFLAGS' is specified it must enable optimization. For example:
> library will still be usable, but functionality may be lost--for
> example, you can't build a shared libc with old binutils.
>
> -'--with-default-link=FLAG'
> - With '--with-default-link=yes', the build system does not use a
> - custom linker script for linking shared objects. The default for
> - FLAG is the opposite, 'no', because the custom linker script is
> +'--with-default-link'
> + With '--with-default-link', the build system does not use a custom
> + linker script for linking shared objects. The default is
> + '--without-default-link', because the custom linker script is
> needed for full RELRO protection.
>
> '--with-nonshared-cflags=CFLAGS'
> diff --git a/manual/install.texi b/manual/install.texi
> index fcfb6901e4..5feccfb6ed 100644
> --- a/manual/install.texi
> +++ b/manual/install.texi
> @@ -117,11 +117,11 @@ problem and suppress these constructs, so that the library will still be
> usable, but functionality may be lost---for example, you can't build a
> shared libc with old binutils.
>
> -@item --with-default-link=@var{FLAG}
> -With @code{--with-default-link=yes}, the build system does not use a
> -custom linker script for linking shared objects. The default for
> -@var{FLAG} is the opposite, @samp{no}, because the custom linker script
> -is needed for full RELRO protection.
> +@item --with-default-link
> +With @code{--with-default-link}, the build system does not use a custom
> +linker script for linking shared objects. The default is
> +@code{--without-default-link}, because the custom linker script is
> +needed for full RELRO protection.
>
> @item --with-nonshared-cflags=@var{cflags}
> Use additional compiler flags @var{cflags} to build the parts of the
>
@@ -90,10 +90,10 @@ if 'CFLAGS' is specified it must enable optimization. For example:
library will still be usable, but functionality may be lost--for
example, you can't build a shared libc with old binutils.
-'--with-default-link=FLAG'
- With '--with-default-link=yes', the build system does not use a
- custom linker script for linking shared objects. The default for
- FLAG is the opposite, 'no', because the custom linker script is
+'--with-default-link'
+ With '--with-default-link', the build system does not use a custom
+ linker script for linking shared objects. The default is
+ '--without-default-link', because the custom linker script is
needed for full RELRO protection.
'--with-nonshared-cflags=CFLAGS'
@@ -117,11 +117,11 @@ problem and suppress these constructs, so that the library will still be
usable, but functionality may be lost---for example, you can't build a
shared libc with old binutils.
-@item --with-default-link=@var{FLAG}
-With @code{--with-default-link=yes}, the build system does not use a
-custom linker script for linking shared objects. The default for
-@var{FLAG} is the opposite, @samp{no}, because the custom linker script
-is needed for full RELRO protection.
+@item --with-default-link
+With @code{--with-default-link}, the build system does not use a custom
+linker script for linking shared objects. The default is
+@code{--without-default-link}, because the custom linker script is
+needed for full RELRO protection.
@item --with-nonshared-cflags=@var{cflags}
Use additional compiler flags @var{cflags} to build the parts of the