<signal.h>: Add deprecation message for sigpause

Message ID 87r0x4ucke.fsf@oldenburg.str.redhat.com
State New
Headers
Series <signal.h>: Add deprecation message for sigpause |

Checks

Context Check Description
dj/TryBot-apply_patch success Patch applied to master at the time it was sent
dj/TryBot-32bit success Build for i686

Commit Message

Florian Weimer Dec. 12, 2022, 10:43 a.m. UTC
  Current compilers merely issue an implicit function declaration warning
without -D_XOPEN_SOURCE_EXTENDED, which is not very illuminating.

Tested on i686-linux-gnu and x86_64-linux-gnu.

---
 signal/signal.h | 3 +++
 1 file changed, 3 insertions(+)


base-commit: 4e21c2075193e406a92c0d1cb091a7c804fda4d9
  

Comments

Florian Weimer Jan. 5, 2023, 5:25 p.m. UTC | #1
* Florian Weimer via Libc-alpha:

> Current compilers merely issue an implicit function declaration warning
> without -D_XOPEN_SOURCE_EXTENDED, which is not very illuminating.
>
> Tested on i686-linux-gnu and x86_64-linux-gnu.
>
> ---
>  signal/signal.h | 3 +++
>  1 file changed, 3 insertions(+)
>
> diff --git a/signal/signal.h b/signal/signal.h
> index 78d0d819aa..1299d7e0bc 100644
> --- a/signal/signal.h
> +++ b/signal/signal.h
> @@ -155,6 +155,9 @@ extern int __sigpause (int __sig_or_mask, int __is_sig);
>  /* Remove a signal from the signal mask and suspend the process.  */
>  #  define sigpause(sig) __sigpause ((sig), 1)
>  # endif
> +#elif defined __USE_MISC
> +extern int sigpause (int __sig)
> +  __attribute_deprecated_msg__ ("Use the sigsuspend function instead");
>  #endif

Ping?

  <https://sourceware.org/pipermail/libc-alpha/2022-December/143977.html>

Thanks,
Florian
  

Patch

diff --git a/signal/signal.h b/signal/signal.h
index 78d0d819aa..1299d7e0bc 100644
--- a/signal/signal.h
+++ b/signal/signal.h
@@ -155,6 +155,9 @@  extern int __sigpause (int __sig_or_mask, int __is_sig);
 /* Remove a signal from the signal mask and suspend the process.  */
 #  define sigpause(sig) __sigpause ((sig), 1)
 # endif
+#elif defined __USE_MISC
+extern int sigpause (int __sig)
+  __attribute_deprecated_msg__ ("Use the sigsuspend function instead");
 #endif