From patchwork Mon Oct 26 16:28:46 2015 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: Thomas Schwinge X-Patchwork-Id: 9382 Received: (qmail 19870 invoked by alias); 26 Oct 2015 16:29:05 -0000 Mailing-List: contact libc-alpha-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Unsubscribe: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: libc-alpha-owner@sourceware.org Delivered-To: mailing list libc-alpha@sourceware.org Received: (qmail 19732 invoked by uid 89); 26 Oct 2015 16:29:04 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-2.3 required=5.0 tests=AWL, BAYES_00, RCVD_IN_DNSWL_LOW, SPF_PASS autolearn=unavailable version=3.3.2 X-HELO: relay1.mentorg.com From: Thomas Schwinge To: , CC: , , , Andreas Schwab , Jakub Jelinek Subject: Re: abort might not flush all open streams before process termination (was: aarch64-suse-linux-gnu: libgomp.oacc-c-c++-common/abort-1.c, libgomp.oacc-c-c++-common/abort-3.c FAILs) In-Reply-To: <871td7ouju.fsf@kepler.schwinge.homeip.net> References: <560e717f.+EOSyvrXa02mQ6Bg%schwab@linux-m68k.org> <87twq4p9f4.fsf@kepler.schwinge.homeip.net> <87oagcp6kc.fsf@kepler.schwinge.homeip.net> <871td7ouju.fsf@kepler.schwinge.homeip.net> User-Agent: Notmuch/0.9-125-g4686d11 (http://notmuchmail.org) Emacs/24.5.1 (i586-pc-linux-gnu) Date: Mon, 26 Oct 2015 17:28:46 +0100 Message-ID: <87pp017fwh.fsf@kepler.schwinge.homeip.net> MIME-Version: 1.0 Hi! On Wed, 7 Oct 2015 12:13:41 +0200, I wrote: > Copying glibc for your information/in case anyone has any further > comments, and the man-pages maintainer, Michael Kerrisk. The issue is > that abort might not flush all open streams before process termination; > original thread starting at > . > > On Tue, 06 Oct 2015 13:55:00 +0200, Andreas Schwab wrote: > > Thomas Schwinge writes: > > > > > | The two regressed test cases use __builtin_printf instead of fprintf to > > > | stderr, but as far as I know, abort is to flush all open streams before > > > | process termination? > > > > It can't, since abort must be async-signal-safe. > > It's still surprising to me that the message written to stderr is lost in > your aarch64-suse-linux-gnu configuration (only): from a quick look, > (current) glibc's stdlib/abort.c tries to actually close/flush all open > streams before process termination. That's , Andreas told us. > This is also what's documented on > : "all open streams > are closed and flushed". > > does sound more "conservative": "[abort] may include an attempt to effect > fclose() on all open streams". Should the man-page be edited to that > effect? And, the following patch be applied to GCC? I convince myself that the GCC patch was obvious enough; committed in r229382: commit 005c2a97673312fa25486a70bd810b9a1b37d367 Author: tschwinge Date: Mon Oct 26 16:25:04 2015 +0000 abort might not flush all open streams before process termination libgomp/ * testsuite/libgomp.oacc-c-c++-common/abort-1.c: Print to stderr. * testsuite/libgomp.oacc-c-c++-common/abort-3.c: Likewise. git-svn-id: svn+ssh://gcc.gnu.org/svn/gcc/trunk@229382 138bc75d-0d04-0410-961f-82ee72b054a4 --- libgomp/ChangeLog | 3 +++ libgomp/testsuite/libgomp.oacc-c-c++-common/abort-1.c | 3 ++- libgomp/testsuite/libgomp.oacc-c-c++-common/abort-3.c | 3 ++- 3 files changed, 7 insertions(+), 2 deletions(-) Grüße Thomas diff --git libgomp/ChangeLog libgomp/ChangeLog index fa9027b..afc49ae 100644 --- libgomp/ChangeLog +++ libgomp/ChangeLog @@ -1,5 +1,8 @@ 2015-10-26 Thomas Schwinge + * testsuite/libgomp.oacc-c-c++-common/abort-1.c: Print to stderr. + * testsuite/libgomp.oacc-c-c++-common/abort-3.c: Likewise. + * testsuite/libgomp.oacc-c-c++-common/lib-1.c: Remove explicit acc_device_nvidia usage. * testsuite/libgomp.oacc-c-c++-common/lib-10.c: Likewise. diff --git libgomp/testsuite/libgomp.oacc-c-c++-common/abort-1.c libgomp/testsuite/libgomp.oacc-c-c++-common/abort-1.c index 6a9b1df..296708f 100644 --- libgomp/testsuite/libgomp.oacc-c-c++-common/abort-1.c +++ libgomp/testsuite/libgomp.oacc-c-c++-common/abort-1.c @@ -1,11 +1,12 @@ /* { dg-do run } */ +#include #include int main (void) { - __builtin_printf ("CheCKpOInT\n"); + fprintf (stderr, "CheCKpOInT\n"); #pragma acc parallel { abort (); diff --git libgomp/testsuite/libgomp.oacc-c-c++-common/abort-3.c libgomp/testsuite/libgomp.oacc-c-c++-common/abort-3.c index 2c8f347..bca425e 100644 --- libgomp/testsuite/libgomp.oacc-c-c++-common/abort-3.c +++ libgomp/testsuite/libgomp.oacc-c-c++-common/abort-3.c @@ -1,11 +1,12 @@ /* { dg-do run } */ +#include #include int main (void) { - __builtin_printf ("CheCKpOInT\n"); + fprintf (stderr, "CheCKpOInT\n"); #pragma acc kernels { abort ();