From patchwork Fri Dec 23 18:33:29 2016 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Tulio Magno Quites Machado Filho X-Patchwork-Id: 18668 Received: (qmail 46916 invoked by alias); 23 Dec 2016 18:33:55 -0000 Mailing-List: contact libc-alpha-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Unsubscribe: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: libc-alpha-owner@sourceware.org Delivered-To: mailing list libc-alpha@sourceware.org Received: (qmail 46838 invoked by uid 89); 23 Dec 2016 18:33:55 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-1.6 required=5.0 tests=BAYES_00, KAM_LAZY_DOMAIN_SECURITY, RCVD_IN_DNSWL_LOW autolearn=no version=3.3.2 spammy=sk:libc_hi, __typeof X-HELO: mx0a-001b2d01.pphosted.com From: "Tulio Magno Quites Machado Filho" To: Richard Henderson , libc-alpha@sourceware.org Cc: Subject: Re: [PATCH v2 05/16] Improve generic memchr In-Reply-To: <20161221230605.28638-6-rth@twiddle.net> References: <20161221230605.28638-1-rth@twiddle.net> <20161221230605.28638-6-rth@twiddle.net> User-Agent: Notmuch/0.20.2 (http://notmuchmail.org) Emacs/24.4.51.1 (x86_64-unknown-linux-gnu) Date: Fri, 23 Dec 2016 16:33:29 -0200 MIME-Version: 1.0 X-TM-AS-MML: disable X-Content-Scanned: Fidelis XPS MAILER x-cbid: 16122318-0028-0000-0000-0000017F11CF X-IBM-AV-DETECTION: SAVI=unused REMOTE=unused XFE=unused x-cbparentid: 16122318-0029-0000-0000-0000147B6567 Message-Id: <87mvfmcx6u.fsf@linux.vnet.ibm.com> X-Proofpoint-Virus-Version: vendor=fsecure engine=2.50.10432:, , definitions=2016-12-23_15:, , signatures=0 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 spamscore=0 suspectscore=0 malwarescore=0 phishscore=0 adultscore=0 bulkscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.0.1-1612050000 definitions=main-1612230297 Richard Henderson writes: > -#ifdef weak_alias > + > +#ifndef MEMCHR > weak_alias (__memchr, memchr) > -#endif > libc_hidden_builtin_def (memchr) > +#endif If you make this change, you also have to make the following change. LGTM with it. diff --git a/sysdeps/powerpc/powerpc32/power4/multiarch/memchr-ppc32.c b/sysdeps/powerpc/powerpc32/power4/multiarch/memchr-ppc32.c index 9861337..6faf996 100644 --- a/sysdeps/powerpc/powerpc32/power4/multiarch/memchr-ppc32.c +++ b/sysdeps/powerpc/powerpc32/power4/multiarch/memchr-ppc32.c @@ -23,12 +23,10 @@ #undef weak_alias #define weak_alias(a, b) -#ifdef SHARED -# undef libc_hidden_builtin_def -# define libc_hidden_builtin_def(name) \ - __hidden_ver1(__memchr_ppc, __GI_memchr, __memchr_ppc); -#endif - extern __typeof (memchr) __memchr_ppc attribute_hidden; #include + +#ifdef SHARED +__hidden_ver1(__memchr_ppc, __GI_memchr, __memchr_ppc); +#endif