From patchwork Tue Oct  8 17:00:51 2019
Content-Type: text/plain; charset="utf-8"
MIME-Version: 1.0
Content-Transfer-Encoding: 7bit
X-Patchwork-Submitter: Florian Weimer <fweimer@redhat.com>
X-Patchwork-Id: 34877
Received: (qmail 14787 invoked by alias); 8 Oct 2019 17:00:56 -0000
Mailing-List: contact libc-alpha-help@sourceware.org; run by ezmlm
Precedence: bulk
List-Id: <libc-alpha.sourceware.org>
List-Unsubscribe: <mailto:libc-alpha-unsubscribe-##L=##H@sourceware.org>
List-Subscribe: <mailto:libc-alpha-subscribe@sourceware.org>
List-Archive: <http://sourceware.org/ml/libc-alpha/>
List-Post: <mailto:libc-alpha@sourceware.org>
List-Help: <mailto:libc-alpha-help@sourceware.org>,
	<http://sourceware.org/ml/#faqs>
Sender: libc-alpha-owner@sourceware.org
Delivered-To: mailing list libc-alpha@sourceware.org
Received: (qmail 14775 invoked by uid 89); 8 Oct 2019 17:00:55 -0000
Authentication-Results: sourceware.org; auth=none
X-Spam-SWARE-Status: No, score=-18.5 required=5.0 tests=AWL, BAYES_00,
	GIT_PATCH_0, GIT_PATCH_1, GIT_PATCH_2, GIT_PATCH_3,
	SPF_HELO_PASS autolearn=ham version=3.3.1 spammy=
X-HELO: mx1.redhat.com
From: Florian Weimer <fweimer@redhat.com>
To: Joseph Myers <joseph@codesourcery.com>
Cc: <libc-alpha@sourceware.org>
Subject: Re: [PATCH] wordexp: Split out command execution tests from
	posix/wordexp-test
References: <8736g3cxbq.fsf@oldenburg2.str.redhat.com>
	<alpine.DEB.2.21.1910081557200.23696@digraph.polyomino.org.uk>
Date: Tue, 08 Oct 2019 19:00:51 +0200
In-Reply-To: <alpine.DEB.2.21.1910081557200.23696@digraph.polyomino.org.uk>
	(Joseph Myers's message of "Tue, 8 Oct 2019 15:58:02 +0000")
Message-ID: <87k19f9np8.fsf@oldenburg2.str.redhat.com>
User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/26.2 (gnu/linux)
MIME-Version: 1.0

* Joseph Myers:

> On Tue, 8 Oct 2019, Florian Weimer wrote:
>
>> +#ifdef CLONE_NEWPID
>> +  if (unshare (CLONE_NEWPID) != 0)
>> +    printf ("warning: unshare (CLONE_NEW_PID) failed: %m\n"
>> +            "warning: This leads to reduced test coverage.\n");
>> +  else
>> +    pid_tests_supported = true;
>> +#else
>> +  printf ("warning: CLONE_NEW_PID not available.\n"
>
> The messages are saying CLONE_NEW_PID when the actual code is using 
> CLONE_NEWPID.

Sorry about that.  Fixed by the commit below.

Thanks,
Florian

8<------------------------------------------------------------------8<
Subject: posix/tst-wordexp-nocmd: Fix diagnostics output in test

2019-10-08  Florian Weimer  <fweimer@redhat.com>

	* posix/tst-wordexp-nocmd.c (do_test): Fix diagnostics output.

diff --git a/posix/tst-wordexp-nocmd.c b/posix/tst-wordexp-nocmd.c
index b2f64c819f..cb6033e15f 100644
--- a/posix/tst-wordexp-nocmd.c
+++ b/posix/tst-wordexp-nocmd.c
@@ -161,12 +161,12 @@ do_test (void)
 
 #ifdef CLONE_NEWPID
   if (unshare (CLONE_NEWPID) != 0)
-    printf ("warning: unshare (CLONE_NEW_PID) failed: %m\n"
+    printf ("warning: unshare (CLONE_NEWPID) failed: %m\n"
             "warning: This leads to reduced test coverage.\n");
   else
     pid_tests_supported = true;
 #else
-  printf ("warning: CLONE_NEW_PID not available.\n"
+  printf ("warning: CLONE_NEWPID not available.\n"
           "warning: This leads to reduced test coverage.\n");
 #endif