diff mbox series

elf: Remove unused NEED_DL_BASE_ADDR and _dl_base_addr

Message ID 87k0fv5ylp.fsf@oldenburg.str.redhat.com
State Committed
Commit cd0c333d2ea82d0ae14719bdbef86d99615bdb00
Headers show
Series elf: Remove unused NEED_DL_BASE_ADDR and _dl_base_addr | expand

Checks

Context Check Description
dj/TryBot-apply_patch success Patch applied to master at the time it was sent
dj/TryBot-32bit success Build for i686

Commit Message

Florian Weimer Dec. 23, 2021, 11:50 a.m. UTC
---
 elf/dl-sysdep.c | 8 --------
 1 file changed, 8 deletions(-)

Comments

Adhemerval Zanella Dec. 23, 2021, 12:31 p.m. UTC | #1
LGTM, thanks.

Reviewed-by: Adhemerval Zanella  <adhemerval.zanella@linaro.org>

On 23/12/2021 08:50, Florian Weimer via Libc-alpha wrote:
> ---
>  elf/dl-sysdep.c | 8 --------
>  1 file changed, 8 deletions(-)
> 
> diff --git a/elf/dl-sysdep.c b/elf/dl-sysdep.c
> index 4dc366eea4..1c78dc89c9 100644
> --- a/elf/dl-sysdep.c
> +++ b/elf/dl-sysdep.c
> @@ -54,9 +54,6 @@ extern char _end[] attribute_hidden;
>  /* Protect SUID program against misuse of file descriptors.  */
>  extern void __libc_check_standard_fds (void);
>  
> -#ifdef NEED_DL_BASE_ADDR
> -ElfW(Addr) _dl_base_addr;
> -#endif
>  int __libc_enable_secure attribute_relro = 0;
>  rtld_hidden_data_def (__libc_enable_secure)
>  /* This variable contains the lowest stack address ever used.  */
> @@ -136,11 +133,6 @@ _dl_sysdep_start (void **start_argptr,
>        case AT_ENTRY:
>  	user_entry = av->a_un.a_val;
>  	break;
> -#ifdef NEED_DL_BASE_ADDR
> -      case AT_BASE:
> -	_dl_base_addr = av->a_un.a_val;
> -	break;
> -#endif
>  #ifndef HAVE_AUX_SECURE
>        case AT_UID:
>        case AT_EUID:
>
diff mbox series

Patch

diff --git a/elf/dl-sysdep.c b/elf/dl-sysdep.c
index 4dc366eea4..1c78dc89c9 100644
--- a/elf/dl-sysdep.c
+++ b/elf/dl-sysdep.c
@@ -54,9 +54,6 @@  extern char _end[] attribute_hidden;
 /* Protect SUID program against misuse of file descriptors.  */
 extern void __libc_check_standard_fds (void);
 
-#ifdef NEED_DL_BASE_ADDR
-ElfW(Addr) _dl_base_addr;
-#endif
 int __libc_enable_secure attribute_relro = 0;
 rtld_hidden_data_def (__libc_enable_secure)
 /* This variable contains the lowest stack address ever used.  */
@@ -136,11 +133,6 @@  _dl_sysdep_start (void **start_argptr,
       case AT_ENTRY:
 	user_entry = av->a_un.a_val;
 	break;
-#ifdef NEED_DL_BASE_ADDR
-      case AT_BASE:
-	_dl_base_addr = av->a_un.a_val;
-	break;
-#endif
 #ifndef HAVE_AUX_SECURE
       case AT_UID:
       case AT_EUID: