[v2] nptl: Fix type of pthread_mutexattr_getrobust_np, pthread_mutexattr_setrobust_np (bug 28036)

Message ID 87fsuhydom.fsf@oldenburg.str.redhat.com
State Committed
Commit f3e664563361dc17530113b3205998d1f19dc4d9
Headers
Series [v2] nptl: Fix type of pthread_mutexattr_getrobust_np, pthread_mutexattr_setrobust_np (bug 28036) |

Checks

Context Check Description
dj/TryBot-apply_patch success Patch applied to master at the time it was sent
dj/TryBot-32bit success Build for i686

Commit Message

Florian Weimer Sept. 6, 2021, 2:35 p.m. UTC
  ---
 sysdeps/nptl/pthread.h | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)
  

Comments

Carlos O'Donell Sept. 21, 2021, 12:53 a.m. UTC | #1
On 9/6/21 10:35, Florian Weimer via Libc-alpha wrote:

Looks good on x86_64 and i686. OK for master.

Reviewed-by: Carlos O'Donell <carlos@redhat.com>
Tested-by: Carlos O'Donell <carlos@redhat.com>

> ---
>  sysdeps/nptl/pthread.h | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/sysdeps/nptl/pthread.h b/sysdeps/nptl/pthread.h
> index f1b7f2bdc6..43146e91c9 100644
> --- a/sysdeps/nptl/pthread.h
> +++ b/sysdeps/nptl/pthread.h
> @@ -933,7 +933,7 @@ extern int pthread_mutexattr_getrobust (const pthread_mutexattr_t *__attr,
>  # ifdef __USE_GNU
>  #  ifdef __REDIRECT_NTH
>  extern int __REDIRECT_NTH (pthread_mutexattr_getrobust_np,
> -			   (pthread_mutex_t *, int *),
> +			   (pthread_mutexattr_t *, int *),
>  			   pthread_mutexattr_getrobust) __nonnull ((1))
>    __attribute_deprecated_msg__ ("\
>  pthread_mutexattr_getrobust_np is deprecated, use pthread_mutexattr_getrobust");
> @@ -949,7 +949,7 @@ extern int pthread_mutexattr_setrobust (pthread_mutexattr_t *__attr,
>  # ifdef __USE_GNU
>  #  ifdef __REDIRECT_NTH
>  extern int __REDIRECT_NTH (pthread_mutexattr_setrobust_np,
> -			   (pthread_mutex_t *, int),
> +			   (pthread_mutexattr_t *, int),
>  			   pthread_mutexattr_setrobust) __nonnull ((1))
>    __attribute_deprecated_msg__ ("\
>  pthread_mutexattr_setrobust_np is deprecated, use pthread_mutexattr_setrobust");
>
  

Patch

diff --git a/sysdeps/nptl/pthread.h b/sysdeps/nptl/pthread.h
index f1b7f2bdc6..43146e91c9 100644
--- a/sysdeps/nptl/pthread.h
+++ b/sysdeps/nptl/pthread.h
@@ -933,7 +933,7 @@  extern int pthread_mutexattr_getrobust (const pthread_mutexattr_t *__attr,
 # ifdef __USE_GNU
 #  ifdef __REDIRECT_NTH
 extern int __REDIRECT_NTH (pthread_mutexattr_getrobust_np,
-			   (pthread_mutex_t *, int *),
+			   (pthread_mutexattr_t *, int *),
 			   pthread_mutexattr_getrobust) __nonnull ((1))
   __attribute_deprecated_msg__ ("\
 pthread_mutexattr_getrobust_np is deprecated, use pthread_mutexattr_getrobust");
@@ -949,7 +949,7 @@  extern int pthread_mutexattr_setrobust (pthread_mutexattr_t *__attr,
 # ifdef __USE_GNU
 #  ifdef __REDIRECT_NTH
 extern int __REDIRECT_NTH (pthread_mutexattr_setrobust_np,
-			   (pthread_mutex_t *, int),
+			   (pthread_mutexattr_t *, int),
 			   pthread_mutexattr_setrobust) __nonnull ((1))
   __attribute_deprecated_msg__ ("\
 pthread_mutexattr_setrobust_np is deprecated, use pthread_mutexattr_setrobust");