From patchwork Wed Jul 25 07:38:23 2018
Content-Type: text/plain; charset="utf-8"
MIME-Version: 1.0
Content-Transfer-Encoding: 7bit
X-Patchwork-Submitter: Florian Weimer <fweimer@redhat.com>
X-Patchwork-Id: 28598
Received: (qmail 49993 invoked by alias); 25 Jul 2018 07:38:29 -0000
Mailing-List: contact libc-alpha-help@sourceware.org; run by ezmlm
Precedence: bulk
List-Id: <libc-alpha.sourceware.org>
List-Unsubscribe: <mailto:libc-alpha-unsubscribe-##L=##H@sourceware.org>
List-Subscribe: <mailto:libc-alpha-subscribe@sourceware.org>
List-Archive: <http://sourceware.org/ml/libc-alpha/>
List-Post: <mailto:libc-alpha@sourceware.org>
List-Help: <mailto:libc-alpha-help@sourceware.org>,
	<http://sourceware.org/ml/#faqs>
Sender: libc-alpha-owner@sourceware.org
Delivered-To: mailing list libc-alpha@sourceware.org
Received: (qmail 49984 invoked by uid 89); 25 Jul 2018 07:38:28 -0000
Authentication-Results: sourceware.org; auth=none
X-Spam-SWARE-Status: No, score=-24.8 required=5.0 tests=AWL, BAYES_00,
	GIT_PATCH_0, GIT_PATCH_1, GIT_PATCH_2, GIT_PATCH_3,
	SPF_HELO_PASS autolearn=ham version=3.3.2 spammy=1987, 1988
X-HELO: mx1.redhat.com
Subject: Re: [PATCH v8 1/8] nptl: Add C11 threads thrd_* functions
To: Andreas Schwab <schwab@suse.de>,
	Adhemerval Zanella <adhemerval.zanella@linaro.org>
Cc: libc-alpha@sourceware.org
References: <1517591084-11347-1-git-send-email-adhemerval.zanella@linaro.org>
	<1517591084-11347-2-git-send-email-adhemerval.zanella@linaro.org>
	<mvmh8knzsqd.fsf@suse.de>
From: Florian Weimer <fweimer@redhat.com>
Message-ID: <87f201d8-2008-5579-19ad-cb0dded89f93@redhat.com>
Date: Wed, 25 Jul 2018 09:38:23 +0200
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101
	Thunderbird/52.8.0
MIME-Version: 1.0
In-Reply-To: <mvmh8knzsqd.fsf@suse.de>

On 07/25/2018 09:20 AM, Andreas Schwab wrote:
> On Feb 02 2018, Adhemerval Zanella <adhemerval.zanella@linaro.org> wrote:
> 
>> @@ -197,7 +197,8 @@ linknamespace-libs-xsi = $(linknamespace-libs-posix) \
>>   			 $(common-objpfx)crypt/libcrypt.a
>>   linknamespace-libs-ISO = $(linknamespace-libs-isoc)
>>   linknamespace-libs-ISO99 = $(linknamespace-libs-isoc)
>> -linknamespace-libs-ISO11 = $(linknamespace-libs-isoc)
>> +linknamespace-libs-ISO11 = $(linknamespace-libs-isoc) \
>> +			   $(common-objpfx)nptl/libpthread.a
>>   linknamespace-libs-XPG4 = $(linknamespace-libs-isoc) \
>>   			  $(common-objpfx)crypt/libcrypt.a
> 
> You have reverted commit e69d994a63, which breaks --disable-crypt
> builds.

Oh.  So we need this fix?

Thanks,
Florian

Subject: [PATCH] conform: Do not add libcrypt twice in linknamespace tests
To: libc-alpha@sourceware.org

2018-07-25  Florian Weimer  <fweimer@redhat.com>

	* conform/Makefile (linknamespace-libs-XPG4): Do not add libcrypt
	twice.

diff --git a/conform/Makefile b/conform/Makefile
index a0ab70e302..98a9f8ea3e 100644
--- a/conform/Makefile
+++ b/conform/Makefile
@@ -198,8 +198,7 @@ linknamespace-libs-ISO = $(linknamespace-libs-isoc)
 linknamespace-libs-ISO99 = $(linknamespace-libs-isoc)
 linknamespace-libs-ISO11 = $(linknamespace-libs-isoc) \
 			   $(common-objpfx)nptl/libpthread.a
-linknamespace-libs-XPG4 = $(linknamespace-libs-isoc) \
-			  $(common-objpfx)crypt/libcrypt.a
+linknamespace-libs-XPG4 = $(linknamespace-libs-isoc)
 linknamespace-libs-XPG42 = $(linknamespace-libs-XPG4)
 linknamespace-libs-POSIX = $(linknamespace-libs-thr)
 linknamespace-libs-UNIX98 = $(linknamespace-libs-xsi)