[v8,1/8] nptl: Add C11 threads thrd_* functions

Message ID 87f201d8-2008-5579-19ad-cb0dded89f93@redhat.com
State Superseded
Headers

Commit Message

Florian Weimer July 25, 2018, 7:38 a.m. UTC
  On 07/25/2018 09:20 AM, Andreas Schwab wrote:
> On Feb 02 2018, Adhemerval Zanella <adhemerval.zanella@linaro.org> wrote:
> 
>> @@ -197,7 +197,8 @@ linknamespace-libs-xsi = $(linknamespace-libs-posix) \
>>   			 $(common-objpfx)crypt/libcrypt.a
>>   linknamespace-libs-ISO = $(linknamespace-libs-isoc)
>>   linknamespace-libs-ISO99 = $(linknamespace-libs-isoc)
>> -linknamespace-libs-ISO11 = $(linknamespace-libs-isoc)
>> +linknamespace-libs-ISO11 = $(linknamespace-libs-isoc) \
>> +			   $(common-objpfx)nptl/libpthread.a
>>   linknamespace-libs-XPG4 = $(linknamespace-libs-isoc) \
>>   			  $(common-objpfx)crypt/libcrypt.a
> 
> You have reverted commit e69d994a63, which breaks --disable-crypt
> builds.

Oh.  So we need this fix?

Thanks,
Florian
  

Patch

Subject: [PATCH] conform: Do not add libcrypt twice in linknamespace tests
To: libc-alpha@sourceware.org

2018-07-25  Florian Weimer  <fweimer@redhat.com>

	* conform/Makefile (linknamespace-libs-XPG4): Do not add libcrypt
	twice.

diff --git a/conform/Makefile b/conform/Makefile
index a0ab70e302..98a9f8ea3e 100644
--- a/conform/Makefile
+++ b/conform/Makefile
@@ -198,8 +198,7 @@  linknamespace-libs-ISO = $(linknamespace-libs-isoc)
 linknamespace-libs-ISO99 = $(linknamespace-libs-isoc)
 linknamespace-libs-ISO11 = $(linknamespace-libs-isoc) \
 			   $(common-objpfx)nptl/libpthread.a
-linknamespace-libs-XPG4 = $(linknamespace-libs-isoc) \
-			  $(common-objpfx)crypt/libcrypt.a
+linknamespace-libs-XPG4 = $(linknamespace-libs-isoc)
 linknamespace-libs-XPG42 = $(linknamespace-libs-XPG4)
 linknamespace-libs-POSIX = $(linknamespace-libs-thr)
 linknamespace-libs-UNIX98 = $(linknamespace-libs-xsi)