locale: Add transliteration for Geresh, Gershayim (U+05F3, U+05F4)

Message ID 87eero8kep.fsf@mid.deneb.enyo.de
State Committed
Commit 981e638d38947837fd36520c4cb051342348779d
Delegated to: Carlos O'Donell
Headers
Series locale: Add transliteration for Geresh, Gershayim (U+05F3, U+05F4) |

Commit Message

Florian Weimer May 13, 2020, 5:37 a.m. UTC
  ISO-8859-8-based locales will need this transliteration if the locale
files contain these Unicode characters.

---
 locale/C-translit.h.in | 2 ++
 1 file changed, 2 insertions(+)
  

Comments

Carlos O'Donell May 14, 2020, 8:32 p.m. UTC | #1
On 5/13/20 1:37 AM, Florian Weimer wrote:
> ISO-8859-8-based locales will need this transliteration if the locale
> files contain these Unicode characters.
> 

OK for master.

The two transliterations seem reasonable for the C locale.

Reviewed-by: Carlos O'Donell <carlos@redhat.com>

> ---

OK. Good to see 3-dashes! :-)

>  locale/C-translit.h.in | 2 ++
>  1 file changed, 2 insertions(+)
> 
> diff --git a/locale/C-translit.h.in b/locale/C-translit.h.in
> index 31cd86a5cf..a0c545b7d3 100644
> --- a/locale/C-translit.h.in
> +++ b/locale/C-translit.h.in
> @@ -360,6 +360,8 @@
>  "\x04f5"	"ch`"	# <U04F5> CYRILLIC SMALL LETTER CHE WITH DIAERESIS
>  "\x04f8"	"Y`"	# <U04F8> CYRILLIC CAPITAL LETTER YERU WITH DIAERESIS
>  "\x04f9"	"y`"	# <U04F9> CYRILLIC SMALL LETTER YERU WITH DIAERESIS
> +"\x05f3"	"'"	# <U05F3> HEBREW PUNCTUATION GERESH

OK. Confirmed matches UTF-8 charmap.

> +"\x05f4"	"\""	# <U05F4> HEBREW PUNCTUATION GERSHAYIM

OK. Confirmed matches UTF-8 charmap. 

>  "\x2002"	" "	# <U2002> EN SPACE
>  "\x2003"	" "	# <U2003> EM SPACE
>  "\x2004"	" "	# <U2004> THREE-PER-EM SPACE
>
  

Patch

diff --git a/locale/C-translit.h.in b/locale/C-translit.h.in
index 31cd86a5cf..a0c545b7d3 100644
--- a/locale/C-translit.h.in
+++ b/locale/C-translit.h.in
@@ -360,6 +360,8 @@ 
 "\x04f5"	"ch`"	# <U04F5> CYRILLIC SMALL LETTER CHE WITH DIAERESIS
 "\x04f8"	"Y`"	# <U04F8> CYRILLIC CAPITAL LETTER YERU WITH DIAERESIS
 "\x04f9"	"y`"	# <U04F9> CYRILLIC SMALL LETTER YERU WITH DIAERESIS
+"\x05f3"	"'"	# <U05F3> HEBREW PUNCTUATION GERESH
+"\x05f4"	"\""	# <U05F4> HEBREW PUNCTUATION GERSHAYIM
 "\x2002"	" "	# <U2002> EN SPACE
 "\x2003"	" "	# <U2003> EM SPACE
 "\x2004"	" "	# <U2004> THREE-PER-EM SPACE