From patchwork Fri Jul 9 09:45:51 2021 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Florian Weimer X-Patchwork-Id: 44292 Return-Path: X-Original-To: patchwork@sourceware.org Delivered-To: patchwork@sourceware.org Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id 06D443984046 for ; Fri, 9 Jul 2021 09:46:24 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 06D443984046 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=sourceware.org; s=default; t=1625823984; bh=C4UlSiyIQkyFraQRS6eQsl0QouXduUUO3vx5pOkCZ3s=; h=To:Subject:Date:List-Id:List-Unsubscribe:List-Archive:List-Post: List-Help:List-Subscribe:From:Reply-To:From; b=XE3nFbn5Zv4eQXYq/60Z+FSvr5RivXLeed9vt1UHzYhPS1n8lfgmTUlcYH7tOyFIl idCBLhk8kiKC73ls4q8dWpVi9PFDUfWK+OhS2psHgD06j9azvg+3tdE3U7v1sms5Ek /cA0hCWJVXqx7dRTLh4U+zpuJojpz/QHNa1PUCe0= X-Original-To: libc-alpha@sourceware.org Delivered-To: libc-alpha@sourceware.org Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by sourceware.org (Postfix) with ESMTP id 80C9638515F3 for ; Fri, 9 Jul 2021 09:46:02 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 80C9638515F3 Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-546-5M34Kha9PeyUdxhaHFS8Kg-1; Fri, 09 Jul 2021 05:46:01 -0400 X-MC-Unique: 5M34Kha9PeyUdxhaHFS8Kg-1 Received: from smtp.corp.redhat.com (int-mx08.intmail.prod.int.phx2.redhat.com [10.5.11.23]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id 486DF802E61; Fri, 9 Jul 2021 09:46:00 +0000 (UTC) Received: from oldenburg.str.redhat.com (ovpn-112-103.rdu2.redhat.com [10.10.112.103]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 72856E706; Fri, 9 Jul 2021 09:45:59 +0000 (UTC) To: libc-alpha@sourceware.org Subject: posix/tst-spawn5 failes under make -j Date: Fri, 09 Jul 2021 11:45:51 +0200 Message-ID: <87czrrizw0.fsf@oldenburg.str.redhat.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.2 (gnu/linux) MIME-Version: 1.0 X-Scanned-By: MIMEDefang 2.84 on 10.5.11.23 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com X-Spam-Status: No, score=-12.8 required=5.0 tests=BAYES_00, DKIMWL_WL_HIGH, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, GIT_PATCH_0, RCVD_IN_DNSWL_LOW, RCVD_IN_MSPIKE_H4, RCVD_IN_MSPIKE_WL, SPF_HELO_NONE, SPF_NONE, TXREP autolearn=ham autolearn_force=no version=3.4.4 X-Spam-Checker-Version: SpamAssassin 3.4.4 (2020-01-24) on server2.sourceware.org X-BeenThere: libc-alpha@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Libc-alpha mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-Patchwork-Original-From: Florian Weimer via Libc-alpha From: Florian Weimer Reply-To: Florian Weimer Errors-To: libc-alpha-bounces+patchwork=sourceware.org@sourceware.org Sender: "Libc-alpha" This patch adds some additional diagonstics: It's the pipe from the make job server: error: tst-spawn5.c:122: unexpected open file descriptor 3: pipe:[9958839] I think the test needs to be changed so that lowfd is passed across the restart, and checking only considers descriptors >= lowfd. Comments? Thanks, Florian diff --git a/posix/tst-spawn5.c b/posix/tst-spawn5.c index 277b848794..5ba7c7fadb 100644 --- a/posix/tst-spawn5.c +++ b/posix/tst-spawn5.c @@ -116,7 +116,11 @@ handle_restart (int argc, char *argv[]) fds[i].found = found = true; if (!found) - FAIL_EXIT1 ("unexpected open file descriptor: %ld", fd); + { + char *path = xasprintf ("/proc/self/fd/%s", e->d_name); + char *resolved = xreadlink (path); + FAIL_EXIT1 ("unexpected open file descriptor %ld: %s", fd, resolved); + } } closedir (dirp);