From patchwork Fri Dec 15 17:10:00 2017 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: Thomas Schwinge X-Patchwork-Id: 24968 Received: (qmail 44885 invoked by alias); 15 Dec 2017 17:10:09 -0000 Mailing-List: contact libc-alpha-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Unsubscribe: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: libc-alpha-owner@sourceware.org Delivered-To: mailing list libc-alpha@sourceware.org Received: (qmail 44875 invoked by uid 89); 15 Dec 2017 17:10:09 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-24.9 required=5.0 tests=AWL, BAYES_00, GIT_PATCH_0, GIT_PATCH_1, GIT_PATCH_2, GIT_PATCH_3, RCVD_IN_DNSWL_NONE, SPF_PASS, URIBL_RED autolearn=ham version=3.3.2 spammy=H*r:PST X-HELO: relay1.mentorg.com From: Thomas Schwinge To: Samuel Thibault , Subject: Re: [hurd,commited] hurd: Fix rtld link In-Reply-To: <20171215164842.tvnqspomnvzt4umd@var.youpi.perso.aquilenet.fr> References: <20170903023345.24804-1-samuel.thibault@ens-lyon.org> <876098j7ij.fsf@euler.schwinge.homeip.net> <20171215164842.tvnqspomnvzt4umd@var.youpi.perso.aquilenet.fr> User-Agent: Notmuch/0.9-125-g4686d11 (http://notmuchmail.org) Emacs/25.2.2 (x86_64-pc-linux-gnu) Date: Fri, 15 Dec 2017 18:10:00 +0100 Message-ID: <87374bkjdj.fsf@euler.schwinge.homeip.net> MIME-Version: 1.0 Hi! On Fri, 15 Dec 2017 17:48:42 +0100, Samuel Thibault wrote: > Thomas Schwinge, on ven. 15 déc. 2017 17:11:32 +0100, wrote: > > On Sun, 3 Sep 2017 04:33:45 +0200, Samuel Thibault wrote: > > > --- a/sysdeps/mach/hurd/dl-sysdep.c > > > +++ b/sysdeps/mach/hurd/dl-sysdep.c > > > > > +int weak_function > > > +__access_noerrno (const char *file, int type) > > > +{ > > > + errno = ENOSYS; > > > + return -1; > > > +} > > D'oh... ;-) Pushed: commit d232f2e137127139addde487f0f01881b52cc446 Author: Thomas Schwinge Date: Fri Dec 15 17:00:50 2017 +0100 Don't set errno in Hurd rtld's __access_noerrno * sysdeps/mach/hurd/dl-sysdep.c (__access_noerrno): Don't set errno. Fixes commit 819ea3347e3a30a611488ceeec53650baaeb7961. Reviewed-by: Samuel Thibault --- ChangeLog | 5 +++++ sysdeps/mach/hurd/dl-sysdep.c | 1 - 2 files changed, 5 insertions(+), 1 deletion(-) Grüße Thomas diff --git ChangeLog ChangeLog index 00161628c5..027f948ec9 100644 --- ChangeLog +++ ChangeLog @@ -1,3 +1,8 @@ +2017-12-15 Thomas Schwinge + + * sysdeps/mach/hurd/dl-sysdep.c (__access_noerrno): Don't set + errno. + 2017-12-15 Joseph Myers * scripts/build-many-glibcs.py (Context.add_all_configs): Use diff --git sysdeps/mach/hurd/dl-sysdep.c sysdeps/mach/hurd/dl-sysdep.c index 2cc342ec8e..5121ce325c 100644 --- sysdeps/mach/hurd/dl-sysdep.c +++ sysdeps/mach/hurd/dl-sysdep.c @@ -575,7 +575,6 @@ check_no_hidden(__access_noerrno); int weak_function __access_noerrno (const char *file, int type) { - errno = ENOSYS; return -1; }