From patchwork Fri Jul 2 18:49:01 2021 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Florian Weimer X-Patchwork-Id: 44115 X-Patchwork-Delegate: carlos@redhat.com Return-Path: X-Original-To: patchwork@sourceware.org Delivered-To: patchwork@sourceware.org Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id 4D28C3984011 for ; Fri, 2 Jul 2021 19:03:35 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 4D28C3984011 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=sourceware.org; s=default; t=1625252615; bh=PCFPXmyvkNovxHUtpPCAbXGkRopUNBMEUmW1ImzQXYE=; h=To:Subject:In-Reply-To:References:Date:List-Id:List-Unsubscribe: List-Archive:List-Post:List-Help:List-Subscribe:From:Reply-To: From; b=dASB63bWi5EIkYwDyRrWNTQJsIrDE7tKIppFdT+Ewl1zkRXUNjLjgRutdEGXnYv1B ESJWx5/rjiBsq6DmFtiNAQTAvThwE5lCfz7cAxa7mbaI5Zg57Rd1UElfBdRB8C3l7f Oy4oCD0p62KkQ3ygLjkVkPovZjEGOrYPcmy3aobY= X-Original-To: libc-alpha@sourceware.org Delivered-To: libc-alpha@sourceware.org Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [216.205.24.124]) by sourceware.org (Postfix) with ESMTP id 0D3C33983C38 for ; Fri, 2 Jul 2021 18:49:07 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 0D3C33983C38 Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-565-I2QD4UY3PcimGgg8XX43ww-1; Fri, 02 Jul 2021 14:49:05 -0400 X-MC-Unique: I2QD4UY3PcimGgg8XX43ww-1 Received: from smtp.corp.redhat.com (int-mx08.intmail.prod.int.phx2.redhat.com [10.5.11.23]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id 7D32910B7467 for ; Fri, 2 Jul 2021 18:49:04 +0000 (UTC) Received: from oldenburg.str.redhat.com (ovpn-115-5.ams2.redhat.com [10.36.115.5]) by smtp.corp.redhat.com (Postfix) with ESMTPS id D3C6519D7C for ; Fri, 2 Jul 2021 18:49:03 +0000 (UTC) To: libc-alpha@sourceware.org Subject: [PATCH 17/30] resolv: Remove unnecessary res_isourserver_p call from send_dg In-Reply-To: References: X-From-Line: 77acbd3d188de737f5b13df002bc511f4a676b92 Mon Sep 17 00:00:00 2001 Message-Id: <77acbd3d188de737f5b13df002bc511f4a676b92.1625251245.git.fweimer@redhat.com> Date: Fri, 02 Jul 2021 20:49:01 +0200 User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.2 (gnu/linux) MIME-Version: 1.0 X-Scanned-By: MIMEDefang 2.84 on 10.5.11.23 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com X-Spam-Status: No, score=-12.7 required=5.0 tests=BAYES_00, DKIMWL_WL_HIGH, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, GIT_PATCH_0, RCVD_IN_DNSWL_LOW, RCVD_IN_MSPIKE_H4, RCVD_IN_MSPIKE_WL, SPF_HELO_NONE, SPF_NONE, TXREP autolearn=ham autolearn_force=no version=3.4.4 X-Spam-Checker-Version: SpamAssassin 3.4.4 (2020-01-24) on server2.sourceware.org X-BeenThere: libc-alpha@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Libc-alpha mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-Patchwork-Original-From: Florian Weimer via Libc-alpha From: Florian Weimer Reply-To: Florian Weimer Errors-To: libc-alpha-bounces+patchwork=sourceware.org@sourceware.org Sender: "Libc-alpha" As the comment indicates, the check is unnecessary due to the way the UDP socket is set up. --- resolv/res_send.c | 6 ------ 1 file changed, 6 deletions(-) diff --git a/resolv/res_send.c b/resolv/res_send.c index 77d6835e1a..b6139c7d62 100644 --- a/resolv/res_send.c +++ b/resolv/res_send.c @@ -1343,12 +1343,6 @@ send_dg(res_state statp, return close_and_return_error (statp, resplen2); } - /* Paranoia check. Due to the connected UDP socket, - the kernel has already filtered invalid addresses - for us. */ - if (!res_ourserver_p(statp, &from)) - goto wait; - /* Check for the correct header layout and a matching question. */ int matching_query = 0; /* Default to no matching query. */