diff mbox series

Remove MAP_VARIABLE from hppa bits/mman.h

Message ID 6e50c64-98e6-7cbf-52be-c0167eb2dd9@codesourcery.com
State Committed
Commit be9b883ddd12acd2baa517fd1b5b8c8be22f733a
Headers
Series Remove MAP_VARIABLE from hppa bits/mman.h |

Checks

Context Check Description
dj/TryBot-apply_patch success Patch applied to master at the time it was sent
dj/TryBot-32bit success Build for i686

Commit Message

Joseph Myers May 17, 2023, 8:38 p.m. UTC 
  As suggested in
<https://sourceware.org/pipermail/libc-alpha/2023-February/145890.html>,
remove the MAP_VARIABLE define from the hppa bits/mman.h, for
consistency with Linux 6.2 which removed the define there.

Tested with build-many-glibcs.py for hppa-linux-gnu.

Comments

Joseph Myers May 25, 2023, 9:34 p.m. UTC | #1 
Ping.  This patch 
<https://sourceware.org/pipermail/libc-alpha/2023-May/148220.html> is 
pending review.
Joseph Myers June 2, 2023, 10:11 p.m. UTC | #2 
Ping^2.  This patch 
<https://sourceware.org/pipermail/libc-alpha/2023-May/148220.html> is 
still pending review.
Carlos O'Donell June 3, 2023, 2:02 a.m. UTC | #3 
On 5/17/23 16:38, Joseph Myers wrote:
> As suggested in
> <https://sourceware.org/pipermail/libc-alpha/2023-February/145890.html>,
> remove the MAP_VARIABLE define from the hppa bits/mman.h, for
> consistency with Linux 6.2 which removed the define there.
> 
> Tested with build-many-glibcs.py for hppa-linux-gnu.
> 
> diff --git a/sysdeps/unix/sysv/linux/hppa/bits/mman.h b/sysdeps/unix/sysv/linux/hppa/bits/mman.h
> index f5a69693af..651b7dcb72 100644
> --- a/sysdeps/unix/sysv/linux/hppa/bits/mman.h
> +++ b/sysdeps/unix/sysv/linux/hppa/bits/mman.h
> @@ -24,7 +24,6 @@
>  
>  /* Other flags.  */
>  #define __MAP_ANONYMOUS	0x10		/* Don't use a file */
> -#define MAP_VARIABLE	0
>  
>  /* These are Linux-specific.  */
>  #define MAP_DENYWRITE	0x0800		/* ETXTBSY */
> 

LGTM.

Reviewed Linux at commit 933174ae28ba72ab8de5b35cb7c98fc211235096 (6.4.0-rc3)
and there is no more references to MAP_VARIABLE.

The references are removed as of 71bdea6f798b425bc0003780b13e3fdecb16a010 and
are no longer in the UAPI mman.h headers.

Reviewed-by: Carlos O'Donell <carlos@redhat.com>
diff mbox series

Patch

diff --git a/sysdeps/unix/sysv/linux/hppa/bits/mman.h b/sysdeps/unix/sysv/linux/hppa/bits/mman.h
index f5a69693af..651b7dcb72 100644
--- a/sysdeps/unix/sysv/linux/hppa/bits/mman.h
+++ b/sysdeps/unix/sysv/linux/hppa/bits/mman.h
@@ -24,7 +24,6 @@ 
 
 /* Other flags.  */
 #define __MAP_ANONYMOUS	0x10		/* Don't use a file */
-#define MAP_VARIABLE	0
 
 /* These are Linux-specific.  */
 #define MAP_DENYWRITE	0x0800		/* ETXTBSY */