diff mbox series

[3/5] i386: Remove OPTIMIZE_FOR_GCC_5 from Linux libc-do-syscall.S

Message ID 6645c08f9845d3d69b08fababf56766f21971013.1651518694.git.fweimer@redhat.com
State Committed
Commit 6e5c7a1e262961adb52443ab91bd2c9b72316402
Headers
Series Linux: Fall back to mmap if early sbrk fails |

Checks

Context Check Description
dj/TryBot-apply_patch success Patch applied to master at the time it was sent

Commit Message

Florian Weimer May 2, 2022, 7:15 p.m. UTC 
  After commit a78e6a10d0b50d0ca80309775980fc99944b1727
("i386: Remove broken CAN_USE_REGISTER_ASM_EBP (bug 28771)"),
it is never defined.
---
 sysdeps/unix/sysv/linux/i386/libc-do-syscall.S | 3 ---
 1 file changed, 3 deletions(-)

Comments

H.J. Lu May 2, 2022, 7:20 p.m. UTC | #1 
On Mon, May 2, 2022 at 12:18 PM Florian Weimer via Libc-alpha
<libc-alpha@sourceware.org> wrote:
>
> After commit a78e6a10d0b50d0ca80309775980fc99944b1727
> ("i386: Remove broken CAN_USE_REGISTER_ASM_EBP (bug 28771)"),
> it is never defined.
> ---
>  sysdeps/unix/sysv/linux/i386/libc-do-syscall.S | 3 ---
>  1 file changed, 3 deletions(-)
>
> diff --git a/sysdeps/unix/sysv/linux/i386/libc-do-syscall.S b/sysdeps/unix/sysv/linux/i386/libc-do-syscall.S
> index 04154f43e0..3eea5f3a5d 100644
> --- a/sysdeps/unix/sysv/linux/i386/libc-do-syscall.S
> +++ b/sysdeps/unix/sysv/linux/i386/libc-do-syscall.S
> @@ -18,8 +18,6 @@
>
>  #include <sysdep.h>
>
> -#ifndef OPTIMIZE_FOR_GCC_5
> -
>  /* %eax, %ecx, %edx and %esi contain the values expected by the kernel.
>     %edi points to a structure with the values of %ebx, %edi and %ebp.  */
>
> @@ -50,4 +48,3 @@ ENTRY (__libc_do_syscall)
>         cfi_restore (ebx)
>         ret
>  END (__libc_do_syscall)
> -#endif
> --
> 2.35.1
>
>

LGTM.

Reviewed-by: H.J. Lu <hjl.tools@gmail.com>

Thanks.
diff mbox series

Patch

diff --git a/sysdeps/unix/sysv/linux/i386/libc-do-syscall.S b/sysdeps/unix/sysv/linux/i386/libc-do-syscall.S
index 04154f43e0..3eea5f3a5d 100644
--- a/sysdeps/unix/sysv/linux/i386/libc-do-syscall.S
+++ b/sysdeps/unix/sysv/linux/i386/libc-do-syscall.S
@@ -18,8 +18,6 @@ 
 
 #include <sysdep.h>
 
-#ifndef OPTIMIZE_FOR_GCC_5
-
 /* %eax, %ecx, %edx and %esi contain the values expected by the kernel.
    %edi points to a structure with the values of %ebx, %edi and %ebp.  */
 
@@ -50,4 +48,3 @@  ENTRY (__libc_do_syscall)
 	cfi_restore (ebx)
 	ret
 END (__libc_do_syscall)
-#endif