From patchwork Thu Sep 19 10:28:15 2019 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Stefan Liebler X-Patchwork-Id: 34587 Received: (qmail 35988 invoked by alias); 19 Sep 2019 10:28:27 -0000 Mailing-List: contact libc-alpha-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Unsubscribe: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: libc-alpha-owner@sourceware.org Delivered-To: mailing list libc-alpha@sourceware.org Received: (qmail 35950 invoked by uid 89); 19 Sep 2019 10:28:25 -0000 Authentication-Results: sourceware.org; auth=none X-Spam-SWARE-Status: No, score=-22.9 required=5.0 tests=AWL, BAYES_00, GIT_PATCH_0, GIT_PATCH_1, GIT_PATCH_2, GIT_PATCH_3, KAM_SHORT, RCVD_IN_DNSWL_LOW, SPF_PASS autolearn=ham version=3.3.1 spammy= X-HELO: mx0a-001b2d01.pphosted.com Subject: Re: [PATCH] S390: Add support for HP_TIMING_NOW. To: libc-alpha@sourceware.org References: <463e855f-b4bb-97ea-9f83-2fa64a9e7164@linux.ibm.com> From: Stefan Liebler Date: Thu, 19 Sep 2019 12:28:15 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.8.0 MIME-Version: 1.0 In-Reply-To: x-cbid: 19091910-0016-0000-0000-000002AE0597 X-IBM-AV-DETECTION: SAVI=unused REMOTE=unused XFE=unused x-cbparentid: 19091910-0017-0000-0000-0000330EB45C Message-Id: <63b4b727-5b1d-f5e4-3552-be8c24352ae3@linux.ibm.com> On 9/18/19 4:24 PM, Adhemerval Zanella wrote: > > > On 10/09/2019 06:13, Stefan Liebler wrote: >> + >> +#ifndef _HP_TIMING_H >> + >> +/* The stckf instruction is available starting with z9-109 zarch CPUs. >> + As there is no extra configure check for z9-109, the z10 one is used. */ >> +#ifdef HAVE_S390_MIN_Z10_ZARCH_ASM_SUPPORT >> +# define _HP_TIMING_H 1 >> +# include > > Wouldn't be simple to define _HP_TIMING_S390_H instead? > Sure. I've just committed the attached patch. Thanks. Stefan commit ce89dc9649b789e85948d5da11145e34cafa2bcf Author: Stefan Liebler Date: Thu Sep 19 11:17:20 2019 +0200 S390: Use _HP_TIMING_S390_H instead of _HP_TIMING_H. Use macro _HP_TIMING_S390_H instead of _HP_TIMING_H in s390 specific hp-timing.h ChangeLog: * sysdeps/s390/hp-timing.h (_HP_TIMING_H): Undefine. (_HP_TIMING_S390_H): Define. diff --git a/sysdeps/s390/hp-timing.h b/sysdeps/s390/hp-timing.h index 793fb66a4d..c5c605c937 100644 --- a/sysdeps/s390/hp-timing.h +++ b/sysdeps/s390/hp-timing.h @@ -16,12 +16,12 @@ License along with the GNU C Library. If not, see . */ -#ifndef _HP_TIMING_H +#ifndef _HP_TIMING_S390_H +#define _HP_TIMING_S390_H 1 /* The stckf instruction is available starting with z9-109 zarch CPUs. As there is no extra configure check for z9-109, the z10 one is used. */ #ifdef HAVE_S390_MIN_Z10_ZARCH_ASM_SUPPORT -# define _HP_TIMING_H 1 # include /* We use 64 bit values for the times.